From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 290E3C00A8F for ; Tue, 24 Oct 2023 18:28:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2BBAD10E46F; Tue, 24 Oct 2023 18:28:01 +0000 (UTC) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8813010E46D for ; Tue, 24 Oct 2023 18:27:58 +0000 (UTC) Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-6c7c2c428c1so32662a34.0 for ; Tue, 24 Oct 2023 11:27:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698172077; x=1698776877; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZNng016sWlIYuCE41qXO+ZMCuxWjt/SPYUfNc1rT6qY=; b=nxDp70F4eOFPLTaa8hkvE1PJZEQ3F/gF40dDb2zn33c4HOsR6dONi5FpgT1ecTzKeo ZFyH3gvYi+Y2h1bJVghzIsypGo9rmMeXMNXP6YPl0HbVvRiTKqnCwPcFMEbY8yaRT7jr 9uqbuVJh7yxKI0oV9inOe/tZ8DU6PTR1gwSlra3tmFQ7C0X3BjLmBvehWjs1aFMs1BUe ZC4+vHnrCA3AHVLOYg/b9NQAeTRYXbn2wQNOZADUKixdKfOk0/g4aURr/m6oohhQYCEC pwOUVOfM3mDLOzp0ElaoA+y99UcxGy3GKy0mHYoHC1eHXnvnM/0UDbFDeYU5lB5qOtt2 Amsg== X-Gm-Message-State: AOJu0YzC9UblxaQ3QwbObbEs+WWRCZJQ/MLWtYAE9bgzw3BPU6cTug1d fH6h//W3KsnuFD2fACI7sw== X-Google-Smtp-Source: AGHT+IF4Mo7SI7+Mkd9TqQMoBcw8WQzBGoqowxfYx/0ojUXzi24Q6N3YSxHT8mMusatDWtCimTP/wg== X-Received: by 2002:a05:6870:13c6:b0:1e9:b5d7:4000 with SMTP id 6-20020a05687013c600b001e9b5d74000mr6763342oat.7.1698172077184; Tue, 24 Oct 2023 11:27:57 -0700 (PDT) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id cj19-20020a05687c041300b001c02f12abd0sm2231435oac.38.2023.10.24.11.27.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 11:27:56 -0700 (PDT) Received: (nullmailer pid 243306 invoked by uid 1000); Tue, 24 Oct 2023 18:27:55 -0000 Date: Tue, 24 Oct 2023 13:27:55 -0500 From: Rob Herring To: Chris Morgan Subject: Re: [PATCH 1/5] dt-bindings: display: panel: Update NewVision NV3051D compatibles Message-ID: <20231024182755.GA215478-robh@kernel.org> References: <20231018161848.346947-1-macroalpha82@gmail.com> <20231018161848.346947-2-macroalpha82@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, neil.armstrong@linaro.org, sboyd@kernel.org, sam@ravnborg.org, mturquette@baylibre.com, sebastian.reichel@collabora.com, dri-devel@lists.freedesktop.org, Chris Morgan , linux-rockchip@lists.infradead.org, Krzysztof Kozlowski , linux-clk@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Oct 19, 2023 at 09:50:38AM -0500, Chris Morgan wrote: > On Thu, Oct 19, 2023 at 11:22:19AM +0200, Krzysztof Kozlowski wrote: > > On 18/10/2023 18:18, Chris Morgan wrote: > > > From: Chris Morgan > > > > > > Update the NewVision NV3051D compatible strings by adding a new panel, > > > the powkiddy,rk2023-panel, and removing another entry, the > > > anbernic,rg353v-panel. The rg353v-panel is exactly identical to the > > > rg353p-panel and is not currently in use by any existing device tree. > > > The rk2023-panel is similar to the rg353p-panel but has slightly > > > different timings. > > > > This still does not explain me why do you want to remove old panel. > > When I originally wrote the driver I only had one piece of hardware > and I set the compatible string in the driver as newvision,nv3051d. > Unfortunately since then I've found 2 more devices in use that are > *just* different enough to require the driver to do things a bit > differently. In the case of the anbernic,rg351v-panel I need to > enable a new DSI flag; in the case of the powkiddy,rk2023-panel I need > to decrease the vertical back porch and drop the higher frequency > timings. > > The best way to accomplish this was to change the strategy from having > a single binding in the driver of newvision,nv3051d to a binding for > each distinct hardware where the differences apply. Exactly why the DT maintainers annoyingly ask for specific compatible strings which may not be used immediately. > Note that I've > looked at querying the DSI panel ID, but for each device the value > is identical (so it can't be used to differentiate the hardware sadly). > So the driver now has 3 different compatible strings. I could in this > case add a 4th compatible string of anbernic,rg353v-panel but it would > be identical to anbernic,rg353p-panel. For the moment we are using > anbernic,rg353p-panel everywhere (including the rg353v), so it makes > sense to drop this unused value while we can, at least to me. Your reasoning is the compatible string is unused, so remove it. If there's some reasoning about how the 2 panels are the same hardware or the rg353v is never going to be used or show up at some point, then that would be a reason to remove. You could also say the rg353v is just wrong because it should have a fallback compatible to rg353p and rather than fix it, just remove it for now since there are no known users of it. Rob