From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C398AC47DDB for ; Tue, 23 Jan 2024 03:24:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E2E9410E0E3; Tue, 23 Jan 2024 03:24:10 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD66B10E0E3 for ; Tue, 23 Jan 2024 03:24:09 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B0DF9CE2AE9; Tue, 23 Jan 2024 03:24:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67727C433F1; Tue, 23 Jan 2024 03:24:06 +0000 (UTC) Date: Mon, 22 Jan 2024 22:25:35 -0500 From: Steven Rostedt To: Dave Airlie Subject: Re: [PATCH] drm/qxl: pass a device into ttm init. Message-ID: <20240122222535.6f0023c2@gandalf.local.home> In-Reply-To: <20240123022015.1288588-1-airlied@gmail.com> References: <20240123022015.1288588-1-airlied@gmail.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , Rajneesh Bhardwaj , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 23 Jan 2024 12:20:15 +1000 Dave Airlie wrote: > From: Dave Airlie > > ttm init was changed to look at numa node, but that needed a device. > > Only qxl appears to not hand in a device, so just fix that. > > Fixes: b0a7ce53d494 ("drm/ttm: Schedule delayed_delete worker closer") > Reported-by: Steven Rostedt My tests seem to get past the crash with this patch and not my "fix". Tested-by: Steven Rostedt (Google) -- Steve > Cc: Rajneesh Bhardwaj > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/qxl/qxl_ttm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c > index 1a82629bce3f..1876419ea237 100644 > --- a/drivers/gpu/drm/qxl/qxl_ttm.c > +++ b/drivers/gpu/drm/qxl/qxl_ttm.c > @@ -195,7 +195,7 @@ int qxl_ttm_init(struct qxl_device *qdev) > int num_io_pages; /* != rom->num_io_pages, we include surface0 */ > > /* No others user of address space so set it to 0 */ > - r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, NULL, > + r = ttm_device_init(&qdev->mman.bdev, &qxl_bo_driver, qdev->ddev.dev, > qdev->ddev.anon_inode->i_mapping, > qdev->ddev.vma_offset_manager, > false, false);