From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5E99CDB474 for ; Mon, 23 Oct 2023 08:19:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF0A410E18B; Mon, 23 Oct 2023 08:19:20 +0000 (UTC) X-Greylist: delayed 1506 seconds by postgrey-1.36 at gabe; Mon, 23 Oct 2023 08:19:18 UTC Received: from mail-4323.proton.ch (mail-4323.proton.ch [185.70.43.23]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4C9910E185; Mon, 23 Oct 2023 08:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail2; t=1698049156; x=1698308356; bh=WxADqybr844I3oyxhgF11CfEL7UzS7ZR4cFdELQGNvc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=U2RcwxLU7ur57UbIqCUc41rPeN8/K52RWTLgORhgJU5QCGJ7yuP/p1Xi0EqVjMKAW htgDguF11LRmmTvNhgmHoWbDlWHHq+nQnEHLaJAHT4svQzQszctKAuxU9jcXg88xeW /r2ObbAxjn+pX9LpZfk8L9RoxG1aw0Sj7i6a3cEfZXXbMmPTGUNkHqYZbxBv0yVjvM gbTu505EB44iV5R0BwC6vJmBbDIR8ChlOn9NLzI1ZWR4hajxOIzWT2zrQkcSw4/Usw EsgsAcaN63gmyTSJc7XKGcWmJi9D+KDCEIwpQtvoHTOf0n7dSJHFC02fFuln/MkBmO eYnQkIKLYP0Ig== Date: Mon, 23 Oct 2023 08:19:05 +0000 To: Albert Esteve From: Simon Ser Subject: Re: [PATCH v6 0/9] Fix cursor planes with virtualized drivers Message-ID: <219B7sJmmuzo8lj-2i5F6y0pc8XM03X6NdxHUq_R76N71AcTptEPcpjKLO9Rutriw88YtJDRNqibuR-YICIkhPnrBnQSM-Uu9YCc2uZoOiM=@emersion.fr> In-Reply-To: References: <20231023074613.41327-1-aesteve@redhat.com> <-ngmaSLF2S5emYjTBWcLRNzvJRoe_eZ-Nv9HQhE6ZLuK8nIE2ZbfVh2G2O2Z41GoIFIRpts0ukEtFXUx8pNAptmrZBhlXxaQGykx_qCZ_9k=@emersion.fr> Feedback-ID: 1358184:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, qemu-devel@nongnu.org, banackm@vmware.com, virtualization@lists.linux-foundation.org, Gerd Hoffmann , mombasawalam@vmware.com, iforbes@vmware.com, Jonathan Corbet , javierm@redhat.com, VMware Graphics Reviewers , David Airlie , Maxime Ripard , Hans de Goede , ppaalanen@gmail.com, dri-devel@lists.freedesktop.org, spice-devel@lists.freedesktop.org, Gurchetan Singh , Matt Roper , linux-kernel@vger.kernel.org, krastevm@vmware.com, Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Monday, October 23rd, 2023 at 10:14, Albert Esteve = wrote: > On Mon, Oct 23, 2023 at 9:55=E2=80=AFAM Simon Ser w= rote: >=20 > > On Monday, October 23rd, 2023 at 09:46, Albert Esteve wrote: > >=20 > > > Link to the IGT test covering this patch (already merged): > > > https://lists.freedesktop.org/archives/igt-dev/2023-July/058427.html > >=20 > > Hmm. IGT should not be merged before the kernel, because as long as the > > kernel is not merged there might be some uAPI changes. >=20 > Right, but uAPI header was not updated on the IGT side. As per suggestion= of the > maintainers, I added a static variable that matches the definition on thi= s patch: > https://lists.freedesktop.org/archives/igt-dev/2023-August/058803.html >=20 > +/** > + * Clients which do set cursor hotspot and treat the cursor plane > + * like a mouse cursor should set this property. > + */ > +#define LOCAL_DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT=096 >=20 > Once this patch gets upstreamed, the localized definition will be removed= , > replaced by the real one. What if this patch gets delayed and another patch using the same number is merged into the kernel first? What if someone finds a design flaw in the uAPI and it needs to be completely changed? The IGT test would then be completely broken. As a rule of thumb: never merge user-space patches before kernel. As soon as the kernel part is merged, it's fine to locally copy definitions if desirable. > > > Mutter patch: > > > https://lists.freedesktop.org/archives/igt-dev/2023-July/058427.html > >=20 > > Seems like this link is same as IGT? Copy-pasta fail maybe? >=20 > Ah yes, my bad, this is the correct link: > https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3337 Thanks!