From: "Heiko Stübner" <heiko@sntech.de>
To: Chris Morgan <macroalpha82@gmail.com>,
linux-rockchip@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, neil.armstrong@linaro.org,
sboyd@kernel.org, sam@ravnborg.org, mturquette@baylibre.com,
Chris Morgan <macromorgan@hotmail.com>,
sebastian.reichel@collabora.com, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: arm: rockchip: Add Powkiddy RK2023
Date: Thu, 19 Oct 2023 13:35:31 +0200 [thread overview]
Message-ID: <2239084.Dhsi8hcfAM@diego> (raw)
In-Reply-To: <df3c067f-8732-46bf-aa93-852f41e9e4e9@linaro.org>
Am Donnerstag, 19. Oktober 2023, 11:21:47 CEST schrieb Krzysztof Kozlowski:
> On 18/10/2023 18:18, Chris Morgan wrote:
> > From: Chris Morgan <macromorgan@hotmail.com>
> >
> > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and
> > powered by the Rockchip RK3566 SoC.
> >
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > ---
> > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > index a349bf4da6bc..a6612185a7ff 100644
> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > @@ -674,6 +674,11 @@ properties:
> > - const: powkiddy,rgb30
> > - const: rockchip,rk3566
> >
> > + - description: Powkiddy RK2023
> > + items:
> > + - const: powkiddy,rk2023
>
> This cuold be just enum in previous entry :/ but I remember we talked
> about this once with Heiko.
Keeping similar devices together is perfectly fine. Like we do for example
with the Rock PI 4A/4A+/B/B+/C family directly below.
The powkiddy,rk2023 really looks like very similar to the rgb30, so
could do something similar.
The variant I don't like is having one big enum for _all_ boards using
the same soc.
Heiko
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> > + - const: rockchip,rk3566
>
>
>
> Best regards,
> Krzysztof
>
>
next prev parent reply other threads:[~2023-10-19 11:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 16:18 [PATCH 0/5] rockchip: Add Powkiddy RK2023 Chris Morgan
2023-10-18 16:18 ` [PATCH 1/5] dt-bindings: display: panel: Update NewVision NV3051D compatibles Chris Morgan
2023-10-19 9:22 ` Krzysztof Kozlowski
2023-10-19 14:50 ` Chris Morgan
2023-10-24 18:27 ` Rob Herring
2023-10-24 20:47 ` Chris Morgan
2023-10-18 16:18 ` [PATCH 2/5] drm/panel: nv3051d: Add Powkiddy RK2023 Panel Support Chris Morgan
2023-10-19 17:22 ` Jessica Zhang
2023-10-20 15:02 ` Chris Morgan
2023-10-27 22:43 ` Jessica Zhang
2023-10-18 16:18 ` [PATCH 3/5] clk: rockchip: rk3568: Add PLL rate for 115.2MHz Chris Morgan
2023-10-18 16:18 ` [PATCH 4/5] dt-bindings: arm: rockchip: Add Powkiddy RK2023 Chris Morgan
2023-10-19 9:21 ` Krzysztof Kozlowski
2023-10-19 11:35 ` Heiko Stübner [this message]
2023-10-19 14:43 ` Chris Morgan
2023-10-19 17:45 ` Heiko Stübner
2023-10-20 15:03 ` Chris Morgan
2023-10-24 15:47 ` Heiko Stübner
2023-10-25 19:17 ` Chris Morgan
2023-10-18 16:18 ` [PATCH 5/5] arm64: dts: rockchip: add " Chris Morgan
2023-10-19 8:54 ` (subset) [PATCH 0/5] rockchip: Add " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2239084.Dhsi8hcfAM@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).