From: Tom Rix <trix@redhat.com>
To: Luben Tuikov <luben.tuikov@amd.com>,
alexander.deucher@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch,
guchun.chen@amd.com, Prike.Liang@amd.com, Hawking.Zhang@amd.com
Cc: Nick Desaulniers <ndesaulniers@google.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: fix printk format for size_t variable
Date: Mon, 21 Feb 2022 13:02:03 -0800 [thread overview]
Message-ID: <24848c09-8cee-5df1-bf4c-9d187ac107af@redhat.com> (raw)
In-Reply-To: <84b3679e-8900-ae51-e700-867631618829@amd.com>
On 2/21/22 12:53 PM, Luben Tuikov wrote:
> On 2022-02-21 15:36, Tom Rix wrote:
>> On 2/21/22 11:57 AM, Luben Tuikov wrote:
>>> Hi Tom,
>>>
>>> This was already fixed with this patch, and LKML was CC-ed. See the CC tags in the patch below,
>>>
>>> commit 4f7d7cda90cbd7
>>> Author: Luben Tuikov <luben.tuikov@amd.com>
>>> Date: Wed Feb 16 16:47:32 2022 -0500
>>>
>>> drm/amdgpu: Fix ARM compilation warning
>>>
>>> Fix this ARM warning:
>> I glad it wasn't just mips ;)
>>
>> There have been a couple of build breaks with amdgpu recently.
>>
>> Nick asked about adding clang to your ci.
>>
>> Could at least one non x86_64 gcc also be added, maybe aarch64 ?
> Yeah, that's a great idea. I tried the make.cross (for ARM) as per
> the initial breakage report, but when I tried it, it got into a loop of
> "make ARCH=arm mrproper" --> "make prepare" --> "make ARCH=arm mrproper" --> "make prepare" --> ...
> and I couldn't figure out why.
Maybe need to set CROSS_COMPILE ?
> I don't mind adding ARM cross compilation into my local setup.
For crosses, I generate a 'make' script like
#!/bin/sh
export PATH=<path-to-cross-tools>/bin:$PATH
make ARCH=arm64 CROSS_COMPILE=aarch64-elf- $@
so workflow looks like normal, replacing make with ./make
Tom
>
> Regards,
> Luben
>
>
>> Tom
>>
>>>
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:664:35: warning: format '%ld'
>>> expects argument of type 'long int', but argument 4 has type 'size_t' {aka
>>> 'unsigned int'} [-Wformat=]
>>>
>>> Cc: Alex Deucher <Alexander.Deucher@amd.com>
>>> Cc: kbuild-all@lists.01.org
>>> Cc: linux-kernel@vger.kernel.org
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Fixes: 7e60fbfbdc10a0 ("drm/amdgpu: Show IP discovery in sysfs")
>>> Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
>>> Acked-by: Alex Deucher <Alexander.Deucher@amd.com>
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
>>> index 2506bcf36c870c..6c7ec058125e1d 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
>>> @@ -668,7 +668,7 @@ static int amdgpu_discovery_sysfs_ips(struct amdgpu_device *adev,
>>> le16_to_cpu(ip->hw_id) != ii)
>>> goto next_ip;
>>>
>>> - DRM_DEBUG("match:%d @ ip_offset:%ld", ii, ip_offset);
>>> + DRM_DEBUG("match:%d @ ip_offset:%zu", ii, ip_offset);
>>>
>>> /* We have a hw_id match; register the hw
>>> * block if not yet registered.
>>>
>>> Regards,
>>> Luben
>>>
>>> On 2022-02-21 12:37, trix@redhat.com wrote:
>>>> From: Tom Rix <trix@redhat.com>
>>>>
>>>> On mips64 allyesconfig, there is this build break
>>>> amdgpu_discovery.c:671:35: error: format '%ld' expects
>>>> argument of type 'long int', but argument 4 has
>>>> type 'size_t' {aka 'unsigned int'}
>>>> DRM_DEBUG("match:%d @ ip_offset:%ld", ii, ip_offset);
>>>>
>>>> For size_t, use %zu.
>>>>
>>>> Fixes: a6c40b178092 ("drm/amdgpu: Show IP discovery in sysfs")
>>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>>> ---
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
>>>> index 7c7e28fd912e..58238f67b1d3 100644
>>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
>>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
>>>> @@ -668,7 +668,7 @@ static int amdgpu_discovery_sysfs_ips(struct amdgpu_device *adev,
>>>> le16_to_cpu(ip->hw_id) != ii)
>>>> goto next_ip;
>>>>
>>>> - DRM_DEBUG("match:%d @ ip_offset:%ld", ii, ip_offset);
>>>> + DRM_DEBUG("match:%d @ ip_offset:%zu", ii, ip_offset);
>>>>
>>>> /* We have a hw_id match; register the hw
>>>> * block if not yet registered.
>>> Regards,
> Regards,
prev parent reply other threads:[~2022-02-21 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 17:37 [PATCH] drm/amdgpu: fix printk format for size_t variable trix
2022-02-21 19:57 ` Luben Tuikov
2022-02-21 20:36 ` Tom Rix
2022-02-21 20:53 ` Luben Tuikov
2022-02-21 21:02 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24848c09-8cee-5df1-bf4c-9d187ac107af@redhat.com \
--to=trix@redhat.com \
--cc=Hawking.Zhang@amd.com \
--cc=Prike.Liang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=guchun.chen@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luben.tuikov@amd.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).