From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht,
Molly Sophia <mollysophia379@gmail.com>,
phone-devel@vger.kernel.org,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH v4 2/2] drm: panel: Add novatek nt35596s panel driver
Date: Thu, 28 Jul 2022 16:07:42 +0200 [thread overview]
Message-ID: <24964892-d421-6104-c72a-187b484f99c6@linaro.org> (raw)
In-Reply-To: <YuKUNeazoho6LPTJ@ravnborg.org>
On 28/07/2022 15:50, Sam Ravnborg wrote:
> Hi Krzysztof
> On Thu, Jul 28, 2022 at 02:17:29PM +0200, Krzysztof Kozlowski wrote:
>> On 28/07/2022 04:35, Molly Sophia wrote:
>>> Novatek NT35596s is a generic DSI IC that drives command and video mode
>>> panels. Add the driver for it. Currently add support for the LCD panel
>>> from JDI connected with this IC, as found on Xiaomi Mi Mix2s phones.
>>>
>>> Changes in v4:
>>> - No change.
>>>
>>> Changes in v3:
>>> - Embed the support into existing driver (panel-novatek-nt36672a), as
>>> these two IC are similar with different initialization commands.
>>>
>>
>> This does not go to commit msg (---).
> It depends...
>
> In the drm sub-system the general rule is if someone cares to write it,
> then it deserves to be added to the commit message.
> So for drm patches it is perfectly fine to have the history part
> included in the commit message.
>
> These sub-system differences does not makes it easier - I know.
OK, but I find it weird to store "No change" in commit log :)
Best regards,
Krzysztof
prev parent reply other threads:[~2022-07-28 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 2:35 [PATCH v4 0/2] Add driver for Novatek NT35596S panel Molly Sophia
2022-07-28 2:35 ` [PATCH v4 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings Molly Sophia
2022-07-28 12:17 ` Krzysztof Kozlowski
2022-07-28 2:35 ` [PATCH v4 2/2] drm: panel: Add novatek nt35596s panel driver Molly Sophia
2022-07-28 12:17 ` Krzysztof Kozlowski
2022-07-28 13:50 ` Sam Ravnborg
2022-07-28 14:07 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24964892-d421-6104-c72a-187b484f99c6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mollysophia379@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).