From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Oded Gabbay <ogabbay@kernel.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
Jason Gunthorpe <jgg@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
Alex Deucher <alexander.deucher@amd.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
Jiho Chu <jiho.chu@samsung.com>,
Randy Dunlap <rdunlap@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Kevin Hilman <khilman@baylibre.com>,
Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>,
Jagan Teki <jagan@amarulasolutions.com>
Subject: Re: [RFC PATCH v3 3/3] drm: initialize accel framework
Date: Mon, 7 Nov 2022 09:24:52 -0700 [thread overview]
Message-ID: <2537e41d-f863-4819-57d2-09b9554f801b@quicinc.com> (raw)
In-Reply-To: <20221106210225.2065371-4-ogabbay@kernel.org>
On 11/6/2022 2:02 PM, Oded Gabbay wrote:
> @@ -603,6 +626,14 @@ static int drm_dev_init(struct drm_device *dev,
> /* no per-device feature limits by default */
> dev->driver_features = ~0u;
>
> + if (drm_core_check_feature(dev, DRIVER_COMPUTE_ACCEL) &&
> + (drm_core_check_feature(dev, DRIVER_RENDER) ||
> + drm_core_check_feature(dev, DRIVER_MODESET))) {
Shouldn't the indentation for the 2nd and 3rd line be such that the
start of the lines is aligned with the "(" on the first line?
next prev parent reply other threads:[~2022-11-07 16:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 21:02 [RFC PATCH v3 0/3] new subsystem for compute accelerator devices Oded Gabbay
2022-11-06 21:02 ` [RFC PATCH v3 1/3] drivers/accel: define kconfig and register a new major Oded Gabbay
2022-11-07 16:12 ` Jeffrey Hugo
2022-11-07 21:05 ` Oded Gabbay
2022-11-08 12:46 ` Stanislaw Gruszka
2022-11-08 12:48 ` Oded Gabbay
2022-11-06 21:02 ` [RFC PATCH v3 2/3] accel: add dedicated minor for accelerator devices Oded Gabbay
2022-11-07 16:20 ` Jeffrey Hugo
2022-11-07 21:06 ` Oded Gabbay
2022-11-08 13:13 ` Tvrtko Ursulin
2022-11-08 16:14 ` Oded Gabbay
2022-11-06 21:02 ` [RFC PATCH v3 3/3] drm: initialize accel framework Oded Gabbay
2022-11-07 16:24 ` Jeffrey Hugo [this message]
2022-11-07 21:04 ` Oded Gabbay
2022-11-07 16:07 ` [RFC PATCH v3 0/3] new subsystem for compute accelerator devices Jeffrey Hugo
2022-11-07 16:21 ` Matthew Wilcox
2022-11-07 16:20 ` Jason Gunthorpe
2022-11-11 22:03 ` Christopher Friedt
2022-11-13 15:05 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2537e41d-f863-4819-57d2-09b9554f801b@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=jagan@amarulasolutions.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jiho.chu@samsung.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.kwapulinski@linux.intel.com \
--cc=ogabbay@kernel.org \
--cc=rdunlap@infradead.org \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).