* [PATCH] drm/mxsfb: Make supported modifiers explicit
@ 2020-03-23 14:52 Guido Günther
2020-03-23 15:51 ` Lucas Stach
0 siblings, 1 reply; 6+ messages in thread
From: Guido Günther @ 2020-03-23 14:52 UTC (permalink / raw)
To: Marek Vasut, Stefan Agner, David Airlie, Daniel Vetter,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, dri-devel, linux-arm-kernel, linux-kernel
In contrast to other display controllers on imx like DCSS and ipuv3
lcdif/mxsfb does not support detiling e.g. vivante tiled layouts.
Since mesa might assume otherwise make it explicit that only
DRM_FORMAT_MOD_LINEAR is supported.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 762379530928..fc71e7a7a02e 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -73,6 +73,11 @@ static const uint32_t mxsfb_formats[] = {
DRM_FORMAT_RGB565
};
+static const uint64_t mxsfb_modifiers[] = {
+ DRM_FORMAT_MOD_LINEAR,
+ DRM_FORMAT_MOD_INVALID
+};
+
static struct mxsfb_drm_private *
drm_pipe_to_mxsfb_drm_private(struct drm_simple_display_pipe *pipe)
{
@@ -334,8 +339,8 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
}
ret = drm_simple_display_pipe_init(drm, &mxsfb->pipe, &mxsfb_funcs,
- mxsfb_formats, ARRAY_SIZE(mxsfb_formats), NULL,
- mxsfb->connector);
+ mxsfb_formats, ARRAY_SIZE(mxsfb_formats),
+ mxsfb_modifiers, mxsfb->connector);
if (ret < 0) {
dev_err(drm->dev, "Cannot setup simple display pipe\n");
goto err_vblank;
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mxsfb: Make supported modifiers explicit
2020-03-23 14:52 [PATCH] drm/mxsfb: Make supported modifiers explicit Guido Günther
@ 2020-03-23 15:51 ` Lucas Stach
2020-07-18 17:14 ` Guido Günther
0 siblings, 1 reply; 6+ messages in thread
From: Lucas Stach @ 2020-03-23 15:51 UTC (permalink / raw)
To: Guido Günther, Marek Vasut, Stefan Agner, David Airlie,
Daniel Vetter, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, dri-devel, linux-arm-kernel,
linux-kernel
Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther:
> In contrast to other display controllers on imx like DCSS and ipuv3
> lcdif/mxsfb does not support detiling e.g. vivante tiled layouts.
> Since mesa might assume otherwise make it explicit that only
> DRM_FORMAT_MOD_LINEAR is supported.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index 762379530928..fc71e7a7a02e 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -73,6 +73,11 @@ static const uint32_t mxsfb_formats[] = {
> DRM_FORMAT_RGB565
> };
>
> +static const uint64_t mxsfb_modifiers[] = {
> + DRM_FORMAT_MOD_LINEAR,
> + DRM_FORMAT_MOD_INVALID
> +};
> +
> static struct mxsfb_drm_private *
> drm_pipe_to_mxsfb_drm_private(struct drm_simple_display_pipe *pipe)
> {
> @@ -334,8 +339,8 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
> }
>
> ret = drm_simple_display_pipe_init(drm, &mxsfb->pipe, &mxsfb_funcs,
> - mxsfb_formats, ARRAY_SIZE(mxsfb_formats), NULL,
> - mxsfb->connector);
> + mxsfb_formats, ARRAY_SIZE(mxsfb_formats),
> + mxsfb_modifiers, mxsfb->connector);
> if (ret < 0) {
> dev_err(drm->dev, "Cannot setup simple display pipe\n");
> goto err_vblank;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mxsfb: Make supported modifiers explicit
2020-03-23 15:51 ` Lucas Stach
@ 2020-07-18 17:14 ` Guido Günther
2020-07-20 7:31 ` Daniel Vetter
2020-07-20 9:03 ` Stefan Agner
0 siblings, 2 replies; 6+ messages in thread
From: Guido Günther @ 2020-07-18 17:14 UTC (permalink / raw)
To: Lucas Stach
Cc: Marek Vasut, Pengutronix Kernel Team, dri-devel, David Airlie,
Sascha Hauer, linux-kernel, NXP Linux Team, Shawn Guo,
linux-arm-kernel
Hi,
On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote:
> Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther:
> > In contrast to other display controllers on imx like DCSS and ipuv3
> > lcdif/mxsfb does not support detiling e.g. vivante tiled layouts.
> > Since mesa might assume otherwise make it explicit that only
> > DRM_FORMAT_MOD_LINEAR is supported.
> >
> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
>
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Can i do anything to get this applied?
Cheers,
-- Guido
>
> > ---
> > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > index 762379530928..fc71e7a7a02e 100644
> > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > @@ -73,6 +73,11 @@ static const uint32_t mxsfb_formats[] = {
> > DRM_FORMAT_RGB565
> > };
> >
> > +static const uint64_t mxsfb_modifiers[] = {
> > + DRM_FORMAT_MOD_LINEAR,
> > + DRM_FORMAT_MOD_INVALID
> > +};
> > +
> > static struct mxsfb_drm_private *
> > drm_pipe_to_mxsfb_drm_private(struct drm_simple_display_pipe *pipe)
> > {
> > @@ -334,8 +339,8 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
> > }
> >
> > ret = drm_simple_display_pipe_init(drm, &mxsfb->pipe, &mxsfb_funcs,
> > - mxsfb_formats, ARRAY_SIZE(mxsfb_formats), NULL,
> > - mxsfb->connector);
> > + mxsfb_formats, ARRAY_SIZE(mxsfb_formats),
> > + mxsfb_modifiers, mxsfb->connector);
> > if (ret < 0) {
> > dev_err(drm->dev, "Cannot setup simple display pipe\n");
> > goto err_vblank;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mxsfb: Make supported modifiers explicit
2020-07-18 17:14 ` Guido Günther
@ 2020-07-20 7:31 ` Daniel Vetter
2020-07-20 9:03 ` Stefan Agner
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2020-07-20 7:31 UTC (permalink / raw)
To: Guido Günther
Cc: Marek Vasut, Pengutronix Kernel Team, dri-devel, David Airlie,
Sascha Hauer, linux-kernel, NXP Linux Team, Shawn Guo,
linux-arm-kernel
On Sat, Jul 18, 2020 at 07:14:07PM +0200, Guido Günther wrote:
> Hi,
> On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote:
> > Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther:
> > > In contrast to other display controllers on imx like DCSS and ipuv3
> > > lcdif/mxsfb does not support detiling e.g. vivante tiled layouts.
> > > Since mesa might assume otherwise make it explicit that only
> > > DRM_FORMAT_MOD_LINEAR is supported.
> > >
> > > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> >
> > Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
>
> Can i do anything to get this applied?
> Cheers,
Lucas has drm-misc commit rights, I expect him to push.
-Daniel
> -- Guido
>
> >
> > > ---
> > > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 +++++++--
> > > 1 file changed, 7 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > > index 762379530928..fc71e7a7a02e 100644
> > > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> > > @@ -73,6 +73,11 @@ static const uint32_t mxsfb_formats[] = {
> > > DRM_FORMAT_RGB565
> > > };
> > >
> > > +static const uint64_t mxsfb_modifiers[] = {
> > > + DRM_FORMAT_MOD_LINEAR,
> > > + DRM_FORMAT_MOD_INVALID
> > > +};
> > > +
> > > static struct mxsfb_drm_private *
> > > drm_pipe_to_mxsfb_drm_private(struct drm_simple_display_pipe *pipe)
> > > {
> > > @@ -334,8 +339,8 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
> > > }
> > >
> > > ret = drm_simple_display_pipe_init(drm, &mxsfb->pipe, &mxsfb_funcs,
> > > - mxsfb_formats, ARRAY_SIZE(mxsfb_formats), NULL,
> > > - mxsfb->connector);
> > > + mxsfb_formats, ARRAY_SIZE(mxsfb_formats),
> > > + mxsfb_modifiers, mxsfb->connector);
> > > if (ret < 0) {
> > > dev_err(drm->dev, "Cannot setup simple display pipe\n");
> > > goto err_vblank;
> >
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mxsfb: Make supported modifiers explicit
2020-07-18 17:14 ` Guido Günther
2020-07-20 7:31 ` Daniel Vetter
@ 2020-07-20 9:03 ` Stefan Agner
2020-07-20 10:03 ` Guido Günther
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Agner @ 2020-07-20 9:03 UTC (permalink / raw)
To: Guido Günther
Cc: Marek Vasut, Pengutronix Kernel Team, David Airlie, Sascha Hauer,
linux-kernel, dri-devel, NXP Linux Team, Shawn Guo,
linux-arm-kernel
On 2020-07-18 19:14, Guido Günther wrote:
> Hi,
> On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote:
>> Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther:
>> > In contrast to other display controllers on imx like DCSS and ipuv3
>> > lcdif/mxsfb does not support detiling e.g. vivante tiled layouts.
>> > Since mesa might assume otherwise make it explicit that only
>> > DRM_FORMAT_MOD_LINEAR is supported.
>> >
>> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
>>
>> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
>
> Can i do anything to get this applied?
> Cheers,
> -- Guido
Sorry about the delay, I was thinking to apply it with another patchset
which is not ready though.
Pushed this patch to drm-misc-next just now.
--
Stefan
>
>>
>> > ---
>> > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 +++++++--
>> > 1 file changed, 7 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
>> > index 762379530928..fc71e7a7a02e 100644
>> > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
>> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
>> > @@ -73,6 +73,11 @@ static const uint32_t mxsfb_formats[] = {
>> > DRM_FORMAT_RGB565
>> > };
>> >
>> > +static const uint64_t mxsfb_modifiers[] = {
>> > + DRM_FORMAT_MOD_LINEAR,
>> > + DRM_FORMAT_MOD_INVALID
>> > +};
>> > +
>> > static struct mxsfb_drm_private *
>> > drm_pipe_to_mxsfb_drm_private(struct drm_simple_display_pipe *pipe)
>> > {
>> > @@ -334,8 +339,8 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
>> > }
>> >
>> > ret = drm_simple_display_pipe_init(drm, &mxsfb->pipe, &mxsfb_funcs,
>> > - mxsfb_formats, ARRAY_SIZE(mxsfb_formats), NULL,
>> > - mxsfb->connector);
>> > + mxsfb_formats, ARRAY_SIZE(mxsfb_formats),
>> > + mxsfb_modifiers, mxsfb->connector);
>> > if (ret < 0) {
>> > dev_err(drm->dev, "Cannot setup simple display pipe\n");
>> > goto err_vblank;
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/mxsfb: Make supported modifiers explicit
2020-07-20 9:03 ` Stefan Agner
@ 2020-07-20 10:03 ` Guido Günther
0 siblings, 0 replies; 6+ messages in thread
From: Guido Günther @ 2020-07-20 10:03 UTC (permalink / raw)
To: Stefan Agner
Cc: Marek Vasut, Pengutronix Kernel Team, David Airlie, Sascha Hauer,
linux-kernel, dri-devel, NXP Linux Team, Shawn Guo,
linux-arm-kernel
Hi,
On Mon, Jul 20, 2020 at 11:03:04AM +0200, Stefan Agner wrote:
> On 2020-07-18 19:14, Guido Günther wrote:
> > Hi,
> > On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote:
> >> Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther:
> >> > In contrast to other display controllers on imx like DCSS and ipuv3
> >> > lcdif/mxsfb does not support detiling e.g. vivante tiled layouts.
> >> > Since mesa might assume otherwise make it explicit that only
> >> > DRM_FORMAT_MOD_LINEAR is supported.
> >> >
> >> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> >>
> >> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> >
> > Can i do anything to get this applied?
> > Cheers,
> > -- Guido
>
> Sorry about the delay, I was thinking to apply it with another patchset
> which is not ready though.
>
> Pushed this patch to drm-misc-next just now.
Thanks!
-- Guido
>
> --
> Stefan
>
> >
> >>
> >> > ---
> >> > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 +++++++--
> >> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> >> > index 762379530928..fc71e7a7a02e 100644
> >> > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> >> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> >> > @@ -73,6 +73,11 @@ static const uint32_t mxsfb_formats[] = {
> >> > DRM_FORMAT_RGB565
> >> > };
> >> >
> >> > +static const uint64_t mxsfb_modifiers[] = {
> >> > + DRM_FORMAT_MOD_LINEAR,
> >> > + DRM_FORMAT_MOD_INVALID
> >> > +};
> >> > +
> >> > static struct mxsfb_drm_private *
> >> > drm_pipe_to_mxsfb_drm_private(struct drm_simple_display_pipe *pipe)
> >> > {
> >> > @@ -334,8 +339,8 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
> >> > }
> >> >
> >> > ret = drm_simple_display_pipe_init(drm, &mxsfb->pipe, &mxsfb_funcs,
> >> > - mxsfb_formats, ARRAY_SIZE(mxsfb_formats), NULL,
> >> > - mxsfb->connector);
> >> > + mxsfb_formats, ARRAY_SIZE(mxsfb_formats),
> >> > + mxsfb_modifiers, mxsfb->connector);
> >> > if (ret < 0) {
> >> > dev_err(drm->dev, "Cannot setup simple display pipe\n");
> >> > goto err_vblank;
> >>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-20 10:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-23 14:52 [PATCH] drm/mxsfb: Make supported modifiers explicit Guido Günther
2020-03-23 15:51 ` Lucas Stach
2020-07-18 17:14 ` Guido Günther
2020-07-20 7:31 ` Daniel Vetter
2020-07-20 9:03 ` Stefan Agner
2020-07-20 10:03 ` Guido Günther
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).