dri-devel Archive on lore.kernel.org
 help / color / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: linux-rockchip@lists.infradead.org, Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Jonas Karlman <jonas@kwiboo.se>,
	Adrian Ratiu <adrian.ratiu@collabora.com>,
	Philippe CORNU <philippe.cornu@st.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Yannick FERTRE <yannick.fertre@st.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com
Subject: Re: [PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver
Date: Wed, 1 Jul 2020 09:50:09 +0200
Message-ID: <268c1219-87cb-e611-ea13-e55e0feacea0@baylibre.com> (raw)
In-Reply-To: <87lfk3kaj4.fsf@iwork.i-did-not-set--mail-host-address--so-tickle-me>

Hi Heiko,

Do you think someone can have a try of this patchset on a RK SoC ?

Thanks,
Neil

On 01/07/2020 08:35, Adrian Ratiu wrote:
> Hi Neil,
> 
> On Mon, 29 Jun 2020, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> Hi Adrian,
>> On 09/06/2020 19:49, Adrian Ratiu wrote:
>>> [Re-submitting to cc dri-devel, sorry about the noise]  Hello all,  v9 cleanly applies on top of latest next-20200609 tree. v9 does not depend on other patches as the last binding doc has been merged.   All feedback up to this point has been addressed. Specific details in individual patch changelogs. The biggest changes are the deprecation of the Synopsys DW bridge bind() API in favor of of_drm_find_bridge() and .attach callbacks, the addition of a TODO entry which outlines future planned bridge driver refactorings and a reordering of some i.MX 6 patches to appease checkpatch.   The idea behind the TODO is to get this regmap and i.MX 6 driver merged and then do the rest of refactorings in-tree because it's easier and the refactorings themselves are out-of-scope of this series which is adding i.MX 6 support and is quite big already, so please, if there are more refactoring ideas, let's add them to the TODO doc. :) I intend to tackle those after this series is merged to
>>> avoid two complex inter-dependent simultaneous series. 
>>
>> This has been around here for a long time and you seem to have addressed all the reviews.
>>>  As always more testing is welcome especially on Rockchip and STM SoCs. 
>>
>> It has been tested on STM, but I'd like a feedback on RK platform before applying the bridge parts.
>> Can the imx & stm patches be applied separately ?
> 
> Yes the IMX and STM patches can be applied separately, they just both depend on the common regmap patches.
> 
> The binding API removal change which directly touches RK can also be applied separately, but unfortunately I do not have access to a RK board with a DSI display to test it (or the bridge regmap logic on RK btw...), I just "eye-balled" the RK code based on the public docs and it LGTM.
> 
>> Neil
>>
>>>
>>> Big thank you to everyone who has contributed to this up to now,
>>> Adrian
>>>
>>> Adrian Ratiu (11):
>>>   drm: bridge: dw_mipi_dsi: add initial regmap infrastructure
>>>   drm: bridge: dw_mipi_dsi: abstract register access using reg_fields
>>>   drm: bridge: dw_mipi_dsi: add dsi v1.01 support
>>>   drm: bridge: dw_mipi_dsi: remove bind/unbind API
>>>   dt-bindings: display: add i.MX6 MIPI DSI host controller doc
>>>   ARM: dts: imx6qdl: add missing mipi dsi properties
>>>   drm: imx: Add i.MX 6 MIPI DSI host platform driver
>>>   drm: stm: dw-mipi-dsi: let the bridge handle the HW version check
>>>   drm: bridge: dw-mipi-dsi: split low power cfg register into fields
>>>   drm: bridge: dw-mipi-dsi: fix bad register field offsets
>>>   Documentation: gpu: todo: Add dw-mipi-dsi consolidation plan
>>>
>>>  .../display/imx/fsl,mipi-dsi-imx6.yaml        | 112 +++
>>>  Documentation/gpu/todo.rst                    |  25 +
>>>  arch/arm/boot/dts/imx6qdl.dtsi                |   8 +
>>>  drivers/gpu/drm/bridge/synopsys/Kconfig       |   1 +
>>>  drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 713 ++++++++++++------
>>>  drivers/gpu/drm/imx/Kconfig                   |   8 +
>>>  drivers/gpu/drm/imx/Makefile                  |   1 +
>>>  drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c        | 399 ++++++++++
>>>  .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c   |   7 +-
>>>  drivers/gpu/drm/stm/dw_mipi_dsi-stm.c         |  16 +-
>>>  10 files changed, 1059 insertions(+), 231 deletions(-)
>>>  create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml
>>>  create mode 100644 drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c
>>>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply index

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 17:49 Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 01/11] drm: bridge: dw_mipi_dsi: add initial regmap infrastructure Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 02/11] drm: bridge: dw_mipi_dsi: abstract register access using reg_fields Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 03/11] drm: bridge: dw_mipi_dsi: add dsi v1.01 support Adrian Ratiu
2020-06-10 12:20   ` Yannick FERTRE
2020-06-09 17:49 ` [PATCH v9 04/11] drm: bridge: dw_mipi_dsi: remove bind/unbind API Adrian Ratiu
2020-06-10 12:21   ` Yannick FERTRE
2020-06-09 17:49 ` [PATCH v9 05/11] dt-bindings: display: add i.MX6 MIPI DSI host controller doc Adrian Ratiu
2020-06-12 21:11   ` Rob Herring
2020-06-09 17:49 ` [PATCH v9 06/11] ARM: dts: imx6qdl: add missing mipi dsi properties Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 07/11] drm: imx: Add i.MX 6 MIPI DSI host platform driver Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 08/11] drm: stm: dw-mipi-dsi: let the bridge handle the HW version check Adrian Ratiu
2020-06-09 17:49 ` [PATCH v9 09/11] drm: bridge: dw-mipi-dsi: split low power cfg register into fields Adrian Ratiu
2020-06-10 12:21   ` Yannick FERTRE
2020-06-09 17:49 ` [PATCH v9 10/11] drm: bridge: dw-mipi-dsi: fix bad register field offsets Adrian Ratiu
2020-06-10 12:22   ` Yannick FERTRE
2020-06-09 17:49 ` [PATCH v9 11/11] Documentation: gpu: todo: Add dw-mipi-dsi consolidation plan Adrian Ratiu
2020-06-29  8:47 ` [PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver Neil Armstrong
2020-07-01  6:35   ` Adrian Ratiu
2020-07-01  7:50     ` Neil Armstrong [this message]
2020-07-01 12:50 ` Heiko Stübner
2020-07-01 20:32   ` Adrian Ratiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=268c1219-87cb-e611-ea13-e55e0feacea0@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=adrian.ratiu@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=philippe.cornu@st.com \
    --cc=yannick.fertre@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

dri-devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dri-devel/0 dri-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dri-devel dri-devel/ https://lore.kernel.org/dri-devel \
		dri-devel@lists.freedesktop.org
	public-inbox-index dri-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.dri-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git