From: "Heiko Stübner" <heiko@sntech.de>
To: Mark Yao <mark.yao@rock-chips.com>
Cc: zwl@rock-chips.com, linux-kernel@vger.kernel.org,
tfiga@chromium.org, linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, xw@rock-chips.com,
dkm@rock-chips.com, sandy.huang@rock-chips.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/6] drm/rockchip: vop: Default enable win2/3 area0 bit
Date: Wed, 22 Jul 2015 23:50:32 +0200 [thread overview]
Message-ID: <2715023.mZMEgdW6y4@diego> (raw)
In-Reply-To: <1437467140-13881-1-git-send-email-mark.yao@rock-chips.com>
Am Dienstag, 21. Juli 2015, 16:25:40 schrieb Mark Yao:
> Win2/3 support multiple area function, but we haven't found
> a suitable way to use it yet, so let's just use them as other windows
> with only area 0 enabled.
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
this could go as fix into 4.2 please.
With what is currently in 4.2-rc3 I'm loosing the mouse cursor in my xf86-
armsoc xserver [0]. Likely due to 0915da7dd75f ("drm/rockchip: vop: remove
hardware cursor window"). The xserver then selects a window for the cursor
itself, which seems to be one of the currently disabled ones.
This patch fixes this and gives me back my cursor :-)
Heiko
[0] https://github.com/mmind/xf86-video-armsoc/tree/devel/rockchip
> ---
> Changes in v3:
> Adviced by Tomasz Figa
> - fix patch comments.
> Changes in v2: None
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 47ce943..e08f318 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -276,6 +276,12 @@ static const struct vop_reg_data vop_init_reg_table[] =
> { {DSP_CTRL0, 0x00000000},
> {WIN0_CTRL0, 0x00000080},
> {WIN1_CTRL0, 0x00000080},
> + /* TODO: Win2/3 support multiple area function, but we haven't found
> + * a suitable way to use it yet, so let's just use them as other windows
> + * with only area 0 enabled.
> + */
> + {WIN2_CTRL0, 0x00000010},
> + {WIN3_CTRL0, 0x00000010},
> };
>
> /*
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-22 21:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 8:20 [PATCH v3 0/6] drm/rockchip: fixes and new features Mark Yao
2015-07-21 8:20 ` [PATCH v3 1/6] drm/rockchip: vop: Fix virtual stride calculation Mark Yao
2015-07-21 8:20 ` [PATCH v3 2/6] drm/rockchip: vop: Fix window dest start point Mark Yao
2015-07-21 8:20 ` [PATCH v3 3/6] drm/rockchip: vop: Add yuv plane support Mark Yao
2015-07-22 21:51 ` Heiko Stübner
2015-07-23 2:01 ` Mark yao
2015-07-21 8:25 ` [PATCH v3 4/6] drm/rockchip: vop: Default enable win2/3 area0 bit Mark Yao
2015-07-22 21:50 ` Heiko Stübner [this message]
2015-07-21 8:27 ` [PATCH v3 5/6] drm/rockchip: vop: restore vop registers when resume Mark Yao
2015-07-21 8:28 ` [PATCH v3 6/6] drm/rockchip: vop: support plane scale Mark Yao
2015-07-22 21:50 ` Heiko Stübner
2015-07-22 21:55 ` [PATCH v3 0/6] drm/rockchip: fixes and new features Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2715023.mZMEgdW6y4@diego \
--to=heiko@sntech.de \
--cc=dkm@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.yao@rock-chips.com \
--cc=sandy.huang@rock-chips.com \
--cc=tfiga@chromium.org \
--cc=xw@rock-chips.com \
--cc=zwl@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).