From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF487C433ED for ; Mon, 26 Apr 2021 19:06:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FEF761152 for ; Mon, 26 Apr 2021 19:06:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FEF761152 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F3C636E868; Mon, 26 Apr 2021 19:06:14 +0000 (UTC) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD1486E868 for ; Mon, 26 Apr 2021 19:06:13 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id ja3so10151485ejc.9 for ; Mon, 26 Apr 2021 12:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qzrC1Kq+MFBMN6fW/1czS9SkAtIfV8nGIBcDBhlNciY=; b=Tb9VmsvMB/FivTuyRMIAr19B99fb8vQEgeIf+3VRXtNPE15M8rtK8gghpsNzV4Ttyl lxObizfHcldMaQqCl9udQpKjNzapKnZzO4ZNNFhePp/bO6VS4ztacmwvfDLRAYZONsWO br/KyjyETMvDiXk+ZQJbbF5S2DixoIgx4qVpouCJBbcyJ5jC/R6Tppgi/KPDNvO3+P96 n2aOY/EZbIBWUUskwvx/g+lpAVVg11KBp47aloDxpnd1uAB3Ac7slprlYtyZQ0o88toe jPUIrgwmS9H2vQiAAsGCL9uqfJPVDmtxWCLRScwXLa4bDo/ujvHrMU0ljZZwjZ9SmuKl IcPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qzrC1Kq+MFBMN6fW/1czS9SkAtIfV8nGIBcDBhlNciY=; b=GSKqD8GLUhNRAK0+IGpIIZqSNpRRTyBbdTeVI+GvI1m+po15QXACYRXu6tkPM7Iqfk aYLAdVGh9er+EbbeQQmJ8JTxipdwcZJ7dN4VeWkHh767ptYrFfUiRTbOcMTVVbQ4OB1F jOBhuO+M0UJjHutlLHSP2ewPivIsGTVutRixWsAI4EXwWw4R/pSr5UQ612TwvPc81+me aTIj9LYO4JDtF6pUS72zd4Li+QlHT5SU2xj8Qdw1Z+EnPHqZv0caeD/uKbO+aN0eeM51 IlUj1DpHuLlIT+54J44eMuIb/Uk8Zd+rTksCT5qJ8ssjrF3wSbtgRbfLnPUeQgdiRSFB 3FdA== X-Gm-Message-State: AOAM530OMYb+X3oTRY5sCYugZexF981fCnG+msGxlaTqObAinSpl/AIk mHL80dSTw2d2PhnOoo/QQsE= X-Google-Smtp-Source: ABdhPJw5Ywwd/QvHUBnUl1XoxS56aFkZIGMrMvR+1GbW+V8G4KNO6cen1AWUazf8uYGziLa23kDnwA== X-Received: by 2002:a17:906:5906:: with SMTP id h6mr20186115ejq.176.1619463972520; Mon, 26 Apr 2021 12:06:12 -0700 (PDT) Received: from linux.local (host-79-52-107-152.retail.telecomitalia.it. [79.52.107.152]) by smtp.gmail.com with ESMTPSA id q25sm11756648ejd.9.2021.04.26.12.06.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 12:06:12 -0700 (PDT) From: "Fabio M. De Francesco" To: Daniel Vetter Subject: Re: [Outreachy kernel] Re: [PATCH] drm/amd/amdgpu/amdgpu_drv.c: Replace drm_modeset_lock_all with drm_modeset_lock Date: Mon, 26 Apr 2021 21:06:10 +0200 Message-ID: <28921365.3cLsizAqWR@linux.local> In-Reply-To: References: <20210422155951.6314-1-fmdefrancesco@gmail.com> <20210422165034.GP3596236@casper.infradead.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Wilcox , David Airlie , Melissa Wen , outreachy-kernel@googlegroups.com, dri-devel@lists.freedesktop.org, Thomas Zimmermann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Monday, April 26, 2021 6:11:11 PM CEST Daniel Vetter wrote: > On Thu, Apr 22, 2021 at 05:50:34PM +0100, Matthew Wilcox wrote: > > On Thu, Apr 22, 2021 at 05:59:51PM +0200, Fabio M. De Francesco wrote: > > > - drm_modeset_lock_all(drm_dev); > > > - > > > > > > drm_for_each_crtc(crtc, drm_dev) { > > > > > > + drm_modeset_lock(&crtc->mutex, NULL); > > > > > > if (crtc->state->active) { > > > > > > ret = -EBUSY; > > > > > > - break; > > > > > > } > > > > > > + drm_modeset_unlock(&crtc->mutex); > > > + if (ret < 0) > > > + break; > > > > > > } > > > > > > - drm_modeset_unlock_all(drm_dev); > > > - > > > > I might remove the {} around ret = -EBUSY, but this is good. > > > > Reviewed-by: Matthew Wilcox (Oracle) > > Yup patch looks good, but it's not cc'ed to drm/amdgpu maintainers/m-l, so > likely won't get picked up. Can you pls check scripts/get_maintainers for > anything you've missed, add those and resend with Willy's r-b tag > included? > > Then Alex can pick it up for merging. > > Thanks, Daniel > I had already submitted a v2 of this patch with an added 'Review-by' Matthew Wilcox under my name. It removed the unnecessary braces that willy pointed out. However I see that not all maintainers had been cc'ed, so I'm going to resend it as v3. Thanks, Fabio _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel