From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA97EC47093 for ; Sun, 30 May 2021 22:40:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5836161205 for ; Sun, 30 May 2021 22:40:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5836161205 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 79A046E095; Sun, 30 May 2021 22:40:47 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 138DD6E095 for ; Sun, 30 May 2021 22:40:47 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 7F6386120D; Sun, 30 May 2021 22:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622414446; bh=sc3R+OcBRxHghAUonKX5pP6gZpOYy1KwZ2uEQyTtgFw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=pkNqwGTUxIdX8NjYWGh7LlXj3qo9xJzzdxmWUnGf0UtzHzSVGof15D1EMCk8OhlHH FEYaTPYsZ0JQaskZIZe64uXcTAzWyP5b9cM0pbaPjdxg2pv5PoGjrND94f2st1fTEH sDR+w6tQZGFKO41jYYrCqcL3I/uScXN5Nx3UwbJT5qVCG7z+wDS/Dte/FQc4PSS8yq YbV+h702IRtxidsqPz3C5vBbulyYjuubmqWJXlM8fLckJzeC84QUm/V9S4jSk/0Lwr zADbsy7BQEAgJORLamFXccqqXooOjc96fmYGXHdJoJJ+OYAzTF7b+E0Ure7w4BOdIY +Z6ZPIuxh0iUg== Subject: Re: [PATCH v2] fb_defio: Remove custom address_space_operations To: Matthew Wilcox References: <20210310185530.1053320-1-willy@infradead.org> From: Nathan Chancellor Message-ID: <2977064f-42d0-7b64-176d-9509c205bfc3@kernel.org> Date: Sun, 30 May 2021 15:40:44 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-mm@kvack.org, Jani Nikula , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, William Kucharski , Ian Campbell , linux-fsdevel@vger.kernel.org, Jaya Kumar , Christoph Hellwig Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 5/30/2021 2:14 PM, Matthew Wilcox wrote: > On Sun, May 30, 2021 at 12:13:05PM -0700, Nathan Chancellor wrote: >> Hi Matthew, >> >> On Wed, Mar 10, 2021 at 06:55:30PM +0000, Matthew Wilcox (Oracle) wrote: >>> There's no need to give the page an address_space. Leaving the >>> page->mapping as NULL will cause the VM to handle set_page_dirty() >>> the same way that it's handled now, and that was the only reason to >>> set the address_space in the first place. >>> >>> Signed-off-by: Matthew Wilcox (Oracle) >>> Reviewed-by: Christoph Hellwig >>> Reviewed-by: William Kucharski >> >> This patch in mainline as commit ccf953d8f3d6 ("fb_defio: Remove custom >> address_space_operations") causes my Hyper-V based VM to no longer make >> it to a graphical environment. > > Hi Nathan, > > Thanks for the report. I sent Daniel a revert patch with a full > explanation last week, which I assume he'll queue up for a pull soon. > You can just git revert ccf953d8f3d6 for yourself until that shows up. > Sorry for the inconvenience. > Thank you for the quick response! I will keep an eye out for the patch while reverting it locally in the meantime. Cheers, Nathan