From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, MIME_QP_LONG_LINE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2758EC43603 for ; Thu, 12 Dec 2019 08:55:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EECA4214AF for ; Thu, 12 Dec 2019 08:55:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mntmn.com header.i=@mntmn.com header.b="r1zNK9UF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EECA4214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mntmn.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E2E16ECD7; Thu, 12 Dec 2019 08:55:12 +0000 (UTC) X-Greylist: delayed 479 seconds by postgrey-1.36 at gabe; Wed, 11 Dec 2019 20:24:35 UTC Received: from softboy.mntmn.com (softboy.mntmn.com [91.250.115.15]) by gabe.freedesktop.org (Postfix) with ESMTP id AD2FE6EB8B for ; Wed, 11 Dec 2019 20:24:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 softboy.mntmn.com 6E3307206B2 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mntmn.com; s=mailout; t=1576095394; bh=ttA1gcQY3v0SC2pPq/8dQvdaF1ZP/kGZmrhHV+IJ3SQ=; h=From:Subject:Date:References:Cc:In-Reply-To:To:From; b=r1zNK9UFerwizzFpHujssXuNw709igKjzCaU26BxyL/VX750iqAh2HyT0TjYClRX6 LAUp7a8tH7c53nw5W7D4ztV/DkyowXW+0X06KcEIc58jidulXKxoc4sCEfgIKMBRwp /sc9pcG8SNo2I2lSnLp1c6pul2WwsCf0KRiWUx8U= From: Lukas Hartmann Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v3 0/4] Add support for iMX8MQ Display Controller Subsystem Date: Wed, 11 Dec 2019 21:16:32 +0100 Message-Id: <29DC2566-B2AA-439A-B54B-A2FF35AA9538@mntmn.com> References: <1575625964-27102-1-git-send-email-laurentiu.palcu@nxp.com> In-Reply-To: <1575625964-27102-1-git-send-email-laurentiu.palcu@nxp.com> To: Laurentiu Palcu X-Mailer: iPhone Mail (17B111) X-Mailman-Approved-At: Thu, 12 Dec 2019 08:55:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, agx@sigxcpu.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1324586276==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============1324586276== Content-Type: multipart/alternative; boundary=Apple-Mail-81F7479F-F379-447F-9577-93204CEB1186 Content-Transfer-Encoding: 7bit --Apple-Mail-81F7479F-F379-447F-9577-93204CEB1186 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Laurentiu, thanks for the updated patch! I can confirm after intensive testing that the= hangs on boot are fixed in this version (I=E2=80=99m using DCSS->MIPI DSI->= TI eDP Bridge). Best Lukas --=20 Lukas F. Hartmann, CEO MNT Research GmbH https://mntre.com -- Did you know? Our Open Laptop MNT Reform will launch soon on Crowd Supply: h= ttps://www.crowdsupply.com/MNT/Reform > On 6. Dec 2019, at 10:53, Laurentiu Palcu wrote:= >=20 > =EF=BB=BFHi, >=20 > This patchset adds initial DCSS support for iMX8MQ chip. Initial support > includes only graphics plane support (no video planes), no HDR10 capabilit= ies, > no graphics decompression (only linear, tiled and super-tiled buffers allo= wed). >=20 > Support for the rest of the features will be added incrementally, in subse= quent > patches. >=20 > The patchset was tested with both HDP driver (not yet upstreamed) and MIPI= -DSI > (drivers already on the dri-devel ML). >=20 > Thanks, > Laurentiu >=20 > Changes in v3: > * rebased to latest linux-next and made it compile as drmP.h was > removed; > * removed the patch adding the VIDEO2_PLL clock. It's already applied; > * removed an unnecessary 50ms sleep in the dcss_dtg_sync_set(); > * fixed a a spurious hang reported by Lukas Hartmann and encountered > by me several times; > * mask DPR and DTG interrupts by default, as they may come enabled from > U-boot; >=20 > Changes in v2: > * Removed '0x' in node's unit-address both in DT and yaml; > * Made the address region size lowercase, to be consistent; > * Removed some left-over references to P010; > * Added a Kconfig dependency of DRM && ARCH_MXC. This will also silence co= mpilation > issues reported by kbuild for other architectures; >=20 >=20 > Laurentiu Palcu (4): > drm/imx: compile imx directory by default > drm/imx: Add initial support for DCSS on iMX8MQ > dt-bindings: display: imx: add bindings for DCSS > arm64: dts: imx8mq: add DCSS node >=20 > .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 86 +++ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 25 + > drivers/gpu/drm/Makefile | 2 +- > drivers/gpu/drm/imx/Kconfig | 2 + > drivers/gpu/drm/imx/Makefile | 1 + > drivers/gpu/drm/imx/dcss/Kconfig | 8 + > drivers/gpu/drm/imx/dcss/Makefile | 6 + > drivers/gpu/drm/imx/dcss/dcss-blkctl.c | 75 ++ > drivers/gpu/drm/imx/dcss/dcss-crtc.c | 224 ++++++ > drivers/gpu/drm/imx/dcss/dcss-ctxld.c | 447 +++++++++++ > drivers/gpu/drm/imx/dcss/dcss-dev.c | 286 +++++++ > drivers/gpu/drm/imx/dcss/dcss-dev.h | 195 +++++ > drivers/gpu/drm/imx/dcss/dcss-dpr.c | 550 ++++++++++++++ > drivers/gpu/drm/imx/dcss/dcss-drv.c | 181 +++++ > drivers/gpu/drm/imx/dcss/dcss-dtg.c | 442 +++++++++++ > drivers/gpu/drm/imx/dcss/dcss-kms.c | 322 ++++++++ > drivers/gpu/drm/imx/dcss/dcss-kms.h | 52 ++ > drivers/gpu/drm/imx/dcss/dcss-plane.c | 418 +++++++++++ > drivers/gpu/drm/imx/dcss/dcss-scaler.c | 826 +++++++++++++++++= ++++ > drivers/gpu/drm/imx/dcss/dcss-ss.c | 179 +++++ > 20 files changed, 4326 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/display/imx/nxp,imx8m= q-dcss.yaml > create mode 100644 drivers/gpu/drm/imx/dcss/Kconfig > create mode 100644 drivers/gpu/drm/imx/dcss/Makefile > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-blkctl.c > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-crtc.c > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-ctxld.c > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.c > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.h > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dpr.c > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-drv.c > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dtg.c > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-kms.c > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-kms.h > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-plane.c > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-scaler.c > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-ss.c >=20 > --=20 > 2.7.4 >=20 --Apple-Mail-81F7479F-F379-447F-9577-93204CEB1186 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Laurentiu,

thanks for= the updated patch! I can confirm after intensive testing that the hangs on b= oot are fixed in this version (I=E2=80=99m using DCSS->MIPI DSI->TI eD= P Bridge).

Best
Lukas
-- 

Lukas F. Hartmann, C= EO
MNT Research GmbH
https://mntre.com

--

Did you know? Our Open Laptop= MNT Reform will launch soon on Crowd Supply: https://= www.crowdsupply.com/MNT/Reform

On 6. Dec 2019, at 10:53, Laurentiu Palcu <laurentiu.pa= lcu@nxp.com> wrote:

<= div dir=3D"ltr">=EF=BB=BFHi,

This pat= chset adds initial DCSS support for iMX8MQ chip. Initial support
<= span>includes only graphics plane support (no video planes), no HDR10 capabi= lities,
no graphics decompression (only linear, tiled and su= per-tiled buffers allowed).

Support for the= rest of the features will be added incrementally, in subsequent
<= span>patches.

The patchset was tested with b= oth HDP driver (not yet upstreamed) and MIPI-DSI
(drivers al= ready on the dri-devel ML).

Thanks,<= br>Laurentiu

Changes in v3: * rebased to latest linux-next and made it compile as drmP.h was
  removed;
* removed the patch addi= ng the VIDEO2_PLL clock. It's already applied;
* removed an= unnecessary 50ms sleep in the dcss_dtg_sync_set();
* fixed= a a spurious hang reported by Lukas Hartmann and encountered
  by me several times;
* mask DPR and DTG inte= rrupts by default, as they may come enabled from
 &nbs= p;U-boot;

Changes in v2:
*= Removed '0x' in node's unit-address both in DT and yaml;
*= Made the address region size lowercase, to be consistent;
*= Removed some left-over references to P010;
* Added a Kconf= ig dependency of DRM && ARCH_MXC. This will also silence compilation=
  issues reported by kbuild for other architectu= res;


Laurentiu Palcu (4):<= /span>
 drm/imx: compile imx directory by default
<= span>  drm/imx: Add initial support for DCSS on iMX8MQ
=  dt-bindings: display: imx: add bindings for DCSS
&nb= sp;arm64: dts: imx8mq: add DCSS node

.../b= indings/display/imx/nxp,imx8mq-dcss.yaml      | &nb= sp;86 +++
arch/arm64/boot/dts/freescale/imx8mq.dtsi  &= nbsp;       |  25 +
= drivers/gpu/drm/Makefile         &n= bsp;            =      |   2 +-
drivers/gp= u/drm/imx/Kconfig          &nbs= p;            &n= bsp;|   2 +
drivers/gpu/drm/imx/Makefile  &n= bsp;            =         |   1 +
= drivers/gpu/drm/imx/dcss/Kconfig       =             | &n= bsp; 8 +
drivers/gpu/drm/imx/dcss/Makefile   = ;            &nb= sp;  |   6 +
drivers/gpu/drm/imx/dcss/d= css-blkctl.c           &nb= sp; |  75 ++
drivers/gpu/drm/imx/dcss/dcss-crtc.c=             &nb= sp; | 224 ++++++
drivers/gpu/drm/imx/dcss/dcss-ctxld.c=             &nb= sp;| 447 +++++++++++
drivers/gpu/drm/imx/dcss/dcss-dev.c &n= bsp;            =   | 286 +++++++
drivers/gpu/drm/imx/dcss/dcss-dev= .h             &= nbsp;  | 195 +++++
drivers/gpu/drm/imx/dcss/dcss-= dpr.c            &nbs= p;   | 550 ++++++++++++++
drivers/gpu/drm/im= x/dcss/dcss-drv.c          &nbs= p;     | 181 +++++
drivers/gpu/drm= /imx/dcss/dcss-dtg.c          &= nbsp;     | 442 +++++++++++
driver= s/gpu/drm/imx/dcss/dcss-kms.c        &nbs= p;       | 322 ++++++++
d= rivers/gpu/drm/imx/dcss/dcss-kms.h        = ;        |  52 ++
drivers/gpu/drm/imx/dcss/dcss-plane.c      &nbs= p;       | 418 +++++++++++
drivers/gpu/drm/imx/dcss/dcss-scaler.c      &nbs= p;      | 826 +++++++++++++++++++++
= drivers/gpu/drm/imx/dcss/dcss-ss.c      &nbs= p;          | 179 +++++
20 files changed, 4326 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/display/imx/nxp= ,imx8mq-dcss.yaml
create mode 100644 drivers/gpu/drm/imx/dc= ss/Kconfig
create mode 100644 drivers/gpu/drm/imx/dcss/Make= file
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-blkct= l.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-crtc.c=
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-ctxld.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.h create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dpr.c
create mode 100644 drivers/gpu/drm/imx/dcss/dcss-drv.c
c= reate mode 100644 drivers/gpu/drm/imx/dcss/dcss-dtg.c
creat= e mode 100644 drivers/gpu/drm/imx/dcss/dcss-kms.c
create mo= de 100644 drivers/gpu/drm/imx/dcss/dcss-kms.h
create mode 1= 00644 drivers/gpu/drm/imx/dcss/dcss-plane.c
create mode 100= 644 drivers/gpu/drm/imx/dcss/dcss-scaler.c
create mode 1006= 44 drivers/gpu/drm/imx/dcss/dcss-ss.c

--
2.7.4

= --Apple-Mail-81F7479F-F379-447F-9577-93204CEB1186-- --===============1324586276== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1324586276==--