From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1FA3C433F5 for ; Thu, 14 Apr 2022 08:56:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF6F410FCC6; Thu, 14 Apr 2022 08:56:27 +0000 (UTC) Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8A9B710FCC7 for ; Thu, 14 Apr 2022 08:56:26 +0000 (UTC) Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4KfCxM4tkkz9sR6; Thu, 14 Apr 2022 10:56:23 +0200 (CEST) Message-ID: <2bd105a2-9e55-f6f1-9d62-c4533470b05b@mailbox.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1649926581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g1ZNldq/EyB3mNJsRKqgMP8pcQ4qEP3WnTy07X0W1ek=; b=edpTTMLBlCs71+gtLUa5JE5qq4dai3UjdycEZQASCY6Zu4Mz3pK3JCoyRdieXSRU3ZJ7WZ cGPlODtsz8SNt7XuSqFb9qjhWpfBTHe/fmvqusco7X1H+NW9Nuas15RKBpxQGsF4NRj7Zs ltXuK/pQm9eqzSXWT6ifvdZH963vk0OCAenA9w3vE63mZt7ym+pb2pAy9Et9HuCinET8/+ JILXzGmWuuhDzCdAIfuPX5IqPcpJ/jGHne4rQBS8+ebj6ehfSoW13KpEY9R5E8fV8T6PVb CqobR+2exmpkIHHz2blD11mwuWAdWyG/4du8Tf9TdFDHZiKY0cNXtok4j7uWPw== Date: Thu, 14 Apr 2022 10:56:15 +0200 MIME-Version: 1.0 Subject: Re: [PATCH] drm/radeon: Add build directory to include path Content-Language: en-CA To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , Xinhui Pan References: <20220413161450.1854370-1-michel@daenzer.net> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2022-04-14 10:44, Christian König wrote: > Am 14.04.22 um 09:37 schrieb Michel Dänzer: >> On 2022-04-14 08:24, Christian König wrote: >>> Am 13.04.22 um 18:14 schrieb Michel Dänzer: >>>> From: Michel Dänzer >>>> >>>> Fixes compile errors with out-of-tree builds, e.g. >>>> >>>> ../drivers/gpu/drm/radeon/r420.c:38:10: fatal error: r420_reg_safe.h: No such file or directory >>>>      38 | #include "r420_reg_safe.h" >>>>         |          ^~~~~~~~~~~~~~~~~ >>> >>> Well stuff like that usually points to a broken build environment. >> Just a separate build directory. Specifically, I'm hitting the errors with >> >>   make -C build-amd64 M=drivers/gpu/drm >> >> Generated headers such as r420_reg_safe.h reside in the build directory, so source files in the source directory can't find them without an explicit search path. > > I'm trying to swap back into my brain how all of this used to work, but that's a really long time ago that I tried this as well. > >> Are you saying that should get added automagically somehow? > > Yes, exactly that. I'm like 95% sure that used to work, but I don't know why exactly either. Maybe it worked at some point, but regressed in the meantime? I only just switched to a separate build directory (so that I can easily build-test for other architectures). -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and Xwayland developer