* [PATCH] drm/amdgpu: Fix clang warning: unused label 'exit'
@ 2021-05-25 18:44 Andrey Grodzovsky
2021-05-26 13:59 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Grodzovsky @ 2021-05-25 18:44 UTC (permalink / raw)
To: dri-devel, amd-gfx; +Cc: Alexander.Deucher, kernel test robot
Problem:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:332:1: warning: unused label 'exit' [-Wunused-label]
exit:
^~~~~
Fix: Put #ifdef CONFIG_64BIT around exit
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index c547c78f3513..a10b4a7ccf5d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -330,7 +330,9 @@ void amdgpu_device_vram_access(struct amdgpu_device *adev, loff_t pos,
}
spin_unlock_irqrestore(&adev->mmio_idx_lock, flags);
+#ifdef CONFIG_64BIT
exit:
+#endif
drm_dev_exit(idx);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix clang warning: unused label 'exit'
2021-05-25 18:44 [PATCH] drm/amdgpu: Fix clang warning: unused label 'exit' Andrey Grodzovsky
@ 2021-05-26 13:59 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2021-05-26 13:59 UTC (permalink / raw)
To: Andrey Grodzovsky, dri-devel, amd-gfx
Cc: Alexander.Deucher, kernel test robot
Am 25.05.21 um 20:44 schrieb Andrey Grodzovsky:
> Problem:
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:332:1: warning: unused label 'exit' [-Wunused-label]
> exit:
> ^~~~~
>
> Fix: Put #ifdef CONFIG_64BIT around exit
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index c547c78f3513..a10b4a7ccf5d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -330,7 +330,9 @@ void amdgpu_device_vram_access(struct amdgpu_device *adev, loff_t pos,
> }
> spin_unlock_irqrestore(&adev->mmio_idx_lock, flags);
>
> +#ifdef CONFIG_64BIT
> exit:
> +#endif
> drm_dev_exit(idx);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-26 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 18:44 [PATCH] drm/amdgpu: Fix clang warning: unused label 'exit' Andrey Grodzovsky
2021-05-26 13:59 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).