From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05CD3C433E1 for ; Thu, 28 May 2020 13:23:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE873207F5 for ; Thu, 28 May 2020 13:23:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE873207F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BD5F6E527; Thu, 28 May 2020 13:23:07 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E69C6E527 for ; Thu, 28 May 2020 13:23:04 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C511DD6E; Thu, 28 May 2020 06:23:03 -0700 (PDT) Received: from [192.168.1.84] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 482683F52E; Thu, 28 May 2020 06:23:02 -0700 (PDT) Subject: Re: [PATCH 10/15] drm/panfrost: add regulators to devfreq To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Rob Herring , Tomeu Vizoso , Alyssa Rosenzweig , Viresh Kumar , Nishanth Menon , Stephen Boyd , Maxime Ripard , Chen-Yu Tsai References: <20200510165538.19720-1-peron.clem@gmail.com> <20200510165538.19720-11-peron.clem@gmail.com> From: Steven Price Message-ID: <2f0d2cd6-481c-26ce-fcef-ee5b4fdb249b@arm.com> Date: Thu, 28 May 2020 14:23:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200510165538.19720-11-peron.clem@gmail.com> Content-Language: en-GB X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMTAvMDUvMjAyMCAxNzo1NSwgQ2zDqW1lbnQgUMOpcm9uIHdyb3RlOgo+IFNvbWUgT1BQIHRh YmxlcyBzcGVjaWZ5IHZvbHRhZ2UgZm9yIGVhY2ggZnJlcXVlbmN5LiBEZXZmcmVxIGNhbgo+IGhh bmRsZSB0aGVzZSByZWd1bGF0b3JzIGJ1dCB0aGV5IHNob3VsZCBiZSBnZXQgb25seSAxIHRpbWUg dG8gYXZvaWQKPiBpc3N1ZSBhbmQga25vdyB3aG8gaXMgaW4gY2hhcmdlLgo+IAo+IElmIE9QUCB0 YWJsZSBpcyBwcm9iZSBkb24ndCBpbml0IHJlZ3VsYXRvci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBD bMOpbWVudCBQw6lyb24gPHBlcm9uLmNsZW1AZ21haWwuY29tPgoKVGhpcyBsb29rcyBsaWtlIGl0 IHNob3VsZCB3b3JrIC0gdGhhbmtzIGZvciBkb2luZyB0aGlzIQoKUmV2aWV3ZWQtYnk6IFN0ZXZl biBQcmljZSA8c3RldmVuLnByaWNlQGFybS5jb20+Cgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJt L3BhbmZyb3N0L3BhbmZyb3N0X2RldmZyZXEuYyB8IDE5ICsrKysrKysrKysrKysrKysrKysKPiAg IGRyaXZlcnMvZ3B1L2RybS9wYW5mcm9zdC9wYW5mcm9zdF9kZXZmcmVxLmggfCAgMiArKwo+ICAg ZHJpdmVycy9ncHUvZHJtL3BhbmZyb3N0L3BhbmZyb3N0X2RldmljZS5jICB8IDExICsrKysrKyst LS0tCj4gICAzIGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9wYW5mcm9zdC9wYW5mcm9zdF9kZXZm cmVxLmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZGV2ZnJlcS5jCj4gaW5k ZXggZmNlMjFjNjgyNDE0Li45ZmZlYTBkNGEwODcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL3BhbmZyb3N0L3BhbmZyb3N0X2RldmZyZXEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9w YW5mcm9zdC9wYW5mcm9zdF9kZXZmcmVxLmMKPiBAQCAtOTMsNiArOTMsNyBAQCBpbnQgcGFuZnJv c3RfZGV2ZnJlcV9pbml0KHN0cnVjdCBwYW5mcm9zdF9kZXZpY2UgKnBmZGV2KQo+ICAgCXVuc2ln bmVkIGxvbmcgY3VyX2ZyZXE7Cj4gICAJc3RydWN0IGRldmljZSAqZGV2ID0gJnBmZGV2LT5wZGV2 LT5kZXY7Cj4gICAJc3RydWN0IGRldmZyZXEgKmRldmZyZXE7Cj4gKwlzdHJ1Y3Qgb3BwX3RhYmxl ICpvcHBfdGFibGU7Cj4gICAJc3RydWN0IHRoZXJtYWxfY29vbGluZ19kZXZpY2UgKmNvb2xpbmc7 Cj4gICAJc3RydWN0IHBhbmZyb3N0X2RldmZyZXEgKnBmZGV2ZnJlcSA9ICZwZmRldi0+cGZkZXZm cmVxOwo+ICAgCj4gQEAgLTEwMiw2ICsxMDMsMTkgQEAgaW50IHBhbmZyb3N0X2RldmZyZXFfaW5p dChzdHJ1Y3QgcGFuZnJvc3RfZGV2aWNlICpwZmRldikKPiAgIAo+ICAgCXNwaW5fbG9ja19pbml0 KCZwZmRldmZyZXEtPmxvY2spOwo+ICAgCj4gKwlvcHBfdGFibGUgPSBkZXZfcG1fb3BwX3NldF9y ZWd1bGF0b3JzKGRldiwgcGZkZXYtPmNvbXAtPnN1cHBseV9uYW1lcywKPiArCQkJCQkgICAgICBw ZmRldi0+Y29tcC0+bnVtX3N1cHBsaWVzKTsKPiArCWlmIChJU19FUlIob3BwX3RhYmxlKSkgewo+ ICsJCXJldCA9IFBUUl9FUlIob3BwX3RhYmxlKTsKPiArCQkvKiBDb250aW51ZSBpZiB0aGUgb3B0 aW9uYWwgcmVndWxhdG9yIGlzIG1pc3NpbmcgKi8KPiArCQlpZiAocmV0ICE9IC1FTk9ERVYpIHsK PiArCQkJRFJNX0RFVl9FUlJPUihkZXYsICJDb3VsZG4ndCBzZXQgT1BQIHJlZ3VsYXRvcnNcbiIp Owo+ICsJCQlnb3RvIGVycl9maW5pOwo+ICsJCX0KPiArCX0gZWxzZSB7Cj4gKwkJcGZkZXZmcmVx LT5yZWd1bGF0b3JzX29wcF90YWJsZSA9IG9wcF90YWJsZTsKPiArCX0KPiArCj4gICAJcmV0ID0g ZGV2X3BtX29wcF9vZl9hZGRfdGFibGUoZGV2KTsKPiAgIAlpZiAocmV0KSB7Cj4gICAJCURSTV9E RVZfRVJST1IoZGV2LCAiQ291bGRuJ3QgYWRkIE9QUCB0YWJsZVxuIik7Cj4gQEAgLTE1Nyw2ICsx NzEsMTEgQEAgdm9pZCBwYW5mcm9zdF9kZXZmcmVxX2Zpbmkoc3RydWN0IHBhbmZyb3N0X2Rldmlj ZSAqcGZkZXYpCj4gICAJCWRldl9wbV9vcHBfb2ZfcmVtb3ZlX3RhYmxlKCZwZmRldi0+cGRldi0+ ZGV2KTsKPiAgIAkJcGZkZXZmcmVxLT5vcHBfb2ZfdGFibGVfYWRkZWQgPSBmYWxzZTsKPiAgIAl9 Cj4gKwo+ICsJaWYgKHBmZGV2ZnJlcS0+cmVndWxhdG9yc19vcHBfdGFibGUpIHsKPiArCQlkZXZf cG1fb3BwX3B1dF9yZWd1bGF0b3JzKHBmZGV2ZnJlcS0+cmVndWxhdG9yc19vcHBfdGFibGUpOwo+ ICsJCXBmZGV2ZnJlcS0+cmVndWxhdG9yc19vcHBfdGFibGUgPSBOVUxMOwo+ICsJfQo+ICAgfQo+ ICAgCj4gICB2b2lkIHBhbmZyb3N0X2RldmZyZXFfcmVzdW1lKHN0cnVjdCBwYW5mcm9zdF9kZXZp Y2UgKnBmZGV2KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJv c3RfZGV2ZnJlcS5oIGIvZHJpdmVycy9ncHUvZHJtL3BhbmZyb3N0L3BhbmZyb3N0X2RldmZyZXEu aAo+IGluZGV4IGFkZDIwM2NiMDBjMi4uMzQ3Y2RlNDc4NmNmIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9wYW5mcm9zdC9wYW5mcm9zdF9kZXZmcmVxLmgKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZGV2ZnJlcS5oCj4gQEAgLTgsMTIgKzgsMTQgQEAKPiAg ICNpbmNsdWRlIDxsaW51eC9rdGltZS5oPgo+ICAgCj4gICBzdHJ1Y3QgZGV2ZnJlcTsKPiArc3Ry dWN0IG9wcF90YWJsZTsKPiAgIHN0cnVjdCB0aGVybWFsX2Nvb2xpbmdfZGV2aWNlOwo+ICAgCj4g ICBzdHJ1Y3QgcGFuZnJvc3RfZGV2aWNlOwo+ICAgCj4gICBzdHJ1Y3QgcGFuZnJvc3RfZGV2ZnJl cSB7Cj4gICAJc3RydWN0IGRldmZyZXEgKmRldmZyZXE7Cj4gKwlzdHJ1Y3Qgb3BwX3RhYmxlICpy ZWd1bGF0b3JzX29wcF90YWJsZTsKPiAgIAlzdHJ1Y3QgdGhlcm1hbF9jb29saW5nX2RldmljZSAq Y29vbGluZzsKPiAgIAlib29sIG9wcF9vZl90YWJsZV9hZGRlZDsKPiAgIAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZGV2aWNlLmMgYi9kcml2ZXJzL2dw dS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZGV2aWNlLmMKPiBpbmRleCA2N2VlZGY2NGU4MmQuLjhi MTdmYjJlMzM2OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJv c3RfZGV2aWNlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZGV2 aWNlLmMKPiBAQCAtMjIyLDEwICsyMjIsMTMgQEAgaW50IHBhbmZyb3N0X2RldmljZV9pbml0KHN0 cnVjdCBwYW5mcm9zdF9kZXZpY2UgKnBmZGV2KQo+ICAgCQlnb3RvIGVycl9vdXQwOwo+ICAgCX0K PiAgIAo+IC0JZXJyID0gcGFuZnJvc3RfcmVndWxhdG9yX2luaXQocGZkZXYpOwo+IC0JaWYgKGVy cikgewo+IC0JCWRldl9lcnIocGZkZXYtPmRldiwgInJlZ3VsYXRvciBpbml0IGZhaWxlZCAlZFxu IiwgZXJyKTsKPiAtCQlnb3RvIGVycl9vdXQxOwo+ICsJLyogT1BQIHdpbGwgaGFuZGxlIHJlZ3Vs YXRvcnMgKi8KPiArCWlmICghcGZkZXYtPnBmZGV2ZnJlcS5vcHBfb2ZfdGFibGVfYWRkZWQpIHsK PiArCQllcnIgPSBwYW5mcm9zdF9yZWd1bGF0b3JfaW5pdChwZmRldik7Cj4gKwkJaWYgKGVycikg ewo+ICsJCQlkZXZfZXJyKHBmZGV2LT5kZXYsICJyZWd1bGF0b3IgaW5pdCBmYWlsZWQgJWRcbiIs IGVycik7Cj4gKwkJCWdvdG8gZXJyX291dDE7Cj4gKwkJfQo+ICAgCX0KPiAgIAo+ICAgCWVyciA9 IHBhbmZyb3N0X3Jlc2V0X2luaXQocGZkZXYpOwo+IAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==