From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 640A6C433ED for ; Wed, 28 Apr 2021 14:18:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC8CA61412 for ; Wed, 28 Apr 2021 14:18:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC8CA61412 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F00C36EB4D; Wed, 28 Apr 2021 14:18:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id AF6486EB4D for ; Wed, 28 Apr 2021 14:18:52 +0000 (UTC) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 3F81B82CAE; Wed, 28 Apr 2021 16:18:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1619619531; bh=O/bGhJtvPfnZ16k+I5YGxy78FYHe9Z8gEGv1ABkgxi4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PYrSzcI21whfPfGqHZW+UDdok0u9AhV/+G0psBePo4AFETQ4OsIYIt7grS521ie1U aFf7H+RefifuYZpwaqpneQLjzZwKNBAlQHia4Kv1enoHPLGTZH9oYv3IC9JImcdazS AUCgMPcZb3bAjCYi/NzLh2aEetyTOaD92vP+hAvVAn46trJElpySIiGXmNCnXCXvs4 umiQ9aPEYv2mWnd1XZM24yjiDuk7gx/vONOENfM09WE+qf830aZOJbYZeuTGxDe2hH Z3/u7A7N8sKuVZQBKFlNF6v5nCV3Uxd52O3mDPSwUkZSjIEy6oDLCctLtBnW3Ip2aR fKf5mKv4uMhFQ== Subject: Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver To: Jagan Teki , Neil Armstrong , Loic Poulain References: <20210421223122.112736-1-marex@denx.de> <20210421223122.112736-2-marex@denx.de> <66386909-5b89-78ab-6fcc-5bef95a66035@kontron.de> From: Marek Vasut Message-ID: <3080c269-1f7e-dcee-efdd-d240063b6f2b@denx.de> Date: Wed, 28 Apr 2021 16:18:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Claudius Heine , Douglas Anderson , dri-devel , Stephen Boyd , Philippe Schenker , Frieder Schrempf , Valentin Raevsky , Sam Ravnborg , Laurent Pinchart Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 4/28/21 11:49 AM, Jagan Teki wrote: [...] >>>> I just saw the note in the header of the driver that says that single >>>> link mode is unsupported for the DSI84. >>>> >>>> I have hardware with a single link display and if I set >>>> ctx->lvds_dual_link = false it works just fine. >>>> >>>> How is this supposed to be selected? Does it need an extra devicetree >>>> property? And would you mind adding single-link support in the next >>>> version or do you prefer adding it in a follow-up patch? >>> >>> If this has to be supported I think the proper way would be to support >>> two output ports in the dts (e.g. lvds0_out, lvds1_out), in the same >>> way as supported by the 'advantech,idk-2121wr' panel. >> >> Yes, this is why I asked to have the dual-link lvds in the bindings. > > Agreed with Neil, this is what we discussed on my v3. Each of these 3 > chips has its own compatible and supporting dual-link lvds and > dual-link dsi as to be done by 84/85 and 85 respectively. I have a counter-proposal to this single/dual link LVDS panel handling, maybe this should really be done using DRM_BUS_FLAG added to the panel, to indicate whether it is single or dual link. Then the bridge can figure that out, without any extra DT props. > Maybe I can push my configuration changes in gist if required? Please summarize the v3 discussion, yes. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel