Re: [PATCH] drm/v3d: Fix calling drm_sched_resubmit_jobs for same sched.

["Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Am 12.03.19 um 17:57 schrieb Andrey Grodzovsky:
> Also stop calling drm_sched_increase_karma multiple times.
>
> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/v3d/v3d_sched.c | 13 +++++--------
>   1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/gpu/drm/v3d/v3d_sched.c
> index 4704b2d..ce7c737b 100644
> --- a/drivers/gpu/drm/v3d/v3d_sched.c
> +++ b/drivers/gpu/drm/v3d/v3d_sched.c
> @@ -231,20 +231,17 @@ v3d_gpu_reset_for_timeout(struct v3d_dev *v3d, struct drm_sched_job *sched_job)
>   	mutex_lock(&v3d->reset_lock);
>   
>   	/* block scheduler */
> -	for (q = 0; q < V3D_MAX_QUEUES; q++) {
> -		struct drm_gpu_scheduler *sched = &v3d->queue[q].sched;
> -
> -		drm_sched_stop(sched);
> +	for (q = 0; q < V3D_MAX_QUEUES; q++)
> +		drm_sched_stop(&v3d->queue[q].sched);
>   
> -		if(sched_job)
> -			drm_sched_increase_karma(sched_job);
> -	}
> +	if(sched_job)
> +		drm_sched_increase_karma(sched_job);
>   
>   	/* get the GPU back into the init state */
>   	v3d_reset(v3d);
>   
>   	for (q = 0; q < V3D_MAX_QUEUES; q++)
> -		drm_sched_resubmit_jobs(sched_job->sched);
> +		drm_sched_resubmit_jobs(&v3d->queue[q].sched);
>   
>   	/* Unblock schedulers and restart their jobs. */
>   	for (q = 0; q < V3D_MAX_QUEUES; q++) {

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx