From: Colin Ian King <colin.king@canonical.com>
To: Alex Deucher <alexdeucher@gmail.com>, Joe Perches <joe@perches.com>
Cc: "David Airlie" <airlied@linux.ie>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amdgpu: fix spelling mistake "Falied" -> "Failed"
Date: Wed, 5 Aug 2020 22:29:55 +0100 [thread overview]
Message-ID: <33a45674-fd15-918f-31bf-d54f9925abb6@canonical.com> (raw)
In-Reply-To: <CADnq5_P9hfv=Zt9+m47sFC0z202x+q-Otifv7a5z4afJamtQ2Q@mail.gmail.com>
On 05/08/2020 22:27, Alex Deucher wrote:
> On Wed, Aug 5, 2020 at 4:53 PM Joe Perches <joe@perches.com> wrote:
>>
>> On Wed, 2020-08-05 at 16:01 -0400, Alex Deucher wrote:
>>> On Wed, Aug 5, 2020 at 7:35 AM Colin King <colin.king@canonical.com> wrote:
>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>
>>>> There is a spelling mistake in a DRM_ERROR message. Fix it.
>>>>
>>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>>
>>> This is already fixed.
>>
>> This fix is not in today's -next.
>>
>> Perhaps whatever tree it's fixed in should be in -next.
>>
>
> Weird. It's in the drm-next tree as:
>
> commit 4afaa61db9cf5250b5734c2531b226e7b3a3d691
> Author: Colin Ian King <colin.king@canonical.com>
> Date: Fri Jul 10 09:37:58 2020 +0100
>
> drm/amdgpu: fix spelling mistake "Falied" -> "Failed"
>
> There is a spelling mistake in a DRM_ERROR error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>
> Alex
>
>>
>> $ git show --oneline -s
>> d15fe4ec0435 (HEAD, tag: next-20200805, origin/master, origin/HEAD) Add linux-next specific files for 20200805
>>
>> $ git grep -i falied drivers
>> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c: DRM_ERROR("Falied to terminate tmr\n");
>>
>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
>> []
>>>> @@ -2010,7 +2010,7 @@ static int psp_suspend(void *handle)
>>>>
>>>> ret = psp_tmr_terminate(psp);
>>>> if (ret) {
>>>> - DRM_ERROR("Falied to terminate tmr\n");
>>>> + DRM_ERROR("Failed to terminate tmr\n");
>>>> return ret;
>>>> }
>>
>>
Somehow I omitted adding this to my tracking list and forgot that I sent
this already. Apologies for patch deja-vu.
Colin
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-05 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 11:35 [PATCH] drm/amdgpu: fix spelling mistake "Falied" -> "Failed" Colin King
2020-08-05 20:01 ` Alex Deucher
2020-08-05 20:53 ` Joe Perches
2020-08-05 21:27 ` Alex Deucher
2020-08-05 21:29 ` Colin Ian King [this message]
2020-08-05 22:19 ` Joe Perches
2020-08-05 23:36 ` Stephen Rothwell
2020-08-06 7:34 ` daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33a45674-fd15-918f-31bf-d54f9925abb6@canonical.com \
--to=colin.king@canonical.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).