From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B778CC47080 for ; Tue, 1 Jun 2021 09:19:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78A8061364 for ; Tue, 1 Jun 2021 09:19:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78A8061364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 016CF6E9B6; Tue, 1 Jun 2021 09:19:40 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id E01986E9B6; Tue, 1 Jun 2021 09:19:38 +0000 (UTC) IronPort-SDR: 1JlgIme3vGmugqI0Zy1sboc4myRkWK4OvChLDK5XrzsD+HSXsx0jNsCW3QsdthNPaBAqIuXmaa YqY6YO1KSOQg== X-IronPort-AV: E=McAfee;i="6200,9189,10001"; a="190624204" X-IronPort-AV: E=Sophos;i="5.83,239,1616482800"; d="scan'208";a="190624204" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2021 02:19:38 -0700 IronPort-SDR: MRP60Cx5rkw+QlFqxPO0H1pl4Tem49o9plz2f7xwE89uZnAVqM6z75vcxNK2th9PFkTCotEPUt eYMXQu2yM9Zw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,239,1616482800"; d="scan'208";a="416412930" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 01 Jun 2021 02:19:37 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 02:19:37 -0700 Received: from irsmsx604.ger.corp.intel.com (163.33.146.137) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 1 Jun 2021 02:19:36 -0700 Received: from irsmsx604.ger.corp.intel.com ([163.33.146.137]) by IRSMSX604.ger.corp.intel.com ([163.33.146.137]) with mapi id 15.01.2242.008; Tue, 1 Jun 2021 10:19:35 +0100 From: "Ursulin, Tvrtko" To: Zhihao Cheng , "jani.nikula@linux.intel.com" , "joonas.lahtinen@linux.intel.com" , "Vivi, Rodrigo" , "airlied@linux.ie" , "daniel@ffwll.ch" , "chris@chris-wilson.co.uk" Subject: RE: [PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest() Thread-Topic: [PATCH] drm/i915/selftests: Fix return value check in live_breadcrumbs_smoketest() Thread-Index: AQHXVEJ+tkVXHh6hkECEwuczk5ho4qr+5blA Date: Tue, 1 Jun 2021 09:19:35 +0000 Message-ID: <33c46ef24cd547d0ad21dc106441491a@intel.com> References: <20210529043327.2772051-1-chengzhihao1@huawei.com> In-Reply-To: <20210529043327.2772051-1-chengzhihao1@huawei.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.184.70.1] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "yukuai3@huawei.com" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" [Don't see this on intel-gfx so I have to reply with top post.] Reviewed-by: Tvrtko Ursulin Regards, Tvrtko -----Original Message----- From: Zhihao Cheng =20 Sent: Saturday, May 29, 2021 5:33 AM To: jani.nikula@linux.intel.com; joonas.lahtinen@linux.intel.com; Vivi, Rod= rigo ; airlied@linux.ie; daniel@ffwll.ch; chris@chr= is-wilson.co.uk; Ursulin, Tvrtko Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux= -kernel@vger.kernel.org; chengzhihao1@huawei.com; yukuai3@huawei.com Subject: [PATCH] drm/i915/selftests: Fix return value check in live_breadcr= umbs_smoketest() In case of error, the function live_context() returns ERR_PTR() and never r= eturns NULL. The NULL test in the return value check should be replaced wit= h IS_ERR(). Fixes: 52c0fdb25c7c9 ("drm/i915: Replace global breadcrumbs ...") Reported-by: Hulk Robot Signed-off-by: Zhihao Cheng --- drivers/gpu/drm/i915/selftests/i915_request.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/dr= m/i915/selftests/i915_request.c index ee8e753d98ce..eae0abd614cb 100644 --- a/drivers/gpu/drm/i915/selftests/i915_request.c +++ b/drivers/gpu/drm/i915/selftests/i915_request.c @@ -1592,8 +1592,8 @@ static int live_breadcrumbs_smoketest(void *arg) =20 for (n =3D 0; n < smoke[0].ncontexts; n++) { smoke[0].contexts[n] =3D live_context(i915, file); - if (!smoke[0].contexts[n]) { - ret =3D -ENOMEM; + if (IS_ERR(smoke[0].contexts[n])) { + ret =3D PTR_ERR(smoke[0].contexts[n]); goto out_contexts; } } -- 2.25.4