From: Neil Armstrong <narmstrong@baylibre.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
devicetree <devicetree@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
fshao@chromium.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Steven Price <steven.price@arm.com>,
Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
hsinyi@chromium.org, hoegsberg@chromium.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v13 0/4] drm/panfrost: Add support for mt8183 GPU
Date: Fri, 14 May 2021 16:48:52 +0200 [thread overview]
Message-ID: <373d0803-8658-9413-2f51-1e9804c39126@baylibre.com> (raw)
In-Reply-To: <CAAEAJfD3i+L4w1NuE5pUkMuH=R3CfBztDn-ZLcYR=onkcZ4Gxg@mail.gmail.com>
On 13/05/2021 16:55, Ezequiel Garcia wrote:
> Hi Neil,
>
> On Mon, 26 Apr 2021 at 06:59, Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Hi,
>>
>> On 21/04/2021 07:28, Nicolas Boichat wrote:
>>> Hi!
>>>
>>> This is just a rebase of the v11, untested (but it seems like
>>> Neil Armstrong recently tested it), with small changes in
>>> binding and dts. v11 cover follows:
>>>
>>> Follow-up on the v5 [1], things have gotten significantly
>>> better in the last year, thanks to the efforts on Bifrost
>>> support by the Collabora team (and probably others I'm not
>>> aware of).
>>>
>>> I've been testing this series on a MT8183/kukui device, with a
>>> chromeos-5.10 kernel [2], and got basic Chromium OS UI up with
>>> mesa 20.3.2 (lots of artifacts though).
>>>
>>> devfreq is currently not supported, as we'll need:
>>> - Clock core support for switching the GPU core clock (see 2/4).
>>> - Platform-specific handling of the 2-regulator (see 3/4).
>>>
>>> Since the latter is easy to detect, patch 3/4 just disables
>>> devfreq if the more than one regulator is specified in the
>>> compatible matching table.
>>>
>>> [1] https://patchwork.kernel.org/project/linux-mediatek/cover/20200306041345.259332-1-drinkcat@chromium.org/
>>> [2] https://crrev.com/c/2608070
>>>
>>> Changes in v13:
>>> - devfreq: Fix conflict resolution mistake when rebasing, didn't
>>> even compile. Oops.
>>>
>>> Changes in v12:
>>> - binding: Fix min/maxItems logic (Rob Herring)
>>> - Add gpu node to mt8183-pumpkin.dts as well (Neil Armstrong).
>>>
>>> Changes in v11:
>>> - binding: power-domain-names not power-domainS-names
>>> - mt8183*.dts: remove incorrect supply-names
>>>
>>> Changes in v10:
>>> - Fix the binding to make sure sram-supply property can be provided.
>>>
>>> Changes in v9:
>>> - Explain why devfreq needs to be disabled for GPUs with >1
>>> regulators.
>>>
>>> Changes in v8:
>>> - Use DRM_DEV_INFO instead of ERROR
>>>
>>> Changes in v7:
>>> - Fix GPU ID in commit message
>>> - Fix GPU ID in commit message
>>>
>>> Changes in v6:
>>> - Rebased, actually tested with recent mesa driver.
>>> - Add gpu regulators to kukui dtsi as well.
>>> - Power domains are now attached to spm, not scpsys
>>> - Drop R-B.
>>> - devfreq: New change
>>> - Context conflicts, reflow the code.
>>> - Use ARRAY_SIZE for power domains too.
>>>
>>> Changes in v5:
>>> - Rename "2d" power domain to "core2"
>>> - Rename "2d" power domain to "core2" (keep R-B again).
>>> - Change power domain name from 2d to core2.
>>>
>>> Changes in v4:
>>> - Add power-domain-names description
>>> (kept Alyssa's reviewed-by as the change is minor)
>>> - Add power-domain-names to describe the 3 domains.
>>> (kept Alyssa's reviewed-by as the change is minor)
>>> - Add power domain names.
>>>
>>> Changes in v3:
>>> - Match mt8183-mali instead of bifrost, as we require special
>>> handling for the 2 regulators and 3 power domains.
>>>
>>> Changes in v2:
>>> - Use sram instead of mali_sram as SRAM supply name.
>>> - Rename mali@ to gpu@.
>>>
>>> Nicolas Boichat (4):
>>> dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183
>>> arm64: dts: mt8183: Add node for the Mali GPU
>>> drm/panfrost: devfreq: Disable devfreq when num_supplies > 1
>>> drm/panfrost: Add mt8183-mali compatible string
>>>
>>> .../bindings/gpu/arm,mali-bifrost.yaml | 30 ++++-
>>> arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 5 +
>>> .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 5 +
>>> .../boot/dts/mediatek/mt8183-pumpkin.dts | 5 +
>>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 105 ++++++++++++++++++
>>> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 ++
>>> drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++
>>> 7 files changed, 168 insertions(+), 1 deletion(-)
>>>
>>
>> Seems this version is ready to be applied if we get a review on the DT ?
>>
>> Mathias ? could you have a look ?
>>
>
> Given Rob has Acked the DT bindings, I think it's OK to apply patches
> 1, 3 and 4 via drm-misc, letting Mediatek people sort out the DT changes.
>
> My two unsolicited cents :-)
Yeah sure, is there a panfrost maintainer in the room ? I can apply them if you ack me.
Neil
>
> Ezequiel
>
next prev parent reply other threads:[~2021-05-14 14:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 5:28 [PATCH v13 0/4] drm/panfrost: Add support for mt8183 GPU Nicolas Boichat
2021-04-21 5:28 ` [PATCH v13 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 Nicolas Boichat
2021-04-21 16:59 ` Rob Herring
2021-04-21 5:28 ` [PATCH v13 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1 Nicolas Boichat
2021-04-21 5:28 ` [PATCH v13 4/4] drm/panfrost: Add mt8183-mali compatible string Nicolas Boichat
2021-04-21 13:17 ` Alyssa Rosenzweig
2021-04-26 9:58 ` [PATCH v13 0/4] drm/panfrost: Add support for mt8183 GPU Neil Armstrong
2021-05-13 14:55 ` Ezequiel Garcia
2021-05-14 14:48 ` Neil Armstrong [this message]
2021-05-14 15:27 ` Steven Price
2021-05-15 1:29 ` Nicolas Boichat
2021-05-17 10:24 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=373d0803-8658-9413-2f51-1e9804c39126@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=fshao@chromium.org \
--cc=hoegsberg@chromium.org \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).