From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Arunpravin Paneer Selvam <arunpravin.paneerselvam@amd.com>,
Matthew Auld <matthew.auld@intel.com>,
intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Cc: alexander.deucher@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH v3] drm: add a check to verify the size alignment
Date: Mon, 11 Apr 2022 15:44:21 +0200 [thread overview]
Message-ID: <3796cd46-15f6-8991-0a29-7b7f1c7eeae1@gmail.com> (raw)
In-Reply-To: <8e58d05a-61f0-1e6b-cab5-fcadb661c7e5@amd.com>
Am 11.04.22 um 15:49 schrieb Arunpravin Paneer Selvam:
>
> On 11/04/22 7:02 pm, Matthew Auld wrote:
>> On 11/04/2022 13:42, Christian König wrote:
>>> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>>>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>>>> Add a simple check to reject any size not aligned to the
>>>>> min_page_size.
>>>>>
>>>>> when size is not aligned to min_page_size, driver module
>>>>> should handle in their own way either to round_up() the
>>>>> size value to min_page_size or just to enable WARN_ON().
>>>>>
>>>>> If we dont handle the alignment properly, we may hit the
>>>>> following bug, Unigine Heaven has allocation requests for
>>>>> example required pages are 257 and alignment request is 256.
>>>>> To allocate the left over 1 page, continues the iteration to
>>>>> find the order value which is 0 and when it compares with
>>>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>>>
>>>>> v2: add more commit description
>>>>> v3: remove WARN_ON()
>>>>>
>>>>> Signed-off-by: Arunpravin Paneer Selvam
>>>>> <Arunpravin.PaneerSelvam@amd.com>
>>>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>>>
>>> Question here is who will be pushing that to drm-misc-next? Should I
>>> take care of that?
>> Yes, please do.
>>
>>> I think it's time that Arun should request push permission for
>>> drm-misc-next.
> How to get push permission for drm-misc-next, should I send request mail
> to maintainers, may be next time I will push myself.
See here
https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html
Regards,
Christian.
>
> Thanks,
> Arun
>>> Thanks,
>>> Christian.
prev parent reply other threads:[~2022-04-11 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 7:38 [PATCH v3] drm: add a check to verify the size alignment Arunpravin Paneer Selvam
2022-04-11 9:47 ` Matthew Auld
2022-04-11 12:42 ` Christian König
2022-04-11 13:32 ` Matthew Auld
2022-04-11 13:49 ` Arunpravin Paneer Selvam
2022-04-11 13:44 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3796cd46-15f6-8991-0a29-7b7f1c7eeae1@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arunpravin.paneerselvam@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).