From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>
Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
dri-devel@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>,
Abel Vesa <abel.vesa@linaro.org>
Subject: Re: [PATCH v2 1/2] drm/msm/dp: don't touch DP subconnector property in eDP case
Date: Fri, 27 Oct 2023 14:02:03 -0700 [thread overview]
Message-ID: <37b52c67-7abb-d607-dc46-1cde33606997@quicinc.com> (raw)
In-Reply-To: <20231025092711.851168-2-dmitry.baryshkov@linaro.org>
On 10/25/2023 2:23 AM, Dmitry Baryshkov wrote:
> From: Abel Vesa <abel.vesa@linaro.org>
>
> In case of the eDP connection there is no subconnetor and as such no
> subconnector property. Put drm_dp_set_subconnector_property() calls
> under the !is_edp condition.
>
> Fixes: bfcc3d8f94f4 ("drm/msm/dp: support setting the DP subconnector type")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
We still need to unify the calls to drm_dp_set_subconnector_property()
for the hpd connect/disconnect places preferably in
dp_display_send_hpd_notification().
That way, we would have had to make this change only in one location.
If you want to pursue that as a separate patch, I am fine as well.
Hence,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
next prev parent reply other threads:[~2023-10-27 21:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 9:23 [PATCH v2 0/2] drm/msm/dp: fix DP subconnector handling Dmitry Baryshkov
2023-10-25 9:23 ` [PATCH v2 1/2] drm/msm/dp: don't touch DP subconnector property in eDP case Dmitry Baryshkov
2023-10-27 21:02 ` Abhinav Kumar [this message]
2023-10-28 0:37 ` Dmitry Baryshkov
2023-11-01 16:19 ` Jessica Zhang
2023-11-15 8:08 ` Johan Hovold
2023-10-25 9:23 ` [PATCH v2 2/2] drm/msm/dp: attach the DP subconnector property Dmitry Baryshkov
2023-11-01 16:19 ` Jessica Zhang
2023-11-15 8:06 ` Johan Hovold
2023-11-15 18:06 ` Abhinav Kumar
2023-11-21 17:57 ` Linux regression tracking (Thorsten Leemhuis)
2023-11-21 18:50 ` Abhinav Kumar
2023-11-21 20:10 ` Linux regression tracking (Thorsten Leemhuis)
2023-11-18 14:10 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-11-21 18:44 ` [PATCH v2 0/2] drm/msm/dp: fix DP subconnector handling Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37b52c67-7abb-d607-dc46-1cde33606997@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).