From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A6AC433ED for ; Mon, 26 Apr 2021 18:01:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FB7860240 for ; Mon, 26 Apr 2021 18:01:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FB7860240 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 001DA6E187; Mon, 26 Apr 2021 18:01:25 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E17C6E187 for ; Mon, 26 Apr 2021 18:01:25 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AC425ADDB; Mon, 26 Apr 2021 18:01:23 +0000 (UTC) Subject: Re: [PATCH] drm/ast: Fix missing conversions to managed API To: Takashi Iwai , Dave Airlie References: <20210421170458.21178-1-tiwai@suse.de> From: Thomas Zimmermann Message-ID: <3d6d6217-9c51-6722-5ac9-14134cb198b0@suse.de> Date: Mon, 26 Apr 2021 20:01:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210421170458.21178-1-tiwai@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org Content-Type: multipart/mixed; boundary="===============0975329498==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0975329498== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nGeKBsfsR5ofbVgj9MYjajeuZCL5CpB9X" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nGeKBsfsR5ofbVgj9MYjajeuZCL5CpB9X Content-Type: multipart/mixed; boundary="gMhYV8RMTRUdtOV0oLX3FvCSeo2nOQAB8"; protected-headers="v1" From: Thomas Zimmermann To: Takashi Iwai , Dave Airlie Cc: Daniel Vetter , dri-devel@lists.freedesktop.org Message-ID: <3d6d6217-9c51-6722-5ac9-14134cb198b0@suse.de> Subject: Re: [PATCH] drm/ast: Fix missing conversions to managed API References: <20210421170458.21178-1-tiwai@suse.de> In-Reply-To: <20210421170458.21178-1-tiwai@suse.de> --gMhYV8RMTRUdtOV0oLX3FvCSeo2nOQAB8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 21.04.21 um 19:04 schrieb Takashi Iwai: > The commit 7cbb93d89838 ("drm/ast: Use managed pci functions") > converted a few PCI accessors to the managed API and dropped the > manual pci_iounmap() calls, but it seems to have forgotten converting > pci_iomap() to the managed one. It resulted in the leftover resources > after the driver unbind. Let's fix them. >=20 > Fixes: 7cbb93d89838 ("drm/ast: Use managed pci functions") > Signed-off-by: Takashi Iwai Added to drm-misc-next. Thanks, Takashi. > --- > drivers/gpu/drm/ast/ast_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_m= ain.c > index 0ac3c2039c4b..c29cc7f19863 100644 > --- a/drivers/gpu/drm/ast/ast_main.c > +++ b/drivers/gpu/drm/ast/ast_main.c > @@ -413,7 +413,7 @@ struct ast_private *ast_device_create(const struct = drm_driver *drv, > =20 > pci_set_drvdata(pdev, dev); > =20 > - ast->regs =3D pci_iomap(pdev, 1, 0); > + ast->regs =3D pcim_iomap(pdev, 1, 0); > if (!ast->regs) > return ERR_PTR(-EIO); > =20 > @@ -429,7 +429,7 @@ struct ast_private *ast_device_create(const struct = drm_driver *drv, > =20 > /* "map" IO regs if the above hasn't done so already */ > if (!ast->ioregs) { > - ast->ioregs =3D pci_iomap(pdev, 2, 0); > + ast->ioregs =3D pcim_iomap(pdev, 2, 0); > if (!ast->ioregs) > return ERR_PTR(-EIO); > } >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --gMhYV8RMTRUdtOV0oLX3FvCSeo2nOQAB8-- --nGeKBsfsR5ofbVgj9MYjajeuZCL5CpB9X Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmCG//IFAwAAAAAACgkQlh/E3EQov+Bw 7RAAhEkiyDrwC7vnNg/Dhv0iJruQLh5t6m2/IgPXqVAXFVm7fR3YWqGsQNH4TfG2I1S5XheoYybf QzykPQ0LVEmRIQhnasUiBzz/XM+hSdmRKIob42qrHUYscjHnr076WSB+LUmoEpPfQ9yJdGP0lzko h6fLJgjqkxC30WdMJiJvw8IOtjm5DaX0tvra2GtFFeN9p9eO/OvkA7rLwAjsvkHrX+GtJkdHnM3I TKvosuhVPQdKmfj+hhu92Fgxzlkp705Aez6gGe1mCff3gsjAsWrOKG5mZTwUjxJ5l9Arfvc/8JjQ A+R2JXOCDjin83IAZ0Jb3e0tEBftnOiXTk16ElKbBbopR3VIU27Th//P+Ra/DZKeXN5S01dRVOca FormY6N99ax3Pe+zFbcwiq3/FLKk9AEYvZkeDkO53C2/NP0UDQ/e4duxCLmf0Y5oCYgCWx9dJUkl 3mDJFR2aPUGhGX5p6lk2w8xlDjK2v6AugkutKG0m2U8M1HUA0EA92IZc7UTPIlk60Co2us7chqbB k9SED4jzG/MVEDEYoUb2WFapvoI3mTcLd51gW65AJhD6Lby/8dpDx5etm03bJTBJnQZr7pnWX3l5 mz0JFuIWxjtcEPayPgdujjJkz8H7uH5MCsl0Pgum4qnopbF7/5RlP+vA2d6a6V9zcMuaJz+zHcoA +7U= =GR7e -----END PGP SIGNATURE----- --nGeKBsfsR5ofbVgj9MYjajeuZCL5CpB9X-- --===============0975329498== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0975329498==--