From: Marek Vasut <marex@denx.de>
To: Lucas Stach <l.stach@pengutronix.de>, dri-devel@lists.freedesktop.org
Cc: Peng Fan <peng.fan@nxp.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sam Ravnborg <sam@ravnborg.org>, Robby Cai <robby.cai@nxp.com>
Subject: Re: [PATCH v2 2/7] drm: mxsfb: Simplify LCDIF IRQ handling
Date: Thu, 7 Apr 2022 00:03:41 +0200 [thread overview]
Message-ID: <3f46927b-b458-81bf-0b9b-03171e9bbcb5@denx.de> (raw)
In-Reply-To: <ffc23134df69d9fe6ba7229e6a3239ebd131e68e.camel@pengutronix.de>
On 4/6/22 21:41, Lucas Stach wrote:
> Am Freitag, dem 11.03.2022 um 18:05 +0100 schrieb Marek Vasut:
>> The call to drm_crtc_vblank_off(&lcdif->crtc); disables IRQ generation
>> from the LCDIF block already and this is called in mxsfb_load() before
>> request_irq(), so explicitly disabling IRQ using custom function like
>> mxsfb_irq_disable() is not needed, remove it.
>>
>
> Have you checked that the drm_vblank_off in probe actually results in a
> call to mxsfb_crtc_disable_vblank? From my reading of the core code,
> this should be a no-op without a previous drm_vblank_on, so it would
> not result in the desired masking before the IRQ is requested.
I must've missed the vblank->enabled check, but then, I am also not
getting any interrupts, so presumably they are already disabled after
the IP is reset.
next prev parent reply other threads:[~2022-04-07 0:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 17:05 [PATCH v2 1/7] drm: mxsfb: Simplify LCDIF clock handling Marek Vasut
2022-03-11 17:05 ` [PATCH v2 2/7] drm: mxsfb: Simplify LCDIF IRQ handling Marek Vasut
2022-04-06 19:41 ` Lucas Stach
2022-04-06 22:03 ` Marek Vasut [this message]
2022-04-07 8:01 ` Lucas Stach
2022-04-17 1:04 ` Marek Vasut
2022-03-11 17:05 ` [PATCH v2 3/7] drm: mxsfb: Wrap FIFO reset and comments into mxsfb_reset_block() Marek Vasut
2022-04-06 19:42 ` Lucas Stach
2022-03-11 17:05 ` [PATCH v2 4/7] drm: mxsfb: Move mxsfb_get_fb_paddr() away from register IO functions Marek Vasut
2022-04-06 19:45 ` Lucas Stach
2022-04-06 22:05 ` Marek Vasut
2022-04-07 9:47 ` Lucas Stach
2022-04-10 22:17 ` Marek Vasut
2022-04-11 9:46 ` Lucas Stach
2022-03-11 17:05 ` [PATCH v2 5/7] drm: mxsfb: Factor out mxsfb_set_mode() Marek Vasut
2022-04-06 19:47 ` Lucas Stach
2022-04-06 22:06 ` Marek Vasut
2022-03-11 17:06 ` [PATCH v2 6/7] drm: mxsfb: Reorder mxsfb_crtc_mode_set_nofb() Marek Vasut
2022-04-06 19:48 ` Lucas Stach
2022-03-11 17:06 ` [PATCH v2 7/7] drm: mxsfb: Factor out mxsfb_update_buffer() Marek Vasut
2022-04-06 19:49 ` Lucas Stach
2022-04-06 19:32 ` [PATCH v2 1/7] drm: mxsfb: Simplify LCDIF clock handling Lucas Stach
2022-04-06 21:45 ` Marek Vasut
2022-04-07 7:57 ` Lucas Stach
2022-04-17 1:05 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f46927b-b458-81bf-0b9b-03171e9bbcb5@denx.de \
--to=marex@denx.de \
--cc=alexander.stein@ew.tq-group.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=peng.fan@nxp.com \
--cc=robby.cai@nxp.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).