From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FE3FC07E9D for ; Sat, 24 Sep 2022 17:57:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D39D10E053; Sat, 24 Sep 2022 17:56:58 +0000 (UTC) Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 22E5210E023; Sat, 24 Sep 2022 17:56:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds202112; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zmHY+xZMFdIi+qFBqcZtOuqWpwVumeVc9smQXH4vMoA=; b=qYJIEY9O1AyslYhi2ghjRAL/Co kJMnTdPIB1cB09Lw7lSUL3Jtsm21xK1W3JnYErZ52rVCcPOSQeD9SuPigKUZz+yMKdNSz3f/isEvf nojB3Ni2xktXXNhbb2yrQU380/nnm9K0ch8sB3GqZR8p3pSejBqK2BEoW5LGSZd5GN3BPzh85Hifz StAnJOylz3P4zPy5s/bUp7IYzj4kQ+1H3PGRRR8xc/0dZ8XjkEZbTLGr5d0/6cSyrifAdDDbl/tAX 2aTVP0ZOjX5+O2/voNluZPgdk9QwqPjZUvn9Wd7jNLSRKOHjJQ5ode/ujnJSoRamREPf5M3stoPra ETK4Dq/g==; Received: from [2a01:799:961:d200:8cf6:761:40ec:1ff7] (port=61045) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oc9OQ-0007Ja-3Z; Sat, 24 Sep 2022 19:56:46 +0200 Message-ID: <3f7000ab-b845-a7e8-f215-02121da779b7@tronnes.org> Date: Sat, 24 Sep 2022 19:56:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v2 02/33] drm/tests: Add Kunit Helpers To: Maxime Ripard , Jernej Skrabec , Rodrigo Vivi , Ben Skeggs , David Airlie , Maxime Ripard , Joonas Lahtinen , Emma Anholt , Karol Herbst , Samuel Holland , Jani Nikula , Thomas Zimmermann , Daniel Vetter , Lyude Paul , Maarten Lankhorst , Tvrtko Ursulin , Chen-Yu Tsai References: <20220728-rpi-analog-tv-properties-v2-0-f733a0ed9f90@cerno.tech> <20220728-rpi-analog-tv-properties-v2-2-f733a0ed9f90@cerno.tech> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= In-Reply-To: <20220728-rpi-analog-tv-properties-v2-2-f733a0ed9f90@cerno.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , Dave Stevenson , nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Hans de Goede , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Geert Uytterhoeven , Mateusz Kwiatkowski , Phil Elwell , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Den 22.09.2022 16.25, skrev Maxime Ripard: > As the number of kunit tests in KMS grows further, we start to have > multiple test suites that, for example, need to register a mock DRM > driver to interact with the KMS function they are supposed to test. > > Let's add a file meant to provide those kind of helpers to avoid > duplication. > > Signed-off-by: Maxime Ripard > > diff --git a/drivers/gpu/drm/tests/Makefile b/drivers/gpu/drm/tests/Makefile > index 2d9f49b62ecb..b29ef1085cad 100644 > --- a/drivers/gpu/drm/tests/Makefile > +++ b/drivers/gpu/drm/tests/Makefile > @@ -8,6 +8,7 @@ obj-$(CONFIG_DRM_KUNIT_TEST) += \ > drm_format_helper_test.o \ > drm_format_test.o \ > drm_framebuffer_test.o \ > + drm_kunit_helpers.o \ > drm_mm_test.o \ > drm_plane_helper_test.o \ > drm_rect_test.o > diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c > new file mode 100644 > index 000000000000..7ebd620481c1 > --- /dev/null > +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c > @@ -0,0 +1,54 @@ > +#include > +#include > + > +#include > + > +static const struct drm_mode_config_funcs drm_mode_config_funcs = { > +}; > + > +static const struct drm_driver drm_mode_driver = { > +}; > + > +static void drm_kunit_free_device(struct drm_device *drm, void *ptr) > +{ > + struct device *dev = ptr; > + > + root_device_unregister(dev); > +} > + > +struct drm_device *drm_kunit_device_init(const char *name) > +{ > + struct drm_device *drm; > + struct device *dev; > + int ret; > + > + dev = root_device_register(name); > + if (IS_ERR(dev)) > + return ERR_CAST(dev); > + > + drm = drm_dev_alloc(&drm_mode_driver, dev); I can't find drm being freed anywhere? Maybe you could assign it to drm->managed.final_kfree. Noralf. > + if (IS_ERR(drm)) { > + root_device_unregister(dev); > + return ERR_CAST(drm); > + } > + drm->mode_config.funcs = &drm_mode_config_funcs; > + > + ret = drmm_add_action_or_reset(drm, drm_kunit_free_device, dev); > + if (ret) > + goto err_put_device; > + > + ret = drmm_mode_config_init(drm); > + if (ret) > + return ERR_PTR(ret); > + > + return drm; > + > +err_put_device: > + drm_dev_put(drm); > + return ERR_PTR(ret); > +} > + > +void drm_kunit_device_exit(struct drm_device *drm) > +{ > + drm_dev_put(drm); > +} > diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.h b/drivers/gpu/drm/tests/drm_kunit_helpers.h > new file mode 100644 > index 000000000000..5015a327a8c1 > --- /dev/null > +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.h > @@ -0,0 +1,9 @@ > +#ifndef DRM_KUNIT_HELPERS_H_ > +#define DRM_KUNIT_HELPERS_H_ > + > +struct drm_device; > + > +struct drm_device *drm_kunit_device_init(const char *name); > +void drm_kunit_device_exit(struct drm_device *drm); > + > +#endif // DRM_KUNIT_HELPERS_H_ >