From: Sameer Pujar <spujar@nvidia.com>
To: Rob Herring <robh@kernel.org>, <devicetree@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: Convert graph bindings to json-schema
Date: Wed, 11 Nov 2020 15:21:53 +0530 [thread overview]
Message-ID: <4185c162-8a71-7402-f46e-4a2495f152f2@nvidia.com> (raw)
In-Reply-To: <20201102203656.220187-2-robh@kernel.org>
Hi Rob,
> From: Sameer Pujar <spujar@nvidia.com>
>
> Convert device tree bindings of graph to YAML format. Currently graph.txt
> doc is referenced in multiple files and all of these need to use schema
> references. For now graph.txt is updated to refer to graph.yaml.
>
> For users of the graph binding, they should reference to the graph
> schema from either 'ports' or 'port' property:
>
> properties:
> ports:
> type: object
> $ref: graph.yaml#/properties/ports
>
> properties:
> port@0:
> description: What data this port has
>
> ...
>
> Or:
>
> properties:
> port:
> description: What data this port has
> type: object
> $ref: graph.yaml#/properties/port
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v3:
> - Move port 'reg' to port@* and make required
> - Make remote-endpoint required
> - Add 'additionalProperties: true' now required
> - Fix yamllint warnings
>
> Documentation/devicetree/bindings/graph.txt | 129 +-----------
> Documentation/devicetree/bindings/graph.yaml | 199 +++++++++++++++++++
> 2 files changed, 200 insertions(+), 128 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/graph.yaml
>
...
> diff --git a/Documentation/devicetree/bindings/graph.yaml b/Documentation/devicetree/bindings/graph.yaml
> new file mode 100644
> index 000000000000..b56720c5a13e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/graph.yaml
> @@ -0,0 +1,199 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/graph.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Common bindings for device graphs
> +
> +description: |
> + The hierarchical organisation of the device tree is well suited to describe
> + control flow to devices, but there can be more complex connections between
> + devices that work together to form a logical compound device, following an
> + arbitrarily complex graph.
> + There already is a simple directed graph between devices tree nodes using
> + phandle properties pointing to other nodes to describe connections that
> + can not be inferred from device tree parent-child relationships. The device
> + tree graph bindings described herein abstract more complex devices that can
> + have multiple specifiable ports, each of which can be linked to one or more
> + ports of other devices.
> +
> + These common bindings do not contain any information about the direction or
> + type of the connections, they just map their existence. Specific properties
> + may be described by specialized bindings depending on the type of connection.
> +
> + To see how this binding applies to video pipelines, for example, see
> + Documentation/devicetree/bindings/media/video-interfaces.txt.
> + Here the ports describe data interfaces, and the links between them are
> + the connecting data buses. A single port with multiple connections can
> + correspond to multiple devices being connected to the same physical bus.
> +
> +maintainers:
> + - Philipp Zabel <p.zabel@pengutronix.de>
> +
> +select: false
> +
> +properties:
> + port:
> + type: object
> + description:
> + If there is more than one endpoint node or 'reg' property present in
> + endpoint nodes then '#address-cells' and '#size-cells' properties are
> + required.
> +
> + properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + patternProperties:
> + "^endpoint(@[0-9a-f]+)?$":
> + type: object
> + properties:
> + reg:
> + maxItems: 1
> +
> + remote-endpoint:
> + description: |
> + phandle to an 'endpoint' subnode of a remote device node.
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> + required:
> + - remote-endpoint
Does 'remote-endpoint' have to be a required property?
In case of pluggable modules, the remote-endpoint may not be available
unless the module is plugged in. In other words, device-2 in below
example may not always be available, but still device-1 endpoint
configuration and usage may be required?
...
> + # Links between endpoints:
> + #
> + # Each endpoint should contain a 'remote-endpoint' phandle property that
> + # points to the corresponding endpoint in the port of the remote device.
> + # In turn, the remote endpoint should contain a 'remote-endpoint' property.
> + # If it has one, it must not point to anything other than the local endpoint.
> + # Two endpoints with their 'remote-endpoint' phandles pointing at each other
> + # form a link between the containing ports.
> + - |
> + device-1 {
> + port {
> + device_1_output: endpoint {
> + remote-endpoint = <&device_2_input>;
> + };
> + };
> + };
> +
> + device-2 {
> + port {
> + device_2_input: endpoint {
> + remote-endpoint = <&device_1_output>;
> + };
> + };
> + };
> +
> +...
> --
> 2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-12 8:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 20:36 [PATCH v3 0/3] dt-bindings: Convert graph bindings to json-schema Rob Herring
2020-11-02 20:36 ` [PATCH v3 1/3] " Rob Herring
2020-11-05 21:43 ` Sam Ravnborg
2020-11-11 9:51 ` Sameer Pujar [this message]
2020-11-11 13:35 ` Rob Herring
2020-11-11 14:00 ` Laurent Pinchart
2020-11-11 14:25 ` Rob Herring
2020-11-11 14:27 ` Laurent Pinchart
2020-11-11 23:03 ` Rob Herring
2020-11-12 7:56 ` Laurent Pinchart
2020-11-12 20:49 ` Rob Herring
2020-11-02 20:36 ` [PATCH v3 2/3] dt-bindings: usb-connector: Add reference to graph schema Rob Herring
2020-11-11 14:01 ` Laurent Pinchart
2020-11-02 20:36 ` [PATCH v3 3/3] dt-bindings: panel: common: " Rob Herring
2020-11-05 21:46 ` Sam Ravnborg
2020-11-11 14:02 ` Laurent Pinchart
2020-11-03 6:05 ` [PATCH v3 0/3] dt-bindings: Convert graph bindings to json-schema Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4185c162-8a71-7402-f46e-4a2495f152f2@nvidia.com \
--to=spujar@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacopo+renesas@jmondi.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).