From: Stefan Agner <stefan@agner.ch>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Marek Vasut <marex@denx.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Airlie <airlied@linux.ie>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
NXP Linux Team <linux-imx@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/mxsfb: Make supported modifiers explicit
Date: Mon, 20 Jul 2020 11:03:04 +0200 [thread overview]
Message-ID: <427ac44d83e9502afb5a809f28544d6c@agner.ch> (raw)
In-Reply-To: <20200718171407.GA72952@bogon.m.sigxcpu.org>
On 2020-07-18 19:14, Guido Günther wrote:
> Hi,
> On Mon, Mar 23, 2020 at 04:51:05PM +0100, Lucas Stach wrote:
>> Am Montag, den 23.03.2020, 15:52 +0100 schrieb Guido Günther:
>> > In contrast to other display controllers on imx like DCSS and ipuv3
>> > lcdif/mxsfb does not support detiling e.g. vivante tiled layouts.
>> > Since mesa might assume otherwise make it explicit that only
>> > DRM_FORMAT_MOD_LINEAR is supported.
>> >
>> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
>>
>> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
>
> Can i do anything to get this applied?
> Cheers,
> -- Guido
Sorry about the delay, I was thinking to apply it with another patchset
which is not ready though.
Pushed this patch to drm-misc-next just now.
--
Stefan
>
>>
>> > ---
>> > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 +++++++--
>> > 1 file changed, 7 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
>> > index 762379530928..fc71e7a7a02e 100644
>> > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
>> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
>> > @@ -73,6 +73,11 @@ static const uint32_t mxsfb_formats[] = {
>> > DRM_FORMAT_RGB565
>> > };
>> >
>> > +static const uint64_t mxsfb_modifiers[] = {
>> > + DRM_FORMAT_MOD_LINEAR,
>> > + DRM_FORMAT_MOD_INVALID
>> > +};
>> > +
>> > static struct mxsfb_drm_private *
>> > drm_pipe_to_mxsfb_drm_private(struct drm_simple_display_pipe *pipe)
>> > {
>> > @@ -334,8 +339,8 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
>> > }
>> >
>> > ret = drm_simple_display_pipe_init(drm, &mxsfb->pipe, &mxsfb_funcs,
>> > - mxsfb_formats, ARRAY_SIZE(mxsfb_formats), NULL,
>> > - mxsfb->connector);
>> > + mxsfb_formats, ARRAY_SIZE(mxsfb_formats),
>> > + mxsfb_modifiers, mxsfb->connector);
>> > if (ret < 0) {
>> > dev_err(drm->dev, "Cannot setup simple display pipe\n");
>> > goto err_vblank;
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-20 9:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 14:52 [PATCH] drm/mxsfb: Make supported modifiers explicit Guido Günther
2020-03-23 15:51 ` Lucas Stach
2020-07-18 17:14 ` Guido Günther
2020-07-20 7:31 ` Daniel Vetter
2020-07-20 9:03 ` Stefan Agner [this message]
2020-07-20 10:03 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=427ac44d83e9502afb5a809f28544d6c@agner.ch \
--to=stefan@agner.ch \
--cc=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).