From: Marc Zyngier <maz@kernel.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: kernelci-results@groups.io,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Guillaume Tucker <guillaume.tucker@collabora.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
David Airlie <airlied@linux.ie>,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: next/master bisection: baseline.dmesg.emerg on meson-gxbb-p200
Date: Fri, 20 Nov 2020 09:59:02 +0000 [thread overview]
Message-ID: <45c711c9d5fb5ef0e3b80e82b10f5998@kernel.org> (raw)
In-Reply-To: <93dcf61a-be80-8870-48f5-30e215cc56ed@baylibre.com>
On 2020-11-20 09:26, Neil Armstrong wrote:
> On 19/11/2020 19:35, Marc Zyngier wrote:
>>>>> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c
>>>>> b/drivers/gpu/drm/meson/meson_dw_hdmi.c
>>>>> index 7f8eea494147..52af8ba94311 100644
>>>>> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
>>>>> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
>>>>> @@ -146,6 +146,7 @@ struct meson_dw_hdmi {
>>>>> struct reset_control *hdmitx_ctrl;
>>>>> struct reset_control *hdmitx_phy;
>>>>> struct clk *hdmi_pclk;
>>>>> + struct clk *iahb_clk;
>>>>> struct clk *venci_clk;
>>>>> struct regulator *hdmi_supply;
>>>>> u32 irq_stat;
>>>>> @@ -1033,6 +1034,13 @@ static int meson_dw_hdmi_bind(struct device
>>>>> *dev, struct device *master,
>>>>> }
>>>>> clk_prepare_enable(meson_dw_hdmi->hdmi_pclk);
>>>>>
>>>>> + meson_dw_hdmi->iahb_clk = devm_clk_get(dev, "iahb");
>>>>> + if (IS_ERR(meson_dw_hdmi->iahb_clk)) {
>>>>> + dev_err(dev, "Unable to get iahb clk\n");
>>>>> + return PTR_ERR(meson_dw_hdmi->iahb_clk);
>>>>> + }
>>>>> + clk_prepare_enable(meson_dw_hdmi->iahb_clk);
>
>
> On previous SoCs, iahb was directly the bus clock (clk81), and on
> recent socs
> this clock is a gate.
>
> The question is why is it disabled. Maybe a previous failed probe
> disabled it
> in the dw-hdmi probe failure code and this clock is needed for
> meson_dw_hdmi_init(),
> so yeah this is the right fix.
>
> Thanks.
>
> Could you send a revert of b33340e33acdfe5ca6a5aa1244709575ae1e0432
> and then proper fix with clk_disable_unprepare added ?
Bah. I missed that email and sent a slightly different resolution.
Hopefully that'll be good enough.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-11-20 9:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5fb5e094.1c69fb81.a2014.2e62@mx.google.com>
2020-11-19 8:50 ` next/master bisection: baseline.dmesg.emerg on meson-gxbb-p200 Guillaume Tucker
2020-11-19 10:20 ` Marc Zyngier
2020-11-19 10:26 ` Neil Armstrong
2020-11-19 11:33 ` Marc Zyngier
2020-11-19 11:58 ` Marc Zyngier
2020-11-19 18:04 ` Guillaume Tucker
2020-11-19 18:13 ` Jerome Brunet
2020-11-19 18:35 ` Marc Zyngier
2020-11-20 9:26 ` Neil Armstrong
2020-11-20 9:59 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45c711c9d5fb5ef0e3b80e82b10f5998@kernel.org \
--to=maz@kernel.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=guillaume.tucker@collabora.com \
--cc=jbrunet@baylibre.com \
--cc=kernelci-results@groups.io \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).