From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Tony Lindgren <tony@atomide.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
devicetree@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Jyri Sarha <jsarha@ti.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings
Date: Thu, 12 Dec 2019 11:37:51 +0200 [thread overview]
Message-ID: <45dae8f7-2f5e-6948-5a05-dc8a09ace1fa@ti.com> (raw)
In-Reply-To: <20191211165331.GC43123@atomide.com>
On 11/12/2019 18:53, Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [191202 13:05]:
>> Hi Tomi,
>>
>> Thank you for the patch.
>>
>> On Thu, Nov 14, 2019 at 11:39:49AM +0200, Tomi Valkeinen wrote:
>>> panel-simple now handled panel osd070t1718-19ts, and we no longer need
>>> the panel timings in the DT file. So remove them.
>>
>> Should you in that case drop the panel-dpi compatible string too, as the
>> panel-dpi bindings require panel timings in DT ?
>
> Yeah sounds like if panel-dpi is no longer usable for this device it
> should be dropped from the compatible list.
Ok, I agree.
Looking at the dts files, panel-dpi is used in a bunch of boards. But we even have 3 dts files with
panel-dpi, without the detailed panel model in compatible...
Fixing those will break the compatibility with old dtbs and new kernel, unless we add
timings-from-dt to a panel driver that handles panel-dpi.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-12 9:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 9:39 [PATCH 0/3] drm/omap: fix am4 evm lcd Tomi Valkeinen
2019-11-14 9:39 ` Tomi Valkeinen
2019-11-14 9:39 ` [PATCH 1/3] ARM: dts: am437x-gp/epos-evm: fix panel compatible Tomi Valkeinen
2019-11-14 9:39 ` Tomi Valkeinen
2019-12-02 13:01 ` Laurent Pinchart
2019-12-11 16:51 ` Tony Lindgren
2019-11-14 9:39 ` [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings Tomi Valkeinen
2019-11-14 9:39 ` Tomi Valkeinen
2019-12-02 13:04 ` Laurent Pinchart
2019-12-11 16:53 ` Tony Lindgren
2019-12-12 9:37 ` Tomi Valkeinen [this message]
2019-12-12 20:35 ` Laurent Pinchart
2020-01-13 12:01 ` Tomi Valkeinen
2020-02-11 10:01 ` Tomi Valkeinen
2020-02-11 11:07 ` Laurent Pinchart
2020-02-11 11:08 ` Tomi Valkeinen
2020-02-11 11:10 ` Laurent Pinchart
2020-02-14 0:33 ` Sebastian Reichel
2020-02-11 12:54 ` Merlijn Wajer
2020-02-11 16:05 ` Tony Lindgren
2020-02-11 16:13 ` Tomi Valkeinen
2020-02-11 16:27 ` Tony Lindgren
2020-02-11 17:22 ` Tomi Valkeinen
2020-02-13 21:57 ` Sebastian Reichel
2019-11-14 9:39 ` [PATCH 3/3] drm/panel: simple: fix osd070t1718_19ts sync drive edge Tomi Valkeinen
2019-11-14 9:39 ` Tomi Valkeinen
2019-12-02 13:07 ` Laurent Pinchart
2020-01-13 12:04 ` Tomi Valkeinen
2020-02-10 8:15 ` Tomi Valkeinen
2020-02-14 21:39 ` Sam Ravnborg
2020-02-21 10:43 ` Tomi Valkeinen
2020-02-22 12:16 ` Sam Ravnborg
2019-11-27 12:59 ` [PATCH 0/3] drm/omap: fix am4 evm lcd Tomi Valkeinen
2019-11-27 12:59 ` Tomi Valkeinen
2019-11-27 15:45 ` Tony Lindgren
2019-11-28 7:03 ` Tomi Valkeinen
2019-12-02 13:13 ` Laurent Pinchart
2019-12-02 13:24 ` Adam Ford
2019-12-03 21:27 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45dae8f7-2f5e-6948-5a05-dc8a09ace1fa@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=peter.ujfalusi@ti.com \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).