From: <Codrin.Ciubotariu@microchip.com>
To: <michael@walle.cc>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>, <Claudiu.Beznea@microchip.com>,
<sumit.semwal@linaro.org>, <christian.koenig@amd.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-i2c@vger.kernel.org,
stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH] i2c: at91: use dma safe buffers
Date: Tue, 5 Apr 2022 09:23:46 +0000 [thread overview]
Message-ID: <46e1be55-9377-75b7-634d-9eadbebc98d7@microchip.com> (raw)
In-Reply-To: <20220303161724.3324948-1-michael@walle.cc>
On 03.03.2022 18:17, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The supplied buffer might be on the stack and we get the following error
> message:
> [ 3.312058] at91_i2c e0070600.i2c: rejecting DMA map of vmalloc memory
>
> Use i2c_{get,put}_dma_safe_msg_buf() to get a DMA-able memory region if
> necessary.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
>
> I'm not sure if or which Fixes: tag I should add to this patch. The issue
> seems to be since a very long time, but nobody seem to have triggered it.
> FWIW, I'm using the sff,sfp driver, which triggers this.
I think it should be:
Fixes: 60937b2cdbf9 ("i2c: at91: add dma support")
> + if (dev->use_dma) {
> + dma_buf = i2c_get_dma_safe_msg_buf(m_start, 1);
If you want, you could just dev->buf = i2c_get_dma_safe...
> + if (!dma_buf) {
> + ret = -ENOMEM;
> + goto out;
> + }
> + dev->buf = dma_buf;
Thanks!
next prev parent reply other threads:[~2022-04-05 10:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 16:17 [PATCH] i2c: at91: use dma safe buffers Michael Walle
2022-03-04 7:35 ` Christian König
2022-03-04 8:04 ` Wolfram Sang
2022-03-04 8:10 ` Christian König
2022-03-04 8:43 ` Wolfram Sang
2022-03-04 8:54 ` Christian König
2022-03-28 7:35 ` Michael Walle
2022-04-05 9:23 ` Codrin.Ciubotariu [this message]
2022-04-05 9:38 ` Michael Walle
2022-04-05 10:02 ` Codrin.Ciubotariu
2022-04-05 11:09 ` Michael Walle
2022-04-05 13:58 ` Codrin.Ciubotariu
2022-04-05 14:08 ` Michael Walle
2022-04-07 11:50 ` Codrin.Ciubotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46e1be55-9377-75b7-634d-9eadbebc98d7@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=michael@walle.cc \
--cc=stable@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).