From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 415FAC28D13 for ; Mon, 22 Aug 2022 20:36:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 837D495C99; Mon, 22 Aug 2022 20:36:21 +0000 (UTC) Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id EDCDA900BF for ; Mon, 22 Aug 2022 20:36:03 +0000 (UTC) Received: by mail-lj1-x22d.google.com with SMTP id x25so11701622ljm.5 for ; Mon, 22 Aug 2022 13:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Ywx2Ifz/ABKWVJisuMZqTLd+k7zB7LgcLuZnDbx5qWY=; b=EGiF52LnWu0oKDZVfUcQPzArNVGqjt8Ky/kICz3i3KBurZON54IyqEK+719nlVPwQy TeTioDOaXJVDMuE+zCpFU4gcfx8vgLn7Bwz8SLWcGl+ry46R8MYCRMt7MPk+HhZM4fqY C9uEyK2vDvHFo5Bca58j6OjSYlsoqh6H5hGsgVJ+/Sso4Z77MtIPRxpAd9qUsWfv++fC f7U6d7YbI+KEBNJUVIqomwoiJ4jtr40sY8Huxso6vi2fvfdDznAQMJGdwLVnlebkOBC2 BfuO8/pmv4/Kle4GubmX2fcdephn9oy7UxO02RAjF9Us1WBpLXWheLYsXsOp2G0vDxsX b94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Ywx2Ifz/ABKWVJisuMZqTLd+k7zB7LgcLuZnDbx5qWY=; b=zOW944NMzCNSr7Ct+mF+VE1tv8RSrX5d+Iy8mMWYuGmnty55t/H+O+RTKzv6GP5Ugj 9VJJs6v5+u7xMVmTaDhq4FlhpSx0yOoCvLWgYkdJ74/klFziJGKB7LyVBFhUVEH5uCxp uU1HeGSQ/s4jyvDGyr0HG2MZikkGEKm5ilq88w4mzW2xO3aR2iLEs5+d1NxLl9UhYoPn zMA0JCeGzvHSA9J044ni2HLCEK4PGK3RV6YezdlgR9+eL4HEL06A0db9THfEp0PNMHJS 8I0/5kJ5lIm9KufXJf+Tj/ktC4cAxJokMG0SeGclBulgSzhAcvUxlxkqVa9hpFF5AG/B 8hrA== X-Gm-Message-State: ACgBeo20peBtnScOCBh/MmhmPY8bdJzkWbqh4d+WCwVyGtI5IggwxJKl wJnx4QtJcGHS2o9sCeOEStaoyg== X-Google-Smtp-Source: AA6agR5h2CI32nqdz5wOyFqSvf2UhKVe+zSaW8nguIqIjJL4GEDKfAoZM3ZcDoUgFct2NixsH2YdOA== X-Received: by 2002:a2e:949:0:b0:261:cbac:fc72 with SMTP id 70-20020a2e0949000000b00261cbacfc72mr2163268ljj.463.1661200561957; Mon, 22 Aug 2022 13:36:01 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id b17-20020a056512071100b00492c77c55ddsm1811099lfs.67.2022.08.22.13.36.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Aug 2022 13:36:01 -0700 (PDT) Message-ID: <4a73be48-f1cf-a359-7f34-e3271f14ea95@linaro.org> Date: Mon, 22 Aug 2022 23:36:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 5/7] drm/msm/dp: Implement hpd_notify() Content-Language: en-GB To: Bjorn Andersson , Rob Clark , Abhinav Kumar , Stephen Boyd , Kuogee Hsieh , Sankeerth Billakanti References: <20220810035013.3582848-1-bjorn.andersson@linaro.org> <20220810035013.3582848-6-bjorn.andersson@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20220810035013.3582848-6-bjorn.andersson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Krzysztof Kozlowski , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 10/08/2022 06:50, Bjorn Andersson wrote: > The DisplayPort controller's hot-plug mechanism is based on pinmuxing a > physical signal no a GPIO pin into the controller. This is not always > possible, either because there aren't dedicated GPIOs available or > because the hot-plug signal is a virtual notification, in cases such as > USB Type-C. > > For these cases, by implementing the hpd_notify() callback for the > DisplayPort controller's drm_bridge, a downstream drm_bridge > (next_bridge) can be used to track and signal the connection status > changes. > > This makes it possible to use downstream drm_bridges such as > display-connector or any virtual mechanism, as long as they are > implemented as a drm_bridge. > > Signed-off-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/dp/dp_display.c | 23 +++++++++++++++++++++++ > drivers/gpu/drm/msm/dp/dp_display.h | 1 + > drivers/gpu/drm/msm/dp/dp_drm.c | 3 +++ > drivers/gpu/drm/msm/dp/dp_drm.h | 2 ++ > 4 files changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 699f28f2251e..568295381246 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1303,6 +1303,7 @@ static int dp_display_probe(struct platform_device *pdev) > if (!desc) > return -EINVAL; > > + dp->dp_display.dev = &pdev->dev; > dp->pdev = pdev; > dp->name = "drm_dp"; > dp->id = desc->id; > @@ -1765,3 +1766,25 @@ void dp_bridge_mode_set(struct drm_bridge *drm_bridge, > dp_display->dp_mode.h_active_low = > !!(dp_display->dp_mode.drm_mode.flags & DRM_MODE_FLAG_NHSYNC); > } > + > +void dp_bridge_hpd_notify(struct drm_bridge *bridge, > + enum drm_connector_status status) > +{ > + struct msm_dp_bridge *dp_bridge = to_dp_bridge(bridge); > + struct msm_dp *dp_display = dp_bridge->dp_display; > + struct dp_display_private *dp = container_of(dp_display, struct dp_display_private, dp_display); > + > + /* Without next_bridge interrupts are handled by the DP core directly */ > + if (!dp_display->next_bridge) > + return; > + > + if (!dp->core_initialized) { > + drm_dbg_dp(dp->drm_dev, "not initialized\n"); > + return; > + } > + > + if (!dp_display->is_connected && status == connector_status_connected) > + dp_add_event(dp, EV_HPD_PLUG_INT, 0, 0); > + else if (dp_display->is_connected && status == connector_status_disconnected) > + dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); > +} > diff --git a/drivers/gpu/drm/msm/dp/dp_display.h b/drivers/gpu/drm/msm/dp/dp_display.h > index dcedf021f7fe..d7bc537ead31 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.h > +++ b/drivers/gpu/drm/msm/dp/dp_display.h > @@ -11,6 +11,7 @@ > #include "disp/msm_disp_snapshot.h" > > struct msm_dp { > + struct device *dev; > struct drm_device *drm_dev; > struct device *codec_dev; > struct drm_bridge *bridge; > diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c > index 6df25f7662e7..875b23910bef 100644 > --- a/drivers/gpu/drm/msm/dp/dp_drm.c > +++ b/drivers/gpu/drm/msm/dp/dp_drm.c > @@ -68,6 +68,7 @@ static const struct drm_bridge_funcs dp_bridge_ops = { > .mode_valid = dp_bridge_mode_valid, > .get_modes = dp_bridge_get_modes, > .detect = dp_bridge_detect, > + .hpd_notify = dp_bridge_hpd_notify, > }; > > struct drm_bridge *dp_bridge_init(struct msm_dp *dp_display, struct drm_device *dev, > @@ -138,6 +139,8 @@ struct drm_connector *dp_drm_connector_init(struct msm_dp *dp_display, struct dr > if (IS_ERR(connector)) > return connector; > > + connector->fwnode = fwnode_handle_get(dev_fwnode(dp_display->dev)); Not used anymore, isn't it? Then dp_display->dev also seems unused. > + > drm_connector_attach_encoder(connector, encoder); > > return connector; > diff --git a/drivers/gpu/drm/msm/dp/dp_drm.h b/drivers/gpu/drm/msm/dp/dp_drm.h > index 82035dbb0578..79e6b2cf2d25 100644 > --- a/drivers/gpu/drm/msm/dp/dp_drm.h > +++ b/drivers/gpu/drm/msm/dp/dp_drm.h > @@ -32,5 +32,7 @@ enum drm_mode_status dp_bridge_mode_valid(struct drm_bridge *bridge, > void dp_bridge_mode_set(struct drm_bridge *drm_bridge, > const struct drm_display_mode *mode, > const struct drm_display_mode *adjusted_mode); > +void dp_bridge_hpd_notify(struct drm_bridge *bridge, > + enum drm_connector_status status); > > #endif /* _DP_DRM_H_ */ -- With best wishes Dmitry