From: Lucas Stach <l.stach@pengutronix.de>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: etnaviv@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Russell King <linux+etnaviv@armlinux.org.uk>
Subject: Re: [RESEND PATCH v2 0/4] drm/etnaviv: Tidy up clocks handling
Date: Thu, 18 Jun 2020 17:52:50 +0200 [thread overview]
Message-ID: <4b717455032b5409754dffb71acc82c5fc0fc755.camel@pengutronix.de> (raw)
In-Reply-To: <20200616212127.986410-1-lkundrak@v3.sk>
Am Dienstag, den 16.06.2020, 23:21 +0200 schrieb Lubomir Rintel:
> Hi,
>
> please consider applying patches that are chained to this message.
Thanks, I've applied all of them to etnaviv/next.
Regards,
Lucas
> They make getting/enabling the clocks in the etnaviv driver slightly nicer,
> first two also fix potential problems.
>
> Compared to v1, patch 2/4 was fixed and patch 3/4 was added.
>
> As it was pointed out in response to v1, the clocks documented as
> mandatory by the binding document are different from what the driver
> enforces. Moreover, there is no agreement on which clocks must be
> present in the device tree, so I'm leaving the binding document until
> it's cleared up.
>
> In any case, the "core" clock is always present so it's safe to make it
> mandatory and regardless of what ends up happening to the binding
> documentation, the other clocks can't be enforced without regressions.
> At most a comment or a warning could be added. I'm leaving it as it is.
>
> Thank you
> Lubo
>
>
> _______________________________________________
> etnaviv mailing list
> etnaviv@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/etnaviv
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-06-18 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 21:21 [RESEND PATCH v2 0/4] drm/etnaviv: Tidy up clocks handling Lubomir Rintel
2020-06-16 21:21 ` [RESEND PATCH v2 1/4] drm/etnaviv: Fix error path on failure to enable bus clk Lubomir Rintel
2020-06-16 21:21 ` [RESEND PATCH v2 2/4] drm/etnaviv: Don't ignore errors on getting clocks Lubomir Rintel
2020-06-16 21:21 ` [RESEND PATCH v2 3/4] drm/etnaviv: Make the "core" clock mandatory Lubomir Rintel
2020-06-16 21:21 ` [RESEND PATCH v2 4/4] drm/etnaviv: Simplify clock enable/disable Lubomir Rintel
2020-06-18 15:52 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b717455032b5409754dffb71acc82c5fc0fc755.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).