From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE6BAC5519F for ; Wed, 18 Nov 2020 20:03:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1432C205F4 for ; Wed, 18 Nov 2020 20:03:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="ZTkRuipx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1432C205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0511D89F6B; Wed, 18 Nov 2020 20:03:55 +0000 (UTC) Received: from m42-4.mailgun.net (m42-4.mailgun.net [69.72.42.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id 314E46E44B for ; Wed, 18 Nov 2020 20:03:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1605729834; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=NPmVss055K8CbLWs/1vukepUTozf+/2SWf1JuTKgk6s=; b=ZTkRuipxVmpgvJuhzz7LMF6jgcThfd4xiEbe+EQHQfXqAET8K07j0CcFFo7DTq0n82Ff/0TH OAv7a6GVF/Eaf7v+/tbCt7Kib32oXO6gbgR2RRX9zbCCExVPhdTtJw2oQEgiUqGopsx4X81k z+54yDFkE54adckZJLdazU/wds4= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n08.prod.us-west-2.postgun.com with SMTP id 5fb57e29e714ea6501b479ab (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 18 Nov 2020 20:03:53 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E2EFBC43461; Wed, 18 Nov 2020 20:03:52 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id ECEB4C433ED; Wed, 18 Nov 2020 20:03:51 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 18 Nov 2020 12:03:51 -0800 From: abhinavk@codeaurora.org To: Rob Clark Subject: Re: [Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print In-Reply-To: References: <20201117172608.2091648-1-swboyd@chromium.org> <71aebca216babf4010c92d4d1ce9a9b4@codeaurora.org> <160565358127.60232.4382778730228368993@swboyd.mtv.corp.google.com> Message-ID: <4c955afcc2eb28794a5bbcc0e1642592@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno , linux-arm-msm , Linux Kernel Mailing List , dri-devel , Stephen Boyd , Kalyan Thota , Sean Paul Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Stephen On 2020-11-18 07:49, Rob Clark wrote: > On Tue, Nov 17, 2020 at 2:53 PM Stephen Boyd > wrote: >> >> Quoting abhinavk@codeaurora.org (2020-11-17 12:34:56) >> > On 2020-11-17 09:26, Stephen Boyd wrote: >> > > I don't know what this debug print is for but it is super chatty, >> > > throwing 8 lines of debug prints in the logs every time we update a >> > > plane. It looks like it has no value. Let's nuke it so we can get >> > > better logs. >> > > >> > > Cc: Sean Paul >> > > Cc: Abhinav Kumar >> > > Signed-off-by: Stephen Boyd >> > >> > > --- >> > > drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 3 --- >> > > 1 file changed, 3 deletions(-) >> > > >> > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c >> > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c >> > > index 5e8c3f3e6625..5eb2b2ee09f5 100644 >> > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c >> > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c >> > > @@ -245,9 +245,6 @@ void dpu_vbif_set_qos_remap(struct dpu_kms >> > > *dpu_kms, >> > > forced_on = mdp->ops.setup_clk_force_ctrl(mdp, params->clk_ctrl, >> > > true); >> > > >> > > for (i = 0; i < qos_tbl->npriority_lvl; i++) { >> > > - DPU_DEBUG("vbif:%d xin:%d lvl:%d/%d\n", >> > > - params->vbif_idx, params->xin_id, i, >> > > - qos_tbl->priority_lvl[i]); >> > >> > Instead of getting rid of this print, we should optimize the caller of >> > this. >> >> Does the print tell us anything? Right now it prints 8 lines where it >> feels like it could be trimmed down: >> >> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:0/3 >> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:1/3 >> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:2/4 >> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:3/4 >> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:4/5 >> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:5/5 >> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:6/6 >> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 lvl:7/6 >> >> maybe one line that combines the index into values? >> >> [drm:dpu_vbif_set_qos_remap] vbif:0 xin:0 [3 3 4 4 5 5 6 6] >> > > or possibly convert to a tracepoint (so it doesn't spam the drm_trace > buffer) > > BR, > -R > >> But again I have no idea if this print is really useful. Maybe we can >> print it only if the value changes from what was already there? >> Basically move the print into dpu_hw_set_qos_remap() and then skip out >> early if nothing changed or print and modify the register. >> >> > This is what >> > we are doing in downstream. So we need to update the property only if we >> > are switching from a RT client >> > to non-RT client for the plane and vice-versa. So we should try to do >> > the same thing here. >> > >> > is_rt = sde_crtc_is_rt_client(crtc, crtc->state); >> > if (is_rt != psde->is_rt_pipe) { >> > psde->is_rt_pipe = is_rt; >> > pstate->dirty |= SDE_PLANE_DIRTY_QOS; >> > } >> > >> > >> > if (pstate->dirty & DPU_PLANE_DIRTY_QOS) >> > _dpu_plane_set_qos_remap(plane); >> > >> >> Sounds great! Can you send the patch? Will finalize approach and send the patch in a day or two. Thanks Abhinav _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel