From: Tom Rix <trix@redhat.com>
To: Hamza Mahfooz <hamza.mahfooz@amd.com>,
harry.wentland@amd.com, sunpeng.li@amd.com,
Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
daniel@ffwll.ch, Alvin.Lee2@amd.com, Jun.Lei@amd.com,
qingqing.zhuo@amd.com, Max.Tseng@amd.com, Josip.Pavic@amd.com,
Eric.Yang2@amd.com, aurabindo.pillai@amd.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: return status of dmub_srv_get_fw_boot_status
Date: Mon, 24 Apr 2023 11:14:10 -0700 [thread overview]
Message-ID: <4ca4e590-a996-81ad-e088-d172f5a5a8ba@redhat.com> (raw)
In-Reply-To: <9910a5e3-a161-edfa-19d4-2bbf3bbf405f@amd.com>
On 4/24/23 10:02 AM, Hamza Mahfooz wrote:
>
> On 4/20/23 09:59, Tom Rix wrote:
>> gcc with W=1 reports
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:
>> In function ‘dc_dmub_srv_optimized_init_done’:
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:184:26:
>> error: variable ‘dmub’ set but not used
>> [-Werror=unused-but-set-variable]
>> 184 | struct dmub_srv *dmub;
>> | ^~~~
>>
>> The return status is never set.
>> It looks like a call to dmub_srv_get_fw_boot_status is missing.
>>
>> Fixes: 499e4b1c722e ("drm/amd/display: add mechanism to skip DCN init")
>
> What tree is this based on? I am unable to find that exact commit on
> amd-staging-drm-next.
linux-next
Tom
>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 13 +++++++++++--
>> 1 file changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
>> b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
>> index d15ec32243e2..36d936ab4300 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
>> @@ -182,14 +182,23 @@ bool dc_dmub_srv_cmd_run_list(struct
>> dc_dmub_srv *dc_dmub_srv, unsigned int coun
>> bool dc_dmub_srv_optimized_init_done(struct dc_dmub_srv *dc_dmub_srv)
>> {
>> struct dmub_srv *dmub;
>> - union dmub_fw_boot_status status;
>> + struct dc_context *dc_ctx;
>> + union dmub_fw_boot_status boot_status;
>> + enum dmub_status status;
>> if (!dc_dmub_srv || !dc_dmub_srv->dmub)
>> return false;
>> dmub = dc_dmub_srv->dmub;
>> + dc_ctx = dc_dmub_srv->ctx;
>> +
>> + status = dmub_srv_get_fw_boot_status(dmub, &boot_status);
>> + if (status != DMUB_STATUS_OK) {
>> + DC_ERROR("Error querying DMUB boot status: error=%d\n",
>> status);
>> + return false;
>> + }
>> - return status.bits.optimized_init_done;
>> + return boot_status.bits.optimized_init_done;
>> }
>> bool dc_dmub_srv_notify_stream_mask(struct dc_dmub_srv *dc_dmub_srv,
next prev parent reply other threads:[~2023-04-24 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 13:59 [PATCH] drm/amd/display: return status of dmub_srv_get_fw_boot_status Tom Rix
2023-04-24 17:02 ` Hamza Mahfooz
2023-04-24 18:14 ` Tom Rix [this message]
2023-04-26 20:50 ` Hamza Mahfooz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca4e590-a996-81ad-e088-d172f5a5a8ba@redhat.com \
--to=trix@redhat.com \
--cc=Alvin.Lee2@amd.com \
--cc=Eric.Yang2@amd.com \
--cc=Josip.Pavic@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Max.Tseng@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamza.mahfooz@amd.com \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qingqing.zhuo@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).