Re: [PATCH v2 07/10] drm/amdgpu: Do not include <drm/drm_fb_helper.h>

[Thomas Zimmermann <tzimmermann@suse.de>]

[-- Attachment #1.1: Type: text/plain, Size: 2813 bytes --]

Hi

Am 11.01.23 um 14:21 schrieb Christian König:
> Am 11.01.23 um 14:02 schrieb Thomas Zimmermann:
>> Including <drm/drm_fb_helper.h> is not required, so remove the include
>> statements. No functional changes.
> 
> Reviewed-by: Christian König <christian.koenig@amd.com> for this one and 
> the radeon patches #9 and #10 in this set.
> 
> Do you want to push them to drm-misc-next because of some 
> inter-dependencies or should I pick them up through amd-staging-drm-next?

I'd like to take the whole patchset via drm-misc-next. The earlier OF 
and backlight includes are required for some of the later removals. Best 
to keep this in one piece.

Best regards
Thomas


> 
> Christian.
> 
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 1 -
>>   drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 1 -
>>   drivers/gpu/drm/amd/amdgpu/dce_v6_0.c  | 1 -
>>   drivers/gpu/drm/amd/amdgpu/dce_v8_0.c  | 1 -
>>   4 files changed, 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c 
>> b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
>> index 248f1a4e915f..a2452fc304c5 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
>> @@ -21,7 +21,6 @@
>>    *
>>    */
>> -#include <drm/drm_fb_helper.h>
>>   #include <drm/drm_fourcc.h>
>>   #include <drm/drm_vblank.h>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c 
>> b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
>> index cd9c19060d89..6ac680c4c6e2 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
>> @@ -21,7 +21,6 @@
>>    *
>>    */
>> -#include <drm/drm_fb_helper.h>
>>   #include <drm/drm_fourcc.h>
>>   #include <drm/drm_vblank.h>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c 
>> b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
>> index 76323deecc58..354ae09cc9a2 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c
>> @@ -23,7 +23,6 @@
>>   #include <linux/pci.h>
>> -#include <drm/drm_fb_helper.h>
>>   #include <drm/drm_fourcc.h>
>>   #include <drm/drm_vblank.h>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c 
>> b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
>> index 01cf3ab111cb..33977b0ba19d 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
>> @@ -21,7 +21,6 @@
>>    *
>>    */
>> -#include <drm/drm_fb_helper.h>
>>   #include <drm/drm_fourcc.h>
>>   #include <drm/drm_vblank.h>
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]