From: Laura Abbott <firstname.lastname@example.org> To: John Stultz <email@example.com> Cc: Alistair Strachan <firstname.lastname@example.org>, Greg KH <email@example.com>, Chenbo Feng <firstname.lastname@example.org>, lkml <email@example.com>, Liam Mark <firstname.lastname@example.org>, ML dri-devel <email@example.com>, "Andrew F . Davis" <firstname.lastname@example.org> Subject: Re: [RFC][PATCH 5/5 v2] kselftests: Add dma-heap test Date: Fri, 15 Mar 2019 13:49:04 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <CALAqxLUjSZHBXsT0c-KTra4zLFxCYDmYHTJswk5OckrUbdfirstname.lastname@example.org> On 3/15/19 1:13 PM, John Stultz wrote: > On Fri, Mar 15, 2019 at 1:07 PM Laura Abbott <email@example.com> wrote: >> >> On 3/6/19 9:01 AM, John Stultz wrote: >>> On Wed, Mar 6, 2019 at 8:14 AM Benjamin Gaignard >>> <firstname.lastname@example.org> wrote: >>>> Le mar. 5 mars 2019 à 21:54, John Stultz <email@example.com> a écrit : >>>>> + >>>>> + printf("Allocating 1 MEG\n"); >>>>> + ret = dmabuf_heap_alloc(heap_fd, ONE_MEG, 0, &dmabuf_fd); >>>>> + if (ret) >>>>> + goto out; >>>>> + >>>>> + /* DO SOMETHING WITH THE DMABUF HERE? */ >>>> >>>> You can do a call to mmap and write a pattern in the buffer. >>> >>> Yea. I can also do some invalid allocations to make sure things fail properly. >>> >>> But I was talking a bit w/ Sumit about the lack of any general dmabuf >>> tests, and am curious if we need to have a importer device driver that >>> can validate its a real dmabuf and exercise more of the dmabuf ops. >>> >>> thanks >>> -john >>> >> >> There's the vgem driver in drm. I did some work to clean that >> up so it could take an import af33a9190d02 ("drm/vgem: Enable dmabuf import >> interfaces") . I mostly used it for private tests and never ended >> up upstreaming any of the tests. > > Thanks for the poitner, I'll check that out as well! Also, if you > still have them around, I'd be interested in checking out the tests to > try to get something integrated into kselftest. > > Talking with Brian yesterday, there was some thought that we should > try to put together some sort of example dmabuf pipeline that isn't > hardware dependent and can be used to demonstrate the usage model as > well as validate the frameworks and maybe even benchmark some of the > ideas floating around right now. So suggestions here would be > welcome! > So the existing ion selftest (tools/testing/selftests/android/ion) does make use of the import to do some very simple tests. I can't seem to find the more complex tests I had though they may have been lost during my last machine move :( I do think building off of vgem would be a good first step for a testing pipeline, although I worry we wouldn't be able to measure caching effects without a real device since setting up coherency testing otherwise seems error prone. Thanks, Laura > thanks > -john > _______________________________________________ dri-devel mailing list firstname.lastname@example.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-15 20:49 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-05 20:54 [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION) John Stultz 2019-03-05 20:54 ` [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework John Stultz 2019-03-06 16:12 ` Benjamin Gaignard 2019-03-06 16:57 ` John Stultz 2019-03-15 8:55 ` Christoph Hellwig 2019-03-06 16:27 ` Andrew F. Davis 2019-03-06 19:03 ` John Stultz 2019-03-06 21:45 ` Andrew F. Davis 2019-03-15 8:54 ` Christoph Hellwig 2019-03-15 20:24 ` Andrew F. Davis 2019-03-15 20:18 ` Laura Abbott 2019-03-15 20:49 ` Andrew F. Davis 2019-03-15 21:29 ` John Stultz 2019-03-15 22:44 ` Laura Abbott 2019-03-18 4:38 ` Sumit Semwal 2019-03-18 4:41 ` Sumit Semwal 2019-03-19 12:08 ` Brian Starkey 2019-03-19 15:24 ` Andrew F. Davis 2019-03-21 21:16 ` John Stultz 2019-03-27 14:53 ` Greg KH 2019-03-28 6:09 ` John Stultz 2019-03-05 20:54 ` [RFC][PATCH 2/5 v2] dma-buf: heaps: Add heap helpers John Stultz 2019-03-13 20:18 ` Liam Mark 2019-03-13 21:48 ` Andrew F. Davis 2019-03-13 22:57 ` Liam Mark 2019-03-13 23:42 ` Andrew F. Davis 2019-03-15 9:06 ` Christoph Hellwig 2019-03-19 15:03 ` Andrew F. Davis 2019-03-21 20:01 ` John Stultz 2019-03-19 14:26 ` Brian Starkey 2019-03-21 20:11 ` John Stultz 2019-03-21 20:35 ` Andrew F. Davis 2019-03-21 20:43 ` Andrew F. Davis 2019-03-05 20:54 ` [RFC][PATCH 3/5 v2] dma-buf: heaps: Add system heap to dmabuf heaps John Stultz 2019-03-06 16:01 ` Benjamin Gaignard 2019-03-11 5:48 ` John Stultz 2019-03-13 20:20 ` Liam Mark 2019-03-13 22:49 ` John Stultz 2019-03-15 9:06 ` Christoph Hellwig 2019-03-05 20:54 ` [RFC][PATCH 4/5 v2] dma-buf: heaps: Add CMA heap to dmabuf heapss John Stultz 2019-03-06 16:05 ` Benjamin Gaignard 2019-03-21 20:15 ` John Stultz 2019-03-15 9:06 ` Christoph Hellwig 2019-03-15 20:08 ` John Stultz 2019-03-19 14:53 ` Brian Starkey 2019-03-05 20:54 ` [RFC][PATCH 5/5 v2] kselftests: Add dma-heap test John Stultz 2019-03-06 16:14 ` Benjamin Gaignard 2019-03-06 16:35 ` Andrew F. Davis 2019-03-06 18:19 ` John Stultz 2019-03-06 18:32 ` Andrew F. Davis 2019-03-06 17:01 ` John Stultz 2019-03-15 20:07 ` Laura Abbott 2019-03-15 20:13 ` John Stultz 2019-03-15 20:49 ` Laura Abbott [this message] 2019-03-13 20:23 ` Liam Mark 2019-03-13 20:11 ` [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION) Liam Mark 2019-03-13 22:30 ` John Stultz 2019-03-13 23:29 ` Liam Mark 2019-03-19 16:54 ` Benjamin Gaignard 2019-03-19 16:59 ` Andrew F. Davis 2019-03-19 21:58 ` Rob Clark 2019-03-19 22:36 ` John Stultz 2019-03-20 9:16 ` Benjamin Gaignard 2019-03-20 14:44 ` Andrew F. Davis 2019-03-20 15:59 ` Benjamin Gaignard 2019-03-20 16:11 ` John Stultz 2019-03-15 20:34 ` Laura Abbott 2019-03-15 23:15 ` Jerome Glisse 2019-03-16 0:16 ` John Stultz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [RFC][PATCH 5/5 v2] kselftests: Add dma-heap test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).