From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66560C433DF for ; Mon, 25 May 2020 15:38:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 354652071C for ; Mon, 25 May 2020 15:38:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="utZPS/L9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 354652071C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5239899B0; Mon, 25 May 2020 15:38:50 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id BADD6899A7 for ; Mon, 25 May 2020 15:38:48 +0000 (UTC) Received: from [192.168.0.20] (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E379562; Mon, 25 May 2020 17:38:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1590421126; bh=CH7bO9h+bXgSIApeNO1CojJAmdxpKZhJjd8+hwnYzd8=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=utZPS/L9k+UGhCThI3kWJUjSf4F+c1Fex7fvUJ/hoJUEPfjvrtm3lG4z8MuYcGIcK 8cKm2UVTJ3v5S0JX+ToiHOrGHD9WdgSZUUJFG0DU/KhnUqTZ3C7mjmrv4XwMa9EmAf +1FqsIdSv9X4nKQVubvYiPgPdJP0b6hza+2kLqQ0= Subject: Re: [PATCH 15/21] drm/rcar-du: Use GEM CMA object functions To: Thomas Zimmermann , Laurent Pinchart References: <20200522135246.10134-1-tzimmermann@suse.de> <20200522135246.10134-16-tzimmermann@suse.de> <20200522201240.GE5824@pendragon.ideasonboard.com> <816a8a0e-bb98-ea6c-5016-94b18e045fb5@suse.de> From: Kieran Bingham Organization: Ideas on Board Message-ID: <50d76988-f627-037d-a8bc-d18f6662c981@ideasonboard.com> Date: Mon, 25 May 2020 16:38:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <816a8a0e-bb98-ea6c-5016-94b18e045fb5@suse.de> Content-Language: en-GB X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: kieran.bingham+renesas@ideasonboard.com Cc: alexandre.belloni@bootlin.com, linux-aspeed@lists.ozlabs.org, narmstrong@baylibre.com, airlied@linux.ie, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, nicolas.ferre@microchip.com, paul@crapouillou.net, mihail.atanassov@arm.com, sam@ravnborg.org, marex@denx.de, khilman@baylibre.com, abrodkin@synopsys.com, kong.kongxinwei@hisilicon.com, xinliang.liu@linaro.org, ludovic.desroches@microchip.com, tomi.valkeinen@ti.com, james.qian.wang@arm.com, joel@jms.id.au, linux-imx@nxp.com, alexandre.torgue@st.com, puck.chen@hisilicon.com, s.hauer@pengutronix.de, alison.wang@nxp.com, jsarha@ti.com, wens@csie.org, vincent.abriou@st.com, linux-arm-kernel@lists.infradead.org, mcoquelin.stm32@gmail.com, bbrezillon@kernel.org, andrew@aj.id.au, philippe.cornu@st.com, yannick.fertre@st.com, kernel@pengutronix.de, zourongrong@gmail.com, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 25/05/2020 13:49, Thomas Zimmermann wrote: > Hi > > Am 22.05.20 um 22:12 schrieb Laurent Pinchart: >> Hi Thomas, >> >> Thank you for the patch. >> >> On Fri, May 22, 2020 at 03:52:40PM +0200, Thomas Zimmermann wrote: >>> The rcar-du driver uses the default implementation for CMA functions; >>> except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro >>> now sets these defaults and .dumb_create in struct drm_driver. All >>> remaining operations are provided by CMA GEM object functions. >>> >>> Signed-off-by: Thomas Zimmermann >>> --- >>> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 11 +---------- >>> 1 file changed, 1 insertion(+), 10 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c >>> index 3e67cf70f0402..3728038cec1d1 100644 >>> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c >>> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c >>> @@ -476,16 +476,7 @@ DEFINE_DRM_GEM_CMA_FOPS(rcar_du_fops); >>> >>> static struct drm_driver rcar_du_driver = { >>> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, >>> - .gem_free_object_unlocked = drm_gem_cma_free_object, >>> - .gem_vm_ops = &drm_gem_cma_vm_ops, >>> - .prime_handle_to_fd = drm_gem_prime_handle_to_fd, >>> - .prime_fd_to_handle = drm_gem_prime_fd_to_handle, >>> - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table, >>> - .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table, >>> - .gem_prime_vmap = drm_gem_cma_prime_vmap, >>> - .gem_prime_vunmap = drm_gem_cma_prime_vunmap, >>> - .gem_prime_mmap = drm_gem_cma_prime_mmap, >>> - .dumb_create = rcar_du_dumb_create, >>> + __DRM_GEM_CMA_DRIVER_OPS(rcar_du_dumb_create), >> >> Your __DRM_GEM_CMA_DRIVER_OPS is defined as >> >> #define __DRM_GEM_CMA_DRIVER_OPS(__dumb_create) \ >> .gem_create_object = drm_cma_gem_create_object_default_funcs, \ >> .dumb_create = (__dumb_create), \ >> .prime_handle_to_fd = drm_gem_prime_handle_to_fd, \ >> .prime_fd_to_handle = drm_gem_prime_fd_to_handle, \ >> .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table_vmap, \ >> .gem_prime_mmap = drm_gem_prime_mmap >> >> The patch thus introduces several changes: >> >> - drm_gem_cma_prime_import_sg_table_vmap() is used instead of >> drm_gem_cma_prime_import_sg_table() combined with .gem_prime_vmap() >> and .gem_prime_vunmap(). I believe that's fine, but splitting that >> change in a separate commit, or at the very least explaining it in >> details in the commit message, would make review easier. >> >> - .gem_create_object() is now set. That seems to be OK, but I'm not sure >> to grasp all the implications. This should also be explained in the >> commit message, and ideally split to a separate patch. > > That's relevant during object creation and sets the object functions. > See one of my other replies for how this can go away after all CMA > drivers have been updated to GEM object functions. > > >> >> - drm_gem_cma_prime_mmap() is replaced with drm_gem_prime_mmap(). Same >> comments :-) > > I relied on the aspeed driver to be correct. After Sam's comment on > that, I read the code once again several times. The original > implementation clears VM_PFNMAP. And I cannot find that code any longer. > Going back to the original function might be better. > > >> >> This patch hides way too many changes in what is documented as just >> innocent refactoring. It seems other drivers are affected too. > > Could you test the patchset? I don't have the HW. Digging out the branch you provided elsewhere in this thread: >>> Could you boot-test with the patchset applied? >> >> Yes, if you have a git branch I can just build and boot I can >> do it quickly! > > Fantastic! It's the cma-objfuncs branch of > > https://gitlab.freedesktop.org/tzimmermann/linux.git I have successfully run our display tests with your patches here on an R-Car H3 Salvator-XS(-es2). Tested-by: Kieran Bingham > Best regards > Thomas > >> >>> .fops = &rcar_du_fops, >>> .name = "rcar-du", >>> .desc = "Renesas R-Car Display Unit", >> > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel