From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F026CC4332B for ; Mon, 23 Mar 2020 21:48:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEC96206C3 for ; Mon, 23 Mar 2020 21:48:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="QXwueG9y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEC96206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EA7F89DFB; Mon, 23 Mar 2020 21:48:32 +0000 (UTC) Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by gabe.freedesktop.org (Postfix) with ESMTPS id 27BDA89DFB for ; Mon, 23 Mar 2020 21:48:31 +0000 (UTC) Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id C69025C0BDA; Mon, 23 Mar 2020 22:48:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1585000109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QzjjaJfxuC5Z92eyQDHinovJ6jh9cpCUmSDYHoXp8OQ=; b=QXwueG9yvnkyP+Qr2IFXhWdT+tc5WeARZil+6O0NaudfSCvqsibiiu/gaEraUF2QKxlZIz J8ymvfwRCK/U9n/Mm0IMRtStlbU9rBQbTBRUlu7wQDkyHajlbu9CrXFiV/am9/EmexiFKQ KuXaJyUbClMT1ZD2HsnWiHwhnyROmSY= MIME-Version: 1.0 Date: Mon, 23 Mar 2020 22:48:29 +0100 From: Stefan Agner To: Laurent Pinchart Subject: Re: [PATCH 07/21] drm: mxsfb: Use LCDC_CTRL register name explicitly In-Reply-To: <20200309195216.31042-8-laurent.pinchart@ideasonboard.com> References: <20200309195216.31042-1-laurent.pinchart@ideasonboard.com> <20200309195216.31042-8-laurent.pinchart@ideasonboard.com> User-Agent: Roundcube Webmail/1.4.1 Message-ID: <5256321c0cd91274682b43567d1d8e7e@agner.ch> X-Sender: stefan@agner.ch X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , kernel@pengutronix.de, dri-devel@lists.freedesktop.org, linux-imx@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-03-09 20:52, Laurent Pinchart wrote: > The LCDC_CTRL register is located at address 0x0000. Some of the > accesses to the register simply use the mxsfb->base address. Reference > the LCDC_CTRL register explicitly instead to clarify the code. > > Signed-off-by: Laurent Pinchart Reviewed-by: Stefan Agner > --- > drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c > b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c > index be60c4021e2f..722bd9b4f5f9 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c > @@ -170,17 +170,17 @@ static int mxsfb_reset_block(struct > mxsfb_drm_private *mxsfb) > { > int ret; > > - ret = clear_poll_bit(mxsfb->base, MODULE_SFTRST); > + ret = clear_poll_bit(mxsfb->base + LCDC_CTRL, MODULE_SFTRST); > if (ret) > return ret; > > - writel(MODULE_CLKGATE, mxsfb->base + MXS_CLR_ADDR); > + writel(MODULE_CLKGATE, mxsfb->base + LCDC_CTRL + MXS_CLR_ADDR); > > - ret = clear_poll_bit(mxsfb->base, MODULE_SFTRST); > + ret = clear_poll_bit(mxsfb->base + LCDC_CTRL, MODULE_SFTRST); > if (ret) > return ret; > > - return clear_poll_bit(mxsfb->base, MODULE_CLKGATE); > + return clear_poll_bit(mxsfb->base + LCDC_CTRL, MODULE_CLKGATE); > } > > static dma_addr_t mxsfb_get_fb_paddr(struct mxsfb_drm_private *mxsfb) _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel