From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>, Vinod Koul <vkoul@kernel.org>,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v3 6/8] drm/msm/dpu: add support for MDP_TOP blackhole
Date: Thu, 10 Nov 2022 21:21:05 +0100 [thread overview]
Message-ID: <52fa0ebd-e431-7159-ef1e-a2cde7c7a4e2@linaro.org> (raw)
In-Reply-To: <5c791922-1371-c9e7-4bdc-e1909956633f@linaro.org>
On 10/11/2022 21:19, Dmitry Baryshkov wrote:
> On 04/11/2022 16:58, Konrad Dybcio wrote:
>>
>> On 04/11/2022 14:03, Dmitry Baryshkov wrote:
>>> On sm8450 a register block was removed from MDP TOP. Accessing it during
>>> snapshotting results in NoC errors / immediate reboot. Skip accessing
>>> these registers during snapshot.
>>
>> Must have been fun to debug..
>>
>>
>>>
>>> Tested-by: Vinod Koul <vkoul@kernel.org>
>>> Reviewed-by: Vinod Koul <vkoul@kernel.org>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 +
>>> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 11 +++++++++--
>>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
>>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
>>> index 38aa38ab1568..4730f8268f2a 100644
>>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
>>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
>>> @@ -92,6 +92,7 @@ enum {
>>> DPU_MDP_UBWC_1_0,
>>> DPU_MDP_UBWC_1_5,
>>> DPU_MDP_AUDIO_SELECT,
>>> + DPU_MDP_PERIPH_0_REMOVED,
>>> DPU_MDP_MAX
>>> };
>>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
>>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
>>> index f3660cd14f4f..95d8765c1c53 100644
>>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
>>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
>>> @@ -927,8 +927,15 @@ static void dpu_kms_mdp_snapshot(struct
>>> msm_disp_state *disp_state, struct msm_k
>>> msm_disp_snapshot_add_block(disp_state, cat->wb[i].len,
>>> dpu_kms->mmio + cat->wb[i].base, "wb_%d", i);
>>> - msm_disp_snapshot_add_block(disp_state, cat->mdp[0].len,
>>> - dpu_kms->mmio + cat->mdp[0].base, "top");
>>> + if (dpu_kms->hw_mdp->caps->features &
>>> BIT(DPU_MDP_PERIPH_0_REMOVED)) {
>>> + msm_disp_snapshot_add_block(disp_state, 0x380,
>>> + dpu_kms->mmio + cat->mdp[0].base, "top");
>>> + msm_disp_snapshot_add_block(disp_state, cat->mdp[0].len -
>>> 0x3a8,
>>> + dpu_kms->mmio + cat->mdp[0].base + 0x3a8, "top_2");
>>
>> Are these values expected to stay the same on different new-gen SoCs?
>> Maybe it would
>>
>> be worth making it dynamic.
>
> I do not want to overcomplicate this. Let's make it dynamic once there
> is need for that. For now I expect this will be static.
Let's roll with that.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
>>
>>
>> Konrad
>>
>>> + } else {
>>> + msm_disp_snapshot_add_block(disp_state, cat->mdp[0].len,
>>> + dpu_kms->mmio + cat->mdp[0].base, "top");
>>> + }
>>> pm_runtime_put_sync(&dpu_kms->pdev->dev);
>>> }
>
next prev parent reply other threads:[~2022-11-10 20:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 13:03 [PATCH v3 0/8] drm/msm: add support for SM8450 Dmitry Baryshkov
2022-11-04 13:03 ` [PATCH v3 1/8] dt-bindings: display/msm/dsi-controller-main: allow defining opp-table Dmitry Baryshkov
2022-11-04 13:03 ` [PATCH v3 2/8] dt-bindings: display/msm: add sm8350 and sm8450 DSI PHYs Dmitry Baryshkov
2022-11-04 13:03 ` [PATCH v3 3/8] dt-bindings: display/msm: add support for the display on SM8450 Dmitry Baryshkov
2022-11-04 17:54 ` Rob Herring
2022-11-08 11:02 ` Krzysztof Kozlowski
2022-11-04 13:03 ` [PATCH v3 4/8] drm/msm/dsi: add support for DSI-PHY on SM8350 and SM8450 Dmitry Baryshkov
2022-11-04 13:54 ` Konrad Dybcio
2022-11-10 22:16 ` Dmitry Baryshkov
2022-11-14 16:13 ` Konrad Dybcio
2022-11-04 13:03 ` [PATCH v3 5/8] drm/msm/dsi: add support for DSI 2.6.0 Dmitry Baryshkov
2022-11-04 13:55 ` Konrad Dybcio
2022-11-16 7:35 ` Abhinav Kumar
2022-11-04 13:03 ` [PATCH v3 6/8] drm/msm/dpu: add support for MDP_TOP blackhole Dmitry Baryshkov
2022-11-04 13:58 ` Konrad Dybcio
2022-11-10 20:19 ` Dmitry Baryshkov
2022-11-10 20:21 ` Konrad Dybcio [this message]
2022-11-16 7:50 ` Abhinav Kumar
2022-11-16 8:19 ` Dmitry Baryshkov
2022-11-16 8:30 ` Abhinav Kumar
2022-11-16 9:18 ` Dmitry Baryshkov
2022-11-16 9:29 ` Abhinav Kumar
2022-11-16 9:43 ` Dmitry Baryshkov
2022-11-16 9:59 ` Abhinav Kumar
2022-11-04 13:03 ` [PATCH v3 7/8] drm/msm/dpu: add support for SM8450 Dmitry Baryshkov
2022-11-04 14:12 ` Konrad Dybcio
2022-11-10 20:28 ` Dmitry Baryshkov
2022-11-10 20:59 ` Konrad Dybcio
2022-11-04 13:03 ` [PATCH v3 8/8] drm/msm: mdss: " Dmitry Baryshkov
2022-11-04 14:12 ` Konrad Dybcio
2022-11-16 7:53 ` Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52fa0ebd-e431-7159-ef1e-a2cde7c7a4e2@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).