From: "Michel Dänzer" <michel.daenzer@mailbox.org>
To: Hans de Goede <hdegoede@redhat.com>,
Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/gma500: Fix crtc_vblank reference leak when userspace queues multiple events
Date: Tue, 6 Sep 2022 12:25:53 +0200 [thread overview]
Message-ID: <530089c9-59c2-8ff9-a547-b25d5ad04c59@mailbox.org> (raw)
In-Reply-To: <20220905133738.466490-3-hdegoede@redhat.com>
On 2022-09-05 15:37, Hans de Goede wrote:
> The gma500 page-flip code kinda assume that userspace never queues more
> then 1 vblank event. So basically it assume that userspace does:
>
> - page-flip
> - wait for vblank event
> - render
> - page-flip
> - etc.
>
> In the case where userspace would submit 2 page-flips without waiting
> for the first to finish, the current code will just overwrite
> gma_crtc->page_flip_event with the event from the 2nd page-flip.
This cannot happen. Common code returns -EBUSY for an attempt to submit a page flip while another one is still pending.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
next prev parent reply other threads:[~2022-09-06 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 13:37 [PATCH 0/3] drm/gma500: Fix 2 locking related WARN_ON oopses Hans de Goede
2022-09-05 13:37 ` [PATCH 1/3] drm/gma500: Fix BUG: sleeping function called from invalid context errors Hans de Goede
2022-09-06 12:50 ` Patrik Jakobsson
2022-09-06 16:49 ` Hans de Goede
2022-09-05 13:37 ` [PATCH 2/3] drm/gma500: Fix crtc_vblank reference leak when userspace queues multiple events Hans de Goede
2022-09-06 10:25 ` Michel Dänzer [this message]
2022-09-06 16:52 ` Hans de Goede
2022-09-05 13:37 ` [PATCH 3/3] drm/gma500: Fix WARN_ON(lock->magic != lock) error Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530089c9-59c2-8ff9-a547-b25d5ad04c59@mailbox.org \
--to=michel.daenzer@mailbox.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).