From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAB84C38A29 for ; Thu, 16 Apr 2020 06:59:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81485206A2 for ; Thu, 16 Apr 2020 06:59:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="sO3OU5lD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81485206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goldelico.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 172886EADA; Thu, 16 Apr 2020 06:59:09 +0000 (UTC) Received: from mo6-p03-ob.smtp.rzone.de (mo6-p03-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5303::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52E6A6E9E4 for ; Wed, 15 Apr 2020 13:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1586956667; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=ggeVHX1ECoHuxb0UgkenFd/4IT/OkoIPA4CW4OSiH4U=; b=sO3OU5lDzfRc7q3VEWGtboNlQmVOMhYh8i2kmd37sdAQoJwmCw1g1aTBgXkZZ6FM/4 RyPg4lTZ/19w1OrwscbTPJ8iAtJyNZyrpo4Zc1sdwQcH6/63EnFVMUXVv1SvhybfAlfq LoXgMFt+Dh4HZbIpakIINklsSJwclnRwsy93h+Hz8mONRoKO43UItvfe/11hiKhz+maT pnVKW9+qMPKtRPUZF1uUzvEzvSRRMk1zb69ezDliySxxNLsLxd8vSJ94kZUvRKzTFa+P tivH0bEmF4eYRgcfGCb+i+U48fTJcyUblwJ3L3uRxV0K17/H7QW1p65MQ+VpAEgAsGTe Sawg== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NMGH/PtwDConyM=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 46.4.0 DYNA|AUTH) with ESMTPSA id 6028a2w3FDHP26i (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 15 Apr 2020 15:17:25 +0200 (CEST) Subject: Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 15 Apr 2020 15:17:25 +0200 Message-Id: <535CAEBE-F43E-4BFC-B989-612C81F0D7EF@goldelico.com> References: <06fb6569259bb9183d0a0d0fe70ec4f3033b8aab.1586939718.git.hns@goldelico.com> <20200415101251.o3wi5t6xvf56xmhq@gilmour.lan> <72919514-0657-4B71-902F-3E775E528F64@goldelico.com> To: Neil Armstrong X-Mailer: Apple Mail (2.3124) X-Mailman-Approved-At: Thu, 16 Apr 2020 06:59:07 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , James Hogan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil , linux-samsung-soc@vger.kernel.org, Paul Burton , Krzysztof Kozlowski , Tony Lindgren , Chen-Yu Tsai , Kukjin Kim , devicetree@vger.kernel.org, Rob Herring , Maxime Ripard , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Philipp Rossak , openpvrsgx-devgroup@letux.org, linux-mips@vger.kernel.org, Ralf Baechle , =?utf-8?Q?Beno=C3=AEt_Cousson?= , kernel@pyra-handheld.com, letux-kernel@openphoenux.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Neil, > Am 15.04.2020 um 14:54 schrieb Neil Armstrong : > > Hi, > > On 15/04/2020 14:43, H. Nikolaus Schaller wrote: >> >>> Am 15.04.2020 um 12:12 schrieb Maxime Ripard : >>> >>> Hi, >>> >>> On Wed, Apr 15, 2020 at 10:35:08AM +0200, H. Nikolaus Schaller wrote: >>>> The Imagination PVR/SGX GPU is part of several SoC from >>>> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo, >>>> Allwinner A83 and others. >>>> >>>> With this binding, we describe how the SGX processor is >>>> interfaced to the SoC (registers, interrupt etc.). >>>> >>>> In most cases, Clock, Reset and power management is handled >>>> by a parent node or elsewhere (e.g. code in the driver). >>> >>> Wouldn't the "code in the driver" still require the clock / reset / >>> power domain to be set in the DT? >> >> Well, some SoC seem to use existing clocks and have no reset. >> Or, although not recommended, they may have the io-address range >> hard-coded. > > The possible clocks and resets should be added, even if optional. > > Please look at the arm utgard, midgard and bifrost bindings. Interesting to compare to. Maybe we should also add the $nodename: pattern: '^gpu@[a-f0-9]+$' But the sgx binding is difficult to grasp here. Some SoC like the omap series have their own ti,sysc based target modules and the gpu nodes is a child of it lacking any clock and reset references for purpose. The jz4780 and some other need a clocks definition, but no reset. Having a reset seems to be an option for the SoC designer and not mandated by img. So is it part of the pvrsgx bindings or the SoC? Well we could add clocks and resets as optional but that would allow to wrongly define omap. Or delegate them to a parent "simple-pm-bus" node. I have to study that material more to understand what you seem to expect. BR and thanks, Nikolaus Schaller _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel