From: Varka Bhadram <varkabhadram@gmail.com>
To: Shobhit Kumar <shobhit.kumar@intel.com>,
linux-pwm <linux-pwm@vger.kernel.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-gpio <linux-gpio@vger.kernel.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Paul Bolle <pebolle@tiscali.nl>,
Samuel Ortiz <sameo@linux.intel.com>,
Povilas Staniulis <wdmonster@gmail.com>,
Jani Nikula <jani.nikula@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
bloften80@gmail.com, David Airlie <airlied@linux.ie>,
Chih-Wei Huang <cwhuang@android-x86.org>,
Thierry Reding <thierry.reding@gmail.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [v3 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver
Date: Fri, 26 Jun 2015 18:01:53 +0530 [thread overview]
Message-ID: <558D4639.8000102@gmail.com> (raw)
In-Reply-To: <1435309330-50725-6-git-send-email-shobhit.kumar@intel.com>
On 06/26/2015 02:32 PM, Shobhit Kumar wrote:
> The Crystalcove PMIC provides three PWM signals and this driver exports
> one of them on the BYT platform which is used to control backlight for
> DSI panel. This is platform device implementation of the drivers/mfd
> cell device for CRC PMIC.
>
> CC: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Paul Bolle <pebolle@tiscali.nl>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> ---
> v2: Use the existing config callback with duty_ns and period_ns(Thierry)
>
> v3: Correct the subject line (Lee jones)
>
> v4: Address comment by Thierry & Paul
> - Commit message update and fixes for few syntax errors
> - Add PWM_CRC in Kconfig and Makefile sorted alphabetically
> - Use the PWM_BASE_CLK as 6000000 for better code readability
> - Remove the redundant rule of three while calculating pwm level
> - Use the platform_device in pwm_chip
> - Use builin_platform_driver
>
> v5: Address comments by Varka
> - Make the bit definition using BIT macro
> - reorder probe and remove code to directly return from pwmchip_add/remove
>
> drivers/pwm/Kconfig | 7 +++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-crc.c | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 151 insertions(+)
> create mode 100644 drivers/pwm/pwm-crc.c
Reviewed-by: Varka Bhadram <varkabhadram@gmail.com>
--
Best regards,
Varka Bhadram.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-26 12:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 9:02 [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control Shobhit Kumar
2015-06-26 9:02 ` [v3 1/7] gpiolib: Add support for removing registered consumer lookup table Shobhit Kumar
2015-07-01 7:46 ` Lee Jones
2015-06-26 9:02 ` [v3 2/7] mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal Shobhit Kumar
2015-06-26 9:02 ` [v3 3/7] mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC Shobhit Kumar
2015-06-26 9:02 ` [v3 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM Shobhit Kumar
2015-06-26 9:02 ` [v3 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver Shobhit Kumar
2015-06-26 12:31 ` Varka Bhadram [this message]
2015-06-26 9:02 ` [v3 6/7] drm/i915: Use the CRC gpio for panel enable/disable Shobhit Kumar
2015-06-26 9:02 ` [v3 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver Shobhit Kumar
2015-06-26 16:31 ` [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control Daniel Vetter
2015-06-26 17:47 ` Ville Syrjälä
2015-06-28 2:28 ` Shobhit Kumar
2015-06-28 22:18 ` [Intel-gfx] " Paul Gortmaker
2015-06-30 4:37 ` Brain WrecK
2015-07-10 13:06 ` Shobhit Kumar
2015-07-21 7:13 ` [Intel-gfx] " Shobhit Kumar
2015-07-21 7:24 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558D4639.8000102@gmail.com \
--to=varkabhadram@gmail.com \
--cc=airlied@linux.ie \
--cc=bloften80@gmail.com \
--cc=cwhuang@android-x86.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=pebolle@tiscali.nl \
--cc=sameo@linux.intel.com \
--cc=shobhit.kumar@intel.com \
--cc=thierry.reding@gmail.com \
--cc=wdmonster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).