From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush. Date: Wed, 05 Aug 2015 09:18:29 +0300 Message-ID: <55C1AAB5.8010006@gmail.com> References: <1437478142-416-1-git-send-email-maarten.lankhorst@linux.intel.com> <1437478142-416-3-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0631449265==" Return-path: In-Reply-To: <1437478142-416-3-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0631449265== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KmNxBHMOpPnNUFui9INxCR1TKIVg5kVVv" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KmNxBHMOpPnNUFui9INxCR1TKIVg5kVVv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, On 21/07/15 14:28, Maarten Lankhorst wrote: > In intel it's useful to keep track of some state changes with old > crtc state vs new state, for example to disable initial planes or > when a modeset's prevented during fastboot. >=20 > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 6 ++++-- > drivers/gpu/drm/drm_atomic_helper.c | 8 ++++---- > drivers/gpu/drm/drm_plane_helper.c | 4 ++-- > drivers/gpu/drm/i915/intel_display.c | 10 ++++++---- > drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 6 ++++-- > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 6 ++++-- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 6 ++++-- > drivers/gpu/drm/sti/sti_drm_crtc.c | 6 ++++-- > drivers/gpu/drm/tegra/dc.c | 6 ++++-- > include/drm/drm_crtc_helper.h | 6 ++++-- > 10 files changed, 40 insertions(+), 24 deletions(-) Looks like this broke omapdrm in linux-next: drivers/gpu/drm/omapdrm/omap_crtc.c:470:2: error: initialization from incompatible pointer type [-Werror] drivers/gpu/drm/omapdrm/omap_crtc.c:470:2: error: (near initialization for =E2=80=98omap_crtc_helper_funcs.atomic_begin=E2=80=99) [-Werror] drivers/gpu/drm/omapdrm/omap_crtc.c:471:2: error: initialization from incompatible pointer type [-Werror] drivers/gpu/drm/omapdrm/omap_crtc.c:471:2: error: (near initialization for =E2=80=98omap_crtc_helper_funcs.atomic_flush=E2=80=99) [-Werror] Tomi --KmNxBHMOpPnNUFui9INxCR1TKIVg5kVVv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVwaq4AAoJEPo9qoy8lh713IoQAKf8BQrKv+8Qwv55lNVhzOLk kny9XyQpvkw5xemUtX612a9MJoZZcvoGZndtK3XUoe19XEmHjb1EYNmNF4L5cAQP 02VRVVPOUZHiC0WQWPz+piua2QmC2GHIxlpUGeOfwVGwhdwp832ZGARydMGxcgz9 ISPoL/+DLQs+QNY1Tyi1p5wXRUnd0cfieOt1Zb7TNP/DJh9Dlnb33M2FTLRo1bKg aKEkMTPTcD1uMoHD+ET91nfJojkTnA4ulDXsqtSDzVgMBLi+Qe5v/UxMALaIkPUA U04AruKrpRYZ1WW2qAb5Pgd4R3a0Oevk82bSzcPKdvyGPS7iLVGUPgMTqNxDDRxn e/3wR60nNRqu6b1JYxDGqvSgJldt4g0NKVYTqQy6P8IQsSJho+3lyykWzc+s9hp9 h5QYGIn1nLqojojXGb50GPXM+i8A0PHXUu9mluOm/HXu8Qd/yVwxj6Ig7hizfs4g eE3cC0yqdwc/AmJioxtBKjha8IRNB+bRy+EbsxFGMZX6f37VvqJrry7dYvyOe8VM K+ejnMiqnAoo8YYnG/ilDnCrq/K5jm5vG7mZ1R/bA8dzw+53cabu3kNearPX98Xr kSLDX3rda8vNLg3sg9NYyfkE4Dp7uFXrH8FcCLYExu65Rj3QxohEplx3C8n1lqZN jV/507QAZ6uisPoak3Sw =vCnm -----END PGP SIGNATURE----- --KmNxBHMOpPnNUFui9INxCR1TKIVg5kVVv-- --===============0631449265== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0631449265==--