dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: xinlei.lee <xinlei.lee@mediatek.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: chunkuang.hu@kernel.org, Jitao Shi <jitao.shi@mediatek.com>,
	airlied@linux.ie, jason-jh.lin@mediatek.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	yongqiang.niu@mediatek.com,
	Project_Global_Chrome_Upstream_Group@mediatek.com,
	rex-bc.chen@mediatek.com, linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH v3,1/2] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186
Date: Mon, 29 Aug 2022 09:38:47 +0800	[thread overview]
Message-ID: <5675b49942f103f348e8bc4bec4cc2a60d4c4b30.camel@mediatek.com> (raw)
In-Reply-To: <20220826132942.k2rnlz5wwi62tity@notapiano>

On Fri, 2022-08-26 at 09:29 -0400, Nícolas F. R. A. Prado wrote:
> On Fri, Aug 26, 2022 at 02:12:00PM +0800, xinlei.lee wrote:
> > On Thu, 2022-08-25 at 17:04 +0200, Matthias Brugger wrote:
> > > 
> > > On 23/08/2022 22:17, Nícolas F. R. A. Prado wrote:
> > > > On Tue, Aug 23, 2022 at 02:38:22PM +0800, 
> > > > xinlei.lee@mediatek.com
> > > > wrote:
> > > > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > > > > 
> > > > > Add mmsys function to manipulate dpi output format
> > > > > configuration
> > > > > for MT8186.
> > > > > 
> > > > > Co-developed-by: Jitao Shi <jitao.shi@mediatek.com>
> > > > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> > > > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > > 
> > > > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > > > 
> > > 
> > > Patch looks fine, I'll wait for v4 as there is still some
> > > discussion
> > > on the DRM 
> > > part. Please try to fix the threading problem you had in sending
> > > this
> > > series.
> > > 
> > > Thanks,
> > > Matthias
> > 
> > Hi Matthias:
> > 
> > Thanks for your review.
> > 
> > Before I send the next version, do you mean the treading problem
> > you
> > are talking about is the problem I'm discussing in another patch in
> > this series, or something else?
> 
> Hi Xinlei,
> 
> no, the threading problem Matthias is referring to is the fact that
> this version
> of your series had two cover letters (patch 0) and a patch 2 [1],
> while patch 1
> was sent in a different email thread [2]. The whole series (cover
> letter,
> patches 1 and 2), should have been in the same email thread. Also, I
> noticed
> that your cover letter lists the patches with incorrect prefixes
> "FROMLIST".
> 
> So something weird happened when you sent this version of the series.
> It was ok
> in the previous version. So just make sure this is fixed when you
> send the next
> version of the series (after we finish the discussion on patch 2).
> 
> [1] 
> https://lore.kernel.org/linux-mediatek/1661235517-23699-1-git-send-email-xinlei.lee@mediatek.com/
> [2] 
> https://lore.kernel.org/linux-mediatek/1661236702-30682-1-git-send-email-xinlei.lee@mediatek.com/
> 
> Thanks,
> Nícolas

Hi Nícolas:

Thanks for the thoughtful explanation of this, I may know what caused
the two patches not to be in a series. 
I will fix this and revise the "FROMLIST" tag in the cover letter in
the next version.

Best Regards!
Xinlei


      reply	other threads:[~2022-08-29  1:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23  6:38 [PATCH v3, 1/2] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186 xinlei.lee
2022-08-23 20:17 ` [PATCH v3,1/2] " Nícolas F. R. A. Prado
2022-08-25 15:04   ` Matthias Brugger
2022-08-26  6:12     ` xinlei.lee
2022-08-26 13:29       ` Nícolas F. R. A. Prado
2022-08-29  1:38         ` xinlei.lee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5675b49942f103f348e8bc4bec4cc2a60d4c4b30.camel@mediatek.com \
    --to=xinlei.lee@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason-jh.lin@mediatek.com \
    --cc=jitao.shi@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=rex-bc.chen@mediatek.com \
    --cc=yongqiang.niu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).