dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: Dave Airlie <airlied@gmail.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH libdrm 1/2] drm/amdgpu: add syncobj create/destroy/import/export apis
Date: Tue, 18 Jul 2017 15:49:48 +0200	[thread overview]
Message-ID: <58c34d3a-a5a5-38b8-8c8b-dc02c4421c58@vodafone.de> (raw)
In-Reply-To: <20170718004832.21206-1-airlied@gmail.com>

Am 18.07.2017 um 02:48 schrieb Dave Airlie:
> From: Dave Airlie <airlied@redhat.com>
>
> These are just wrappers using the amdgpu device handle.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>

Reviewed-by: Christian König <christian.koenig@amd.com> for this one.

> ---
>   amdgpu/amdgpu.h    | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>   amdgpu/amdgpu_cs.c | 38 +++++++++++++++++++++++++++++++++++++
>   2 files changed, 92 insertions(+), 1 deletion(-)
>
> diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h
> index 1901fa8..183f974 100644
> --- a/amdgpu/amdgpu.h
> +++ b/amdgpu/amdgpu.h
> @@ -1328,8 +1328,61 @@ int amdgpu_cs_destroy_semaphore(amdgpu_semaphore_handle sem);
>   */
>   const char *amdgpu_get_marketing_name(amdgpu_device_handle dev);
>   
> +/**
> + *  Create kernel sync object
> + *
> + * \param   dev	      - \c [in]  device handle
> + * \param   syncobj   - \c [out] sync object handle
> + *
> + * \return   0 on success\n
> + *          <0 - Negative POSIX Error code
> + *
> +*/
> +int amdgpu_cs_create_syncobj(amdgpu_device_handle dev,
> +			     uint32_t *syncobj);
> +/**
> + *  Destroy kernel sync object
> + *
> + * \param   dev	    - \c [in] device handle
> + * \param   syncobj - \c [in] sync object handle
> + *
> + * \return   0 on success\n
> + *          <0 - Negative POSIX Error code
> + *
> +*/
> +int amdgpu_cs_destroy_syncobj(amdgpu_device_handle dev,
> +			      uint32_t syncobj);
> +
> +/**
> + *  Export kernel sync object to shareable fd.
> + *
> + * \param   dev	       - \c [in] device handle
> + * \param   syncobj    - \c [in] sync object handle
> + * \param   shared_fd  - \c [out] shared file descriptor.
> + *
> + * \return   0 on success\n
> + *          <0 - Negative POSIX Error code
> + *
> +*/
> +int amdgpu_cs_export_syncobj(amdgpu_device_handle dev,
> +			     uint32_t syncobj,
> +			     int *shared_fd);
> +/**
> + *  Import kernel sync object from shareable fd.
> + *
> + * \param   dev	       - \c [in] device handle
> + * \param   shared_fd  - \c [in] shared file descriptor.
> + * \param   syncobj    - \c [out] sync object handle
> + *
> + * \return   0 on success\n
> + *          <0 - Negative POSIX Error code
> + *
> +*/
> +int amdgpu_cs_import_syncobj(amdgpu_device_handle dev,
> +			     int shared_fd,
> +			     uint32_t *syncobj);
> +
>   #ifdef __cplusplus
>   }
>   #endif
> -
>   #endif /* #ifdef _AMDGPU_H_ */
> diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c
> index 868eb7b..722fd75 100644
> --- a/amdgpu/amdgpu_cs.c
> +++ b/amdgpu/amdgpu_cs.c
> @@ -596,3 +596,41 @@ int amdgpu_cs_destroy_semaphore(amdgpu_semaphore_handle sem)
>   {
>   	return amdgpu_cs_unreference_sem(sem);
>   }
> +
> +int amdgpu_cs_create_syncobj(amdgpu_device_handle dev,
> +			     uint32_t *handle)
> +{
> +	if (NULL == dev)
> +		return -EINVAL;
> +
> +	return drmSyncobjCreate(dev->fd, 0, handle);
> +}
> +
> +int amdgpu_cs_destroy_syncobj(amdgpu_device_handle dev,
> +			      uint32_t handle)
> +{
> +	if (NULL == dev)
> +		return -EINVAL;
> +
> +	return drmSyncobjDestroy(dev->fd, handle);
> +}
> +
> +int amdgpu_cs_export_syncobj(amdgpu_device_handle dev,
> +			     uint32_t handle,
> +			     int *shared_fd)
> +{
> +	if (NULL == dev)
> +		return -EINVAL;
> +
> +	return drmSyncobjHandleToFD(dev->fd, handle, shared_fd);
> +}
> +
> +int amdgpu_cs_import_syncobj(amdgpu_device_handle dev,
> +			     int shared_fd,
> +			     uint32_t *handle)
> +{
> +	if (NULL == dev)
> +		return -EINVAL;
> +
> +	return drmSyncobjFDToHandle(dev->fd, shared_fd, handle);
> +}


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2017-07-18 13:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18  0:48 [PATCH libdrm 1/2] drm/amdgpu: add syncobj create/destroy/import/export apis Dave Airlie
     [not found] ` <20170718004832.21206-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-07-18  0:48   ` [PATCH libdrm 2/2] drm/amdgpu: add new low overhead command submission API Dave Airlie
2017-07-18 13:51     ` Christian König
2017-07-18  2:48   ` [PATCH libdrm 1/2] drm/amdgpu: add syncobj create/destroy/import/export apis zhoucm1
2017-07-18 13:49 ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58c34d3a-a5a5-38b8-8c8b-dc02c4421c58@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=airlied@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).