From: Maximilian Weigand <mweigand@mweigand.net>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Maximilian Weigand" <mweigand2017@gmail.com>,
"Lee Jones" <lee@kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>, "Pavel Machek" <pavel@ucw.cz>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-leds@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: backlight: lm3630a: add entries to control boost frequency
Date: Sat, 17 Jun 2023 20:15:29 +0200 [thread overview]
Message-ID: <5d2eb5af-b674-751b-1583-e048fbf8c3a5@mweigand.net> (raw)
In-Reply-To: <c29b2b0c-2b0c-f79c-9de5-58a67edd5c87@linaro.org>
Hi,
On 17.06.23 19:42, Krzysztof Kozlowski wrote:
> On 17/06/2023 18:34, Heiko Stübner wrote:
>> Am Samstag, 17. Juni 2023, 12:12:17 CEST schrieb Krzysztof Kozlowski:
>>> On 14/06/2023 21:08, Maximilian Weigand wrote:
>>>> From: Maximilian Weigand <mweigand@mweigand.net>
>>>>
>>>> Add 'ti,boost_use_1mhz' to switch between 500 kHz and 1 MHz boost
>>>> converter switching frequency, and add 'ti,boost_frequency_shift' to
>>>> activate a frequency shift to 560 kHz or 1.12 MHz, respectively.
>>>>
>>>> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
>>>> ---
>>>> .../bindings/leds/backlight/lm3630a-backlight.yaml | 12 ++++++++++++
>>>> 1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>>>> index 3c9b4054ed9a..ef7ea0ad2d25 100644
>>>> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>>>> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>>>> @@ -33,6 +33,18 @@ properties:
>>>> description: GPIO to use to enable/disable the backlight (HWEN pin).
>>>> maxItems: 1
>>>>
>>>> + ti,boost_use_1mhz:
>>>
>>> No underscores in property names.
>>>
>>>> + description: |
>>>
>>> Do not need '|' unless you need to preserve formatting.
>>>
>>>> + If present, change the boost converter switching frequency from the
>>>> + default 500 kHz to 1 MHz. Refer to data sheet for hardware requirements.
>>>> + type: boolean
>>>> +
>>>> + ti,boost_frequency_shift:
>>>> + description: |
>>>> + If present, change boost converter switching frequency from 500 kHz to
>>>> + 560 kHz or from 1 Mhz to 1.12 Mhz, respectively.
>>>
>>> So just make it a property choosing the frequency, not bools, with
>>> proper unit suffix.
>>
>> i.e.
>> ti,boost-frequency-hz = <x>;
>> with x being 500000, 560000, 1000000, 1120000
>>
>> with the driver failing when the frequency is not achievable
>> with the two knobs of 1mhz and shift.
>
> Yeah, with a default value (500000, I guess).
Thanks for the feedback, this is quite obviously the better solution! I
will rework the submission accordingly.
Best regards
Maximilian
next prev parent reply other threads:[~2023-06-18 8:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 19:08 [PATCH 0/3] backlight: lm3630a: add functionality to change boost converter frequency Maximilian Weigand
2023-06-14 19:08 ` [PATCH 1/3] backlight: lm3630a: add support for changing the boost frequency Maximilian Weigand
2023-06-26 14:39 ` Daniel Thompson
2023-06-14 19:08 ` [PATCH 2/3] dt-bindings: backlight: lm3630a: add entries to control " Maximilian Weigand
2023-06-17 10:12 ` Krzysztof Kozlowski
2023-06-17 16:34 ` Heiko Stübner
2023-06-17 17:42 ` Krzysztof Kozlowski
2023-06-17 18:15 ` Maximilian Weigand [this message]
2023-06-14 19:08 ` [PATCH 3/3] arm64: dts: rockchip: shift boost frequency for rk3566-pinenote backlight Maximilian Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d2eb5af-b674-751b-1583-e048fbf8c3a5@mweigand.net \
--to=mweigand@mweigand.net \
--cc=conor+dt@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mweigand2017@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).