From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36820C433FE for ; Mon, 7 Nov 2022 16:13:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1EBC10E437; Mon, 7 Nov 2022 16:13:10 +0000 (UTC) Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 75AA510E437 for ; Mon, 7 Nov 2022 16:13:05 +0000 (UTC) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2A7CscDs015999; Mon, 7 Nov 2022 16:12:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=DZsj7aoQyhx3skjFI+mkgI7+S0Lk7iTOj70w3bTfyJI=; b=njTVAUOmf2bJoK9cSiJerlZQoUCQ484oyAJrKMt+yGPR/4k3WBOxAHxeU1Y6BRMcjCIr 3nFd03BEnx7zexjwh7DCDNBfJOfl/UbebpmWPbZg715bQs5cbk3QyActZSqE7S6mufgu crmC7N6AMBYiZPmbWqd9ZQQHUpaLB414yfFa1dBF6As2WDW6QKeS3yIFcZdfKrXIQvDr Q8lCFnfPeipZVnLdyU7KmS5nWbGS+vzN4RHUC/bfKfZKKh4nkVln6XN6kBVaBPNCekCT lYhXguSicrLH+fc3VpbTMtu3do1DnJPob6j5L8ems2YReBF3FYa2GO2AwjF4o0c/R5y2 4w== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3kpv531e19-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Nov 2022 16:12:42 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2A7GCfqA032589 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 7 Nov 2022 16:12:41 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 7 Nov 2022 08:12:39 -0800 Message-ID: <5fe8e8c0-d28b-3666-e437-10fa0c591ed8@quicinc.com> Date: Mon, 7 Nov 2022 09:12:39 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [RFC PATCH v3 1/3] drivers/accel: define kconfig and register a new major Content-Language: en-US To: Oded Gabbay , David Airlie , Daniel Vetter , Arnd Bergmann , Greg Kroah-Hartman , , , Jason Gunthorpe , John Hubbard , Alex Deucher References: <20221106210225.2065371-1-ogabbay@kernel.org> <20221106210225.2065371-2-ogabbay@kernel.org> From: Jeffrey Hugo In-Reply-To: <20221106210225.2065371-2-ogabbay@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 5n0pk1aK9w9zM02KzCZwCRGx0il16LL- X-Proofpoint-ORIG-GUID: 5n0pk1aK9w9zM02KzCZwCRGx0il16LL- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-07_08,2022-11-07_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 mlxscore=0 clxscore=1015 phishscore=0 spamscore=0 mlxlogscore=913 bulkscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211070130 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , Jacek Lawrynowicz , Jiho Chu , Randy Dunlap , Christoph Hellwig , Stanislaw Gruszka , Thomas Zimmermann , Kevin Hilman , Yuji Ishikawa , Maciej Kwapulinski , Jagan Teki Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 11/6/2022 2:02 PM, Oded Gabbay wrote: > +int __init accel_core_init(void) > +{ > + int ret; > + > + ret = accel_sysfs_init(); > + if (ret < 0) { > + DRM_ERROR("Cannot create ACCEL class: %d\n", ret); > + goto error; > + } > + > + accel_debugfs_root = debugfs_create_dir("accel", NULL); > + > + ret = register_chrdev(ACCEL_MAJOR, "accel", &accel_stub_fops); > + if (ret < 0) > + goto error; We are not jumping over anything here. Seems like this whole if block could just be removed. > + > +error: > + /* Any cleanup will be done in drm_core_exit() that will call > + * to accel_core_exit() > + */ This doesn't look like the standard multi-line comment style. Are we going to say that the accel subsystem follows net and differs from the kernel standard? > + return ret; > +}