From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77C44C43460 for ; Fri, 9 Apr 2021 08:11:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 395E661028 for ; Fri, 9 Apr 2021 08:11:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 395E661028 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F44B6EBA0; Fri, 9 Apr 2021 08:11:12 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C2B66EBA6 for ; Fri, 9 Apr 2021 08:11:10 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8FDD1B2EE; Fri, 9 Apr 2021 08:11:08 +0000 (UTC) Subject: Re: [PATCH 04/18] drm/vc4: txp: Properly set the possible_crtcs mask To: Maxime Ripard , Andrzej Hajda , Laurent Pinchart , Daniel Vetter , David Airlie , Jernej Skrabec , Maarten Lankhorst , Neil Armstrong , Jonas Karlman References: <20210317154352.732095-1-maxime@cerno.tech> <20210317154352.732095-5-maxime@cerno.tech> From: Thomas Zimmermann Message-ID: <627b8c9e-8035-2f44-7c30-f2442b519588@suse.de> Date: Fri, 9 Apr 2021 10:11:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210317154352.732095-5-maxime@cerno.tech> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell Content-Type: multipart/mixed; boundary="===============0286818664==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0286818664== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="br7oyBrYeG0DeKL30WBEe2dQZoIgWEIdF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --br7oyBrYeG0DeKL30WBEe2dQZoIgWEIdF Content-Type: multipart/mixed; boundary="67t6WmbipRqTJ2gzXtYG86Xilc89a781e"; protected-headers="v1" From: Thomas Zimmermann To: Maxime Ripard , Andrzej Hajda , Laurent Pinchart , Daniel Vetter , David Airlie , Jernej Skrabec , Maarten Lankhorst , Neil Armstrong , Jonas Karlman Cc: Tim Gover , Dave Stevenson , dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell Message-ID: <627b8c9e-8035-2f44-7c30-f2442b519588@suse.de> Subject: Re: [PATCH 04/18] drm/vc4: txp: Properly set the possible_crtcs mask References: <20210317154352.732095-1-maxime@cerno.tech> <20210317154352.732095-5-maxime@cerno.tech> In-Reply-To: <20210317154352.732095-5-maxime@cerno.tech> --67t6WmbipRqTJ2gzXtYG86Xilc89a781e Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 17.03.21 um 16:43 schrieb Maxime Ripard: > The current code does a binary or on the possible_crtcs variable of the= > TXP encoder, while we want to set it to that value instead. >=20 > Fixes: 39fcb2808376 ("drm/vc4: txp: Turn the TXP into a CRTC of its own= ") > Signed-off-by: Maxime Ripard Cc: # v5.9+ > --- > drivers/gpu/drm/vc4/vc4_txp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_tx= p.c > index c0122d83b651..2fc7f4b5fa09 100644 > --- a/drivers/gpu/drm/vc4/vc4_txp.c > +++ b/drivers/gpu/drm/vc4/vc4_txp.c > @@ -507,7 +507,7 @@ static int vc4_txp_bind(struct device *dev, struct = device *master, void *data) > return ret; > =20 > encoder =3D &txp->connector.encoder; > - encoder->possible_crtcs |=3D drm_crtc_mask(crtc); > + encoder->possible_crtcs =3D drm_crtc_mask(crtc); > =20 > ret =3D devm_request_irq(dev, irq, vc4_txp_interrupt, 0, > dev_name(dev), txp); >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --67t6WmbipRqTJ2gzXtYG86Xilc89a781e-- --br7oyBrYeG0DeKL30WBEe2dQZoIgWEIdF Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmBwDBsFAwAAAAAACgkQlh/E3EQov+DN MA/+M+k3u/sfIwM8MTH0f+qC1OSgju9v7XC5bNwsgego4lNG+17DgVe1k5Vu9GFvNqRq05/GO9/D fY3hqeY6if2aMwqSK935P9LFxO7E+rc4tpQYRIQJVhim33ZCGjiSAzNPDMIoLDUMF1geuaiy7wSL y8upIZYuoyYsZR1CK9Fzt4rSmVQ+eyqmGtAnJgdKtPjP+N+/2aZJSDLxodvDgllbcHXAaLWf25xj sZsexYx2rFoYVZ13DC0mOLABunskZzzAwB+V77zbNyypgEAoW4vlgV84CafC/Eu/vxkc54jX4i2n W5kB50HZRMJIPZhuIBOq2jjEaBEKSzvCzOPGi7xbZ8UmLcOCuUJhv7VypksqVTslkjOULvGL9u+S FFjt1HzxhD07m+8m2PaVRahXT3AUZ1RN4mtDWf40A+a4+1NdMonZuQ+kvnH8CE6NObkfLQvfL+Rn 3iPueHOzFWK2iC0Zmm5q9tzZw6jvsbvSmXAtz75B4igdNeCXcx/zFJNCCUJyMwCXsZVeUWHuHHcQ R4ekxYyZSnjA0VqZmhWGuW6U2m97rl0ugkUXJYPMatKDBH9boWaRUhxBJgvW3LZtc+HbUgQ/V/TU d9p/a06sVT5U4yDlYk0cAr1INJ032Wx7FTDAKliGWURxOC7f66JVLSL/7fJLSW344z+UsW3ZwGa8 FNI= =gYDe -----END PGP SIGNATURE----- --br7oyBrYeG0DeKL30WBEe2dQZoIgWEIdF-- --===============0286818664== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0286818664==--