From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 446C3C433DF for ; Wed, 20 May 2020 12:05:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18AD0207D4 for ; Wed, 20 May 2020 12:05:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="onX2mjo3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18AD0207D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 49F3188FAD; Wed, 20 May 2020 12:05:24 +0000 (UTC) Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E04C88FAD; Wed, 20 May 2020 12:05:23 +0000 (UTC) Received: by mail-ej1-x642.google.com with SMTP id a2so3443526ejb.10; Wed, 20 May 2020 05:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=IpcuDlVK4ewXDEYJwfHRhSq6queIrqFdGofnfdB2b5w=; b=onX2mjo3ZhjB0Rm0CUCdmoTq9xTcOPNo4s5dhyCMe2uhOVJMo7SZsPW9VGTeh20rH9 Zay7CC5J9eMlj0sywrYRVB9uRatEAZAtXXGRxMVXkdTFQ1sK6od0rnvplRyxfP2ypBIy 3fOk+Y6pqAI877qGZV9OO/rFrXX+8uScKcLpbOORM42wqnAlS1Xo5qCTFtIMx/KaxAW5 7zQzorlV+jpu38Za5wp9UlKpBJdvzePpr81AhfJeuX3UYcPAdK9lyRyLBZjPVANWNkdd 5ro6AbnmSMmcsjmW7ZjqI2wzwRUdgkhK8JZPXzkFr8PeMdayDguSyv/HTcuWoZ8Tunb0 dI7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=IpcuDlVK4ewXDEYJwfHRhSq6queIrqFdGofnfdB2b5w=; b=PSUrRMJMOeSyICJgJwwNPWBZbKm4HGrEBR26CZp93ErzrqQYV0cjZeijPrLlafAPLe Br2HuWx78J8+fxHxSXsVeAJFMoBSu2+pZm8wJZ9yDU/NrNOGEW5fI9S0Kru4ePLV5kb0 Ub/D6ApZcAZ73wxOirmaM1EGBQWSchrX9cscCFp/aSoPIEHo93Y66k4vRHHPUbczQYVc Qqp1dssadz4UnzY9p/BHFxP1dP/sRXs2Tiqf3PtiH57LoWnbHIkHAEa/5zeP8q6Kzg6Z iq5zCv6eXIdFUdVxqb/9HLCQgy0JvzMLO6cAv7NjeJOLWuAZxckNkLN54otl5UwIeQ7N Ohdg== X-Gm-Message-State: AOAM532sWNgZfPY3xqyDXzW18YJHhO+87/HQK5Z/Jp6zjPcelYpWaBWh kXJ5KQKZUp/u9gGJ1ZL2Ng8= X-Google-Smtp-Source: ABdhPJwr6r+idrtcT++eTWfSy6fLWhDhq5ATlJSlfd5P0GodqO/MjCxxPCBQLhArlKbZoForyIwaWg== X-Received: by 2002:a17:906:3cd:: with SMTP id c13mr3534648eja.164.1589976321947; Wed, 20 May 2020 05:05:21 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id g25sm1601766edm.57.2020.05.20.05.05.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 May 2020 05:05:21 -0700 (PDT) Subject: Re: [PATCH] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling To: Dan Carpenter , Alex Deucher , Kevin Wang References: <20200520120054.GB172354@mwanda> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <62d9d539-8401-233a-3f20-984042489987@gmail.com> Date: Wed, 20 May 2020 14:05:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200520120054.GB172354@mwanda> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Cc: David Airlie , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Rui Huang , dri-devel@lists.freedesktop.org, Yintian Tao , Evan Quan , Kenneth Feng , =?UTF-8?Q?Christian_K=c3=b6nig?= , Hawking Zhang Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am 20.05.20 um 14:00 schrieb Dan Carpenter: > This loop in the error handling code should start a "i - 1" and end at > "i == 0". Currently it starts a "i" and ends at "i == 1". The result > is that it removes one attribute that wasn't created yet, and leaks the > zeroeth attribute. > > Fixes: 4e01847c38f7 ("drm/amdgpu: optimize amdgpu device attribute code") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > index b75362bf0742..ee4a8e44fbeb 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > @@ -1931,7 +1931,7 @@ static int amdgpu_device_attr_create_groups(struct amdgpu_device *adev, > uint32_t mask) > { > int ret = 0; > - uint32_t i = 0; > + int i; > > for (i = 0; i < counts; i++) { > ret = amdgpu_device_attr_create(adev, &attrs[i], mask); > @@ -1942,9 +1942,8 @@ static int amdgpu_device_attr_create_groups(struct amdgpu_device *adev, > return 0; > > failed: > - for (; i > 0; i--) { > + while (--i >= 0) As far as I know the common idiom for this is while (i--) which even works without changing the type of i to signed. Christian. > amdgpu_device_attr_remove(adev, &attrs[i]); > - } > > return ret; > } _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel